common: fit-sig: Fix error message in fit_config_verify_sig()
PATCH 1/1 common: fit-sig: Fix error message in fit_config_verify_sig()
In fit_config_verify_sig(), when no 'signature*' subnode exists in the configuration node, the fdt_for_each_subnode() loop is a no-op. Therefore, no error flags are set, and 'err_,sg' is not populated with an error string. This is incorrect behavior.
Populate err_msg to indicate that no 'signature' is found, before entering the loop. The first call to fit_image_verify_sig() will override clear err_msg, or set it to a more specific message.
--- common/image-fit-sig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/image-fit-sig.c +1 -1
@@ -374,7 +374,7 @@ static int fit_config_verify_sig(const void *fit, int conf_noffset, const void *sig_blob, int sig_offset) { int noffset; -char *err_msg ="" ; +char *err_msg ="No 'signature' subnode found" ;int verified =0 ;int ret;
Signature · 1 line
2.26.2
PATCH 1/1 common: fit-sig: Fix error message in fit_config_verify_sig()
Quoted 6 lines · Alexandru Gagniuc
In
fit_config_verify_sig(), when no 'signature*' subnode exists in the configuration node, thefdt_for_each_subnode()loop is a no-op. Therefore, no error flags are set, and 'err_,sg' is not populated with an error string. This is incorrect behavior.
Quoted 8 lines
Populate
err_msgto indicate that no 'signature' is found, before entering the loop. The first call tofit_image_verify_sig()will override clearerr_msg, or set it to a more specific message.Signed-off-by Alexandru Gagniuc <[email protected]>--- common/image-fit-sig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
PATCH 1/1 common: fit-sig: Fix error message in fit_config_verify_sig()
In reply to Alexandru GagniucQuoted 11 lines · Alexandru Gagniuc
In
fit_config_verify_sig(), when no 'signature*' subnode exists in the configuration node, thefdt_for_each_subnode()loop is a no-op. Therefore, no error flags are set, and 'err_,sg' is not populated with an error string. This is incorrect behavior.Populate
err_msgto indicate that no 'signature' is found, before entering the loop. The first call tofit_image_verify_sig()will override clearerr_msg, or set it to a more specific message.Signed-off-by Alexandru Gagniuc <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210128/5e0fd6bd/attachment.sig>