drm/i915: move region_lmem under gt
Subsystems (2)
PATCH 1/1 drm/i915: move region_lmem under gt
Device local-memory should be thought of as part the GT, which means it should also sit under gt/.
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/{ => gt}/intel_region_lmem.c | 0
drivers/gpu/drm/i915/{ => gt}/intel_region_lmem.h | 0
drivers/gpu/drm/i915/i915_drv.h | 2 +-
4 files changed, 2 insertions(+), 2 deletions(-)
rename drivers/gpu/drm/i915/{ => gt}/intel_region_lmem.c (100%)
rename drivers/gpu/drm/i915/{ => gt}/intel_region_lmem.h (100%)drivers/gpu/drm/i915/Makefile +1 -1
@@ -110,6 +110,7 @@ gt-y += \ gt/intel_mocs.o \ gt/intel_ppgtt.o \ gt/intel_rc6.o \ + gt/intel_region_lmem.o \ gt/intel_renderstate.o \ gt/intel_reset.o \ gt/intel_ring.o \
@@ -170,7 +171,6 @@ i915-y += \ i915_scheduler.o \ i915_trace_points.o \ i915_vma.o \ - intel_region_lmem.o \ intel_wopcm.o # general-purpose microcontroller (GuC) support
drivers/gpu/drm/i915/gt/intel_region_lmem.c renamed from drivers/gpu/drm/i915/intel_region_lmem.c +0 -0
drivers/gpu/drm/i915/gt/intel_region_lmem.h renamed from drivers/gpu/drm/i915/intel_region_lmem.h +0 -0
drivers/gpu/drm/i915/i915_drv.h +1 -1
@@ -81,6 +81,7 @@#include "gt/intel_engine.h" #include "gt/intel_gt_types.h" +#include "gt/intel_region_lmem.h" #include "gt/intel_workarounds.h" #include "gt/uc/intel_uc.h"
@@ -102,7 +103,6 @@#include "i915_vma.h" #include "i915_irq.h" -#include "intel_region_lmem.h" /* General customization: */
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: move region_lmem under gt
== Series Details ==
== Series Details ==
Series: drm/i915: move region_lmem under gt
URL : https://patchwork.freedesktop.org/series/85760/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip b7c79e86103e drm/i915: move region_lmem under gt -:34: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #34: rename from drivers/gpu/drm/i915/intel_region_lmem.c
total: 0 errors, 1 warnings, 0 checks, 28 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: move region_lmem under gt
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: drm/i915: move region_lmem under gt
URL : https://patchwork.freedesktop.org/series/85760/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9594 -> Patchwork_19325
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19325 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_19325, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19325/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19325:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@blt:
- fi-snb-2520m: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9594/fi-snb-2520m/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19325/fi-snb-2520m/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_19325 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_tiled_pread_basic:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9594/fi-tgl-y/igt@gem_tiled_pread_basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19325/fi-tgl-y/igt@gem_tiled_pread_basic.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-icl-u2: [PASS][5] -> [DMESG-FAIL][6] ([i915#2291] / [i915#2601] / [i915#541])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9594/fi-icl-u2/igt@i915_selftest@live@gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19325/fi-icl-u2/igt@i915_selftest@live@gt_heartbeat.html
- fi-bsw-kefka: [PASS][7] -> [DMESG-FAIL][8] ([i915#2675] / [i915#541])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9594/fi-bsw-kefka/igt@i915_selftest@live@gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19325/fi-bsw-kefka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@sanitycheck:
- fi-kbl-7500u: [PASS][9] -> [DMESG-WARN][10] ([i915#2605])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9594/fi-kbl-7500u/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19325/fi-kbl-7500u/igt@i915_selftest@[email protected]
* igt@runner@aborted:
- fi-kbl-r: NOTRUN -> [FAIL][11] ([i915#1569] / [i915#192] / [i915#193] / [i915#194] / [i915#2295])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19325/fi-kbl-r/igt@[email protected]
#### Possible fixes ####
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [DMESG-WARN][12] ([i915#402]) -> [PASS][13] +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9594/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19325/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[i915#1569]: https://gitlab.freedesktop.org/drm/intel/issues/1569
[i915#192]: https://gitlab.freedesktop.org/drm/intel/issues/192
[i915#193]: https://gitlab.freedesktop.org/drm/intel/issues/193
[i915#194]: https://gitlab.freedesktop.org/drm/intel/issues/194
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2601]: https://gitlab.freedesktop.org/drm/intel/issues/2601
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#2675]: https://gitlab.freedesktop.org/drm/intel/issues/2675
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Participating hosts (44 -> 39)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9594 -> Patchwork_19325
CI-20190529: 20190529
CI_DRM_9594: 7ede24331ccbd4f8cce2b2e73b63bd49dc181560 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5956: d9bc7773043d11d37ae5b03bf18979541a9c7ef4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19325: b7c79e86103ed99a70f13bcc6f9e75f4681ce956 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b7c79e86103e drm/i915: move region_lmem under gt
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19325/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Matthew Auld (2021-01-12 16:43:00)
Quoted 5 lines
Device local-memory should be thought of as part the GT, which means it should also sit under gt/.
Suggested-by Chris Wilson <[email protected]>Signed-off-by Matthew Auld <[email protected]>
No significant change, yet.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx