xfs: remove a stale comment from xfs_file_aio_write_checks()
PATCH v3 1/1 xfs: remove a stale comment from xfs_file_aio_write_checks()
From: Eric Biggers <[email protected]>
The comment in xfs_file_aio_write_checks() about calling file_modified() after dropping the ilock doesn't make sense, because the code that unconditionally acquires and drops the ilock was removed by commit 467f78992a07 ("xfs: reduce ilock hold times in xfs_file_aio_write_checks").
Remove this outdated comment.
Reviewed-by Christoph Hellwig <[email protected]>
Reviewed-by Darrick J. Wong <[email protected]>
Signed-off-by Eric Biggers <[email protected]>
---
v3: resent as standalone patch and added a Reviewed-by.
fs/xfs/xfs_file.c | 6 ------ 1 file changed, 6 deletions(-)
fs/xfs/xfs_file.c +0 -6
@@ -389,12 +389,6 @@ xfs_file_aio_write_checks( }else spin_unlock (&ip->i_flags_lock); -/* -* Updating the timestamps will grab the ilock again from -* xfs_fs_dirty_inode, so we have to call it after dropping the -* lock above. Eventually we should look into a way to avoid -* the pointless lock roundtrip. -*/ return file_modified (file); }
base-commit: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62
Signature · 1 line
2.30.0