imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
PATCH 1/1 imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
From: Peng Fan <[email protected]>
Drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
---
This is to replace
https://patchwork.ozlabs.org/project/uboot/patch/20210103101144.4375-12-peng.fan at oss.nxp.com/
include/configs/imx8mn_evk.h | 2 -- include/configs/imx8mp_evk.h | 2 -- 2 files changed, 4 deletions(-)
include/configs/imx8mn_evk.h +0 -2
@@ -25,8 +25,6 @@#define CONFIG_SPL_BSS_MAX_SIZE SZ_8K/* 8 KB */ #define CONFIG_SYS_SPL_MALLOC_START 0x42200000#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K/* 512 KB */ -#define CONFIG_SYS_ICACHE_OFF -#define CONFIG_SYS_DCACHE_OFF /* For RAW image gives a error info not panic */ #define CONFIG_SPL_ABORT_ON_RAW_IMAGE
include/configs/imx8mp_evk.h +0 -2
@@ -26,8 +26,6 @@#define CONFIG_SPL_BSS_MAX_SIZE 0x400/* 1 KB */ #define CONFIG_SYS_SPL_MALLOC_START 0x42200000#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K/* 512 KB */ -#define CONFIG_SYS_ICACHE_OFF -#define CONFIG_SYS_DCACHE_OFF #define CONFIG_SPL_ABORT_ON_RAW_IMAGE
Signature · 1 line
2.28.0
Fabio Estevam
reviewerPATCH 1/1 imx: imx8mn/p: drop CONFIG_SYS_[I, D]CACHE_OFF in SPL stage
Hi Peng,
Quoted 4 lines · Peng Fan (OSS)
From: Peng Fan <[email protected]>
Drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
These options do not apply to SPL. The CONFIG_SPL_SYS_ICACHE_OFF and CONFIG_SPL_SYS_DCACHE_OFF do.
I agree with the change, but I think you need:
- Remove SPL from the Subject and commit log.
- Add a phrase saying that it is safe to run with caches enabled on these platforms.
PATCH 1/1 imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
Quoted 12 lines
Subject: Re: [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
Hi Peng,
Quoted 4 lines · Peng Fan (OSS)
From: Peng Fan <[email protected]>
Drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
Quoted 8 lines
These options do not apply to SPL. The
CONFIG_SPL_SYS_ICACHE_OFFandCONFIG_SPL_SYS_DCACHE_OFFdo.I agree with the change, but I think you need:
- Remove SPL from the Subject and commit log.
- Add a phrase saying that it is safe to run with caches enabled on these platforms.
Sure. Thanks.
-Peng.