Skip to contentSkip to conversation

clarify device reset

RFC PATCH Superseded Cornelia Huck 2 participants 2 messages Jan 14, 2021 – Jan 15, 2021

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 clarify device reset

Properly specify that the method for the driver to request a device reset is transport specific, and some action the device has to take.

---
 conformance.tex | 1 +
 content.tex     | 8 ++++++++
 2 files changed, 9 insertions(+)
conformance.tex +1 -0
index eb3324053080..baf4574e411f 100644
@@ -279,6 +279,7 @@ \section{Conformance Targets}\label{sec:Conformance / Conformance Targets}
 \item \ref{devicenormative:Basic Facilities of a Virtio Device / Virtqueues / The Virtqueue Used Ring}
 \item \ref{devicenormative:Basic Facilities of a Virtio Device / Virtqueues / Available Buffer Notification Suppression}
 \item \ref{devicenormative:Basic Facilities of a Virtio Device / Shared Memory Regions}
+\item \ref{devicenormative:General Initialization And Device Operation / Device Cleanup}
 \item \ref{devicenormative:Reserved Feature Bits}
 \end{itemize}
 
content.tex +8 -0
index 620c0e28c9a7..126b46996be8 100644
@@ -501,6 +501,8 @@ \section{Device Cleanup}\label{sec:General Initialization And Device Operation /
 virtqueue of the device are considered live.  None of the virtqueues
 of a device are live once the device has been reset.
 
+A driver can initiate a device reset by a transport-specific mechanism.
+
 \drivernormative{\subsection}{Device Cleanup}{General Initialization And Device Operation / Device Cleanup}
 
 A driver MUST NOT alter virtqueue entries for exposed buffers,
@@ -510,6 +512,12 @@ \section{Device Cleanup}\label{sec:General Initialization And Device Operation /
 
 Thus a driver MUST ensure a virtqueue isn't live (by device reset) before removing exposed buffers.
 
+\devicenormative{\subsection}{Device Cleanup}{General Initialization And Device Operation / Device Cleanup}
+
+A device MUST reinitialize device status to 0 after receiving a reset.
+
+A device MUST NOT send notifications after receiving a reset.
+
 \chapter{Virtio Transport Options}\label{sec:Virtio Transport Options}
 
 Virtio can use various different buses, thus the standard is split
Signature · 18 lines
2.26.2


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
#1 lore raw
Quoted 15 lines · Cornelia Huck

Properly specify that the method for the driver to request a device reset is transport specific, and some action the device has to take.

---
  conformance.tex | 1 +
  content.tex     | 8 ++++++++
  2 files changed, 9 insertions(+)
conformance.tex +0 -0
index eb3324053080..baf4574e411f 100644

conformance.tex \section{Conformance Targets}\label{sec:Conformance / Conformance Targets} · line 282

Quoted 4 lines
conformance.tex +1 -0
@@ -279,6 +279,7 @@ \section{Conformance Targets}\label{sec:Conformance / Conformance Targets}
  \item \ref{devicenormative:Basic Facilities of a Virtio Device / Virtqueues / The Virtqueue Used Ring}
  \item \ref{devicenormative:Basic Facilities of a Virtio Device / Virtqueues / Available Buffer Notification Suppression}
  \item \ref{devicenormative:Basic Facilities of a Virtio Device / Shared Memory Regions}
+\item \ref{devicenormative:General Initialization And Device Operation / Device Cleanup}

I wonder whether it's better to move this to "Basic Facilities of a Virtio Device"?

Thanks

Quoted 19 lines
conformance.tex +0 -0
  \item \ref{devicenormative:Reserved Feature Bits}
  \end{itemize}
 
content.tex +2 -0
index 620c0e28c9a7..126b46996be8 100644
@@ -501,6 +501,8 @@ \section{Device Cleanup}\label{sec:General Initialization And Device Operation /
  virtqueue of the device are considered live.  None of the virtqueues
  of a device are live once the device has been reset.
 
+A driver can initiate a device reset by a transport-specific mechanism.
+
  \drivernormative{\subsection}{Device Cleanup}{General Initialization And Device Operation / Device Cleanup}
 
  A driver MUST NOT alter virtqueue entries for exposed buffers,
@@ -510,6 +512,12 @@ \section{Device Cleanup}\label{sec:General Initialization And Device Operation /
 
  Thus a driver MUST ensure a virtqueue isn't live (by device reset) before removing exposed buffers.

content.tex \section{Device Cleanup}\label{sec:General Initialization And Device Operation / · line 523

Quoted 10 lines
content.tex +6 -0
 
+\devicenormative{\subsection}{Device Cleanup}{General Initialization And Device Operation / Device Cleanup}
+
+A device MUST reinitialize device status to 0 after receiving a reset.
+
+A device MUST NOT send notifications after receiving a reset.
+
  \chapter{Virtio Transport Options}\label{sec:Virtio Transport Options}
 
  Virtio can use various different buses, thus the standard is split

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/