Skip to contentSkip to conversation

appliance: Add vhd & vhdx support

PATCH In review Anatol Belski 3 participants 5 messages Jan 14, 2021 – Jan 16, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 appliance: Add vhd & vhdx support

From: Sinan Kaya <[email protected]>

This patch brings support for generating VHD/VHDX from WIC. It touches different areas but it needs to be applied at once for all the parts to concert. The patch could be split, if needed, otherwise considering OE-Core as target.

---
 bitbake/lib/toaster/orm/models.py                  |  4 ++--
 meta/classes/image-live.bbclass                    |  2 +-
 meta/classes/image_types.bbclass                   | 14 ++++++++++++--
 .../images/build-appliance-image_15.0.0.bb         |  4 +++-
 scripts/runqemu                                    |  8 +++++---
 5 files changed, 23 insertions(+), 9 deletions(-)
bitbake/lib/toaster/orm/models.py +2 -2
index 7f7e922ade..49dc7dae36 100644
@@ -583,7 +583,7 @@ class Build(models.Model):
         note that this is the actual list of extensions stored on Target objects
         for this build, and not the value of IMAGE_FSTYPES.
 
-        Returns comma-separated string, e.g. "vmdk, ext4"
+        Returns comma-separated string, e.g. "vmdk, vhd, vhdx, ext4"
         """
         extensions = []
 
@@ -970,7 +970,7 @@ class Target_Image_File(models.Model):
         'ext3', 'ext3.gz', 'ext4', 'ext4.gz', 'f2fs', 'hddimg', 'iso', 'jffs2',
         'jffs2.sum', 'multiubi', 'squashfs', 'squashfs-lz4', 'squashfs-lzo',
         'squashfs-xz', 'tar', 'tar.bz2', 'tar.gz', 'tar.lz4', 'tar.xz', 'ubi',
-        'ubifs', 'wic', 'wic.bz2', 'wic.gz', 'wic.lzma'
+        'ubifs', "vhd", 'vhdx', 'wic', 'wic.bz2', 'wic.gz', 'wic.lzma'
     }
 
     target = models.ForeignKey(Target, on_delete=models.CASCADE)
meta/classes/image-live.bbclass +1 -1
index 9ea5ddc312..1b2183eadd 100644
@@ -234,7 +234,7 @@ build_hddimg() {
 				bberror "${HDDDIR}/rootfs.img rootfs size is greather than or equal to 4GB,"
 				bberror "and this doesn't work on a FAT filesystem. You can either:"
 				bberror "1) Reduce the size of rootfs.img, or,"
-				bbfatal "2) Use wic, vmdk or vdi instead of hddimg\n"
+				bbfatal "2) Use wic, vmdk,vhd, vhdx or vdi instead of hddimg\n"
 			fi
 		fi
 
meta/classes/image_types.bbclass +12 -2
index 286009057e..0586c040bc 100644
@@ -269,7 +269,7 @@ IMAGE_TYPES = " \
 # CONVERSION_CMD/DEPENDS.
 COMPRESSIONTYPES ?= ""
 
-CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip zst sum md5sum sha1sum sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vdi qcow2 base64 ${COMPRESSIONTYPES}"
+CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip zst sum md5sum sha1sum sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vhd vhdx vdi qcow2 base64 ${COMPRESSIONTYPES}"
 CONVERSION_CMD_lzma = "lzma -k -f -7 ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"
 CONVERSION_CMD_gz = "gzip -f -9 -n -c --rsyncable ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz"
 CONVERSION_CMD_bz2 = "pbzip2 -f -k ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"
@@ -288,6 +288,8 @@ CONVERSION_CMD_sha512sum = "sha512sum ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}
 CONVERSION_CMD_bmap = "bmaptool create ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} -o ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.bmap"
 CONVERSION_CMD_u-boot = "mkimage -A ${UBOOT_ARCH} -O linux -T ramdisk -C none -n ${IMAGE_NAME} -d ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.u-boot"
 CONVERSION_CMD_vmdk = "qemu-img convert -O vmdk ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.vmdk"
+CONVERSION_CMD_vhdx = "qemu-img convert -O vhdx -o subformat=dynamic ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.vhdx"
+CONVERSION_CMD_vhd = "qemu-img convert -O vpc -o subformat=fixed ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.vhd"
 CONVERSION_CMD_vdi = "qemu-img convert -O vdi ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.vdi"
 CONVERSION_CMD_qcow2 = "qemu-img convert -O qcow2 ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.qcow2"
 CONVERSION_CMD_base64 = "base64 ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.base64"
@@ -303,9 +305,17 @@ CONVERSION_DEPENDS_sum = "mtd-utils-native"
 CONVERSION_DEPENDS_bmap = "bmap-tools-native"
 CONVERSION_DEPENDS_u-boot = "u-boot-tools-native"
 CONVERSION_DEPENDS_vmdk = "qemu-system-native"
+CONVERSION_DEPENDS_vhdx = "qemu-native"
+CONVERSION_DEPENDS_vhd = "qemu-native"
 CONVERSION_DEPENDS_vdi = "qemu-system-native"
 CONVERSION_DEPENDS_qcow2 = "qemu-system-native"
 CONVERSION_DEPENDS_base64 = "coreutils-native"
+CONVERSION_DEPENDS_u-boot = "u-boot-mkimage-native"
+CONVERSION_DEPENDS_vmdk = "qemu-native"
+CONVERSION_DEPENDS_vhdx = "qemu-native"
+CONVERSION_DEPENDS_vhd = "qemu-native"
+CONVERSION_DEPENDS_vdi = "qemu-native"
+CONVERSION_DEPENDS_qcow2 = "qemu-native"
 
 RUNNABLE_IMAGE_TYPES ?= "ext2 ext3 ext4"
 RUNNABLE_MACHINE_PATTERNS ?= "qemu"
@@ -313,7 +323,7 @@ RUNNABLE_MACHINE_PATTERNS ?= "qemu"
 DEPLOYABLE_IMAGE_TYPES ?= "hddimg iso" 
 
 # The IMAGE_TYPES_MASKED variable will be used to mask out from the IMAGE_FSTYPES,
-# images that will not be built at do_rootfs time: vmdk, vdi, qcow2, hddimg, iso, etc.
+# images that will not be built at do_rootfs time: vmdk, vhd, vhdx, vdi, qcow2, hddimg, iso, etc.
 IMAGE_TYPES_MASKED ?= ""
 
 # bmap requires python3 to be in the PATH
meta/recipes-core/images/build-appliance-image_15.0.0.bb +3 -1
index 8b95026218..c5c9d385ef 100644
@@ -20,7 +20,7 @@ IMAGE_ROOTFS_EXTRA_SPACE = "41943040"
 APPEND += "rootfstype=ext4 quiet"
 
 DEPENDS = "zip-native python3-pip-native"
-IMAGE_FSTYPES = "wic.vmdk"
+IMAGE_FSTYPES = "wic.vmdk wic.vhd wic.vhdx"
 
 inherit core-image module-base setuptools3
 
@@ -129,6 +129,8 @@ create_bundle_files () {
 	mkdir -p Yocto_Build_Appliance
 	cp *.vmx* Yocto_Build_Appliance
 	ln -sf ${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.wic.vmdk Yocto_Build_Appliance/Yocto_Build_Appliance.vmdk
+	ln -sf ${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.wic.vhdx Yocto_Build_Appliance/Yocto_Build_Appliance.vhdx
+	ln -sf ${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.wic.vhd Yocto_Build_Appliance/Yocto_Build_Appliance.vhd
 	zip -r ${IMGDEPLOYDIR}/Yocto_Build_Appliance-${DATETIME}.zip Yocto_Build_Appliance
 	ln -sf Yocto_Build_Appliance-${DATETIME}.zip ${IMGDEPLOYDIR}/Yocto_Build_Appliance.zip
 }
scripts/runqemu +5 -3
index e5e66f3453..dd92a64553 100755
@@ -94,11 +94,13 @@ Examples:
   runqemu qemux86-64 core-image-sato ext4
   runqemu qemux86-64 wic-image-minimal wic
   runqemu path/to/bzImage-qemux86.bin path/to/nfsrootdir/ serial
-  runqemu qemux86 iso/hddimg/wic.vmdk/wic.qcow2/wic.vdi/ramfs/cpio.gz...
+  runqemu qemux86 iso/hddimg/wic.vmdk/wic.vhd/wic.vhdx/wic.qcow2/wic.vdi/ramfs/cpio.gz...
   runqemu qemux86 qemuparams="-m 256"
   runqemu qemux86 bootparams="psplash=false"
   runqemu path/to/<image>-<machine>.wic
   runqemu path/to/<image>-<machine>.wic.vmdk
+  runqemu path/to/<image>-<machine>.wic.vhdx
+  runqemu path/to/<image>-<machine>.wic.vhd
 """)
 
 def check_tun():
@@ -179,7 +181,7 @@ class BaseConfig(object):
         self.portlocks = {}
         self.bitbake_e = ''
         self.snapshot = False
-        self.wictypes = ('wic', 'wic.vmdk', 'wic.qcow2', 'wic.vdi')
+        self.wictypes = ('wic', 'wic.vmdk', 'wic.qcow2', 'wic.vdi', "wic.vhd", "wic.vhdx")
         self.fstypes = ('ext2', 'ext3', 'ext4', 'jffs2', 'nfs', 'btrfs',
                         'cpio.gz', 'cpio', 'ramfs', 'tar.bz2', 'tar.gz')
         self.vmtypes = ('hddimg', 'iso')
@@ -1203,7 +1205,7 @@ class BaseConfig(object):
             return
         if 'wic.' in self.fstype:
             self.fstype = self.fstype[4:]
-        rootfs_format = self.fstype if self.fstype in ('vmdk', 'qcow2', 'vdi') else 'raw'
+        rootfs_format = self.fstype if self.fstype in ('vmdk', 'vhd', 'vhdx', 'qcow2', 'vdi') else 'raw'
 
         qb_rootfs_opt = self.get('QB_ROOTFS_OPT')
         if qb_rootfs_opt:
Signature · 1 line
2.17.1
#1 lore raw
Quoted 9 lines · Anatol Belski

From: Sinan Kaya <[email protected]>

This patch brings support for generating VHD/VHDX from WIC. It touches different areas but it needs to be applied at once for all the parts to concert. The patch could be split, if needed, otherwise considering OE-Core as target.

Quoted 7 lines

---

 bitbake/lib/toaster/orm/models.py                  |  4 ++--
 meta/classes/image-live.bbclass                    |  2 +-
 meta/classes/image_types.bbclass                   | 14 ++++++++++++--
 .../images/build-appliance-image_15.0.0.bb         |  4 +++-
 scripts/runqemu                                    |  8 +++++---
 5 files changed, 23 insertions(+), 9 deletions(-)

I had to split the patch into two pieces, one for bitbake and one for oe-core. In testing we see:

https://autobuilder.yoctoproject.org/typhoon/#/builders/23/builds/3166

which looks like there may be a missing qemuXXX-native dependency?

(not quite sure which native recipe provides qemu-img)

Cheers,

Richard

#2 lore raw
Quoted 17 lines · Richard Purdie
Quoted 9 lines · Anatol Belski

From: Sinan Kaya <[email protected]>

This patch brings support for generating VHD/VHDX from WIC. It touches different areas but it needs to be applied at once for all the parts to concert. The patch could be split, if needed, otherwise considering OE-Core as target.

Quoted 7 lines
---
  bitbake/lib/toaster/orm/models.py                  |  4 ++--
  meta/classes/image-live.bbclass                    |  2 +-
  meta/classes/image_types.bbclass                   | 14 ++++++++++++--
  .../images/build-appliance-image_15.0.0.bb         |  4 +++-
  scripts/runqemu                                    |  8 +++++---
  5 files changed, 23 insertions(+), 9 deletions(-)
Quoted 8 lines

I had to split the patch into two pieces, one for bitbake and one for oe-core. In testing we see:

https://autobuilder.yoctoproject.org/typhoon/#/builders/23/builds/3166

which looks like there may be a missing qemuXXX-native dependency?

(not quite sure which native recipe provides qemu-img)

Thanks for the test run, I'll check the issue and will split the patch.

Regards

Anatol

Quoted 7 lines

Cheers,

Richard

#3 lore raw
In reply to Anatol Belski
Quoted 32 lines · Anatol Belski

From: Sinan Kaya <[email protected]>

This patch brings support for generating VHD/VHDX from WIC. It touches different areas but it needs to be applied at once for all the parts to concert. The patch could be split, if needed, otherwise considering OE-Core as target.

---
 bitbake/lib/toaster/orm/models.py                  |  4 ++--
 meta/classes/image-live.bbclass                    |  2 +-
 meta/classes/image_types.bbclass                   | 14 ++++++++++++--
 .../images/build-appliance-image_15.0.0.bb         |  4 +++-
 scripts/runqemu                                    |  8 +++++---
 5 files changed, 23 insertions(+), 9 deletions(-)
bitbake/lib/toaster/orm/models.py +1 -1
index 7f7e922ade..49dc7dae36 100644
@@ -583,7 +583,7 @@ class Build(models.Model):
         note that this is the actual list of extensions stored on Target objects
         for this build, and not the value of IMAGE_FSTYPES.
 
-        Returns comma-separated string, e.g. "vmdk, ext4"
+        Returns comma-separated string, e.g. "vmdk, vhd, vhdx, ext4"
         """
         extensions = []
 

bitbake/lib/toaster/orm/models.py class Target_Image_File(models.Model): · line 976

Quoted 8 lines
bitbake/lib/toaster/orm/models.py +1 -1
@@ -970,7 +970,7 @@ class Target_Image_File(models.Model):
         'ext3', 'ext3.gz', 'ext4', 'ext4.gz', 'f2fs', 'hddimg', 'iso', 'jffs2',
         'jffs2.sum', 'multiubi', 'squashfs', 'squashfs-lz4', 'squashfs-lzo',
         'squashfs-xz', 'tar', 'tar.bz2', 'tar.gz', 'tar.lz4', 'tar.xz', 'ubi',
-        'ubifs', 'wic', 'wic.bz2', 'wic.gz', 'wic.lzma'
+        'ubifs', "vhd", 'vhdx', 'wic', 'wic.bz2', 'wic.gz', 'wic.lzma'
     }
 
     target = models.ForeignKey(Target, on_delete=models.CASCADE)

The above changes to bitbake need to be submitted to the bitbake-devel list (https://lists.openembedded.org/g/bitbake-devel) and should be based on the bitbake repository
(https://git.openembedded.org/bitbake/), i.e. the leading "bitbake/" in the path should be dropped.

Quoted 36 lines
meta/classes/image-live.bbclass +1 -1
index 9ea5ddc312..1b2183eadd 100644
@@ -234,7 +234,7 @@ build_hddimg() {
                                bberror "${HDDDIR}/rootfs.img rootfs size is greather than or equal to 4GB,"
                                bberror "and this doesn't work on a FAT filesystem. You can either:"
                                bberror "1) Reduce the size of rootfs.img, or,"
-                               bbfatal "2) Use wic, vmdk or vdi instead of hddimg\n"
+                               bbfatal "2) Use wic, vmdk,vhd, vhdx or vdi instead of hddimg\n"
                        fi
                fi
 
meta/classes/image_types.bbclass +3 -1
index 286009057e..0586c040bc 100644
@@ -269,7 +269,7 @@ IMAGE_TYPES = " \
 # CONVERSION_CMD/DEPENDS.
 COMPRESSIONTYPES ?= ""
 
-CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip zst sum md5sum sha1sum sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vdi qcow2 base64 ${COMPRESSIONTYPES}"
+CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip zst sum md5sum sha1sum sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vhd vhdx vdi qcow2 base64 ${COMPRESSIONTYPES}"
 CONVERSION_CMD_lzma = "lzma -k -f -7 ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"
 CONVERSION_CMD_gz = "gzip -f -9 -n -c --rsyncable ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz"
 CONVERSION_CMD_bz2 = "pbzip2 -f -k ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"
@@ -288,6 +288,8 @@ CONVERSION_CMD_sha512sum = "sha512sum ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}
 CONVERSION_CMD_bmap = "bmaptool create ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} -o ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.bmap"
 CONVERSION_CMD_u-boot = "mkimage -A ${UBOOT_ARCH} -O linux -T ramdisk -C none -n ${IMAGE_NAME} -d ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.u-boot"
 CONVERSION_CMD_vmdk = "qemu-img convert -O vmdk ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.vmdk"
+CONVERSION_CMD_vhdx = "qemu-img convert -O vhdx -o subformat=dynamic ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.vhdx"
+CONVERSION_CMD_vhd = "qemu-img convert -O vpc -o subformat=fixed ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.vhd"
 CONVERSION_CMD_vdi = "qemu-img convert -O vdi ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.vdi"
 CONVERSION_CMD_qcow2 = "qemu-img convert -O qcow2 ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.qcow2"
 CONVERSION_CMD_base64 = "base64 ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.base64"

meta/classes/image_types.bbclass CONVERSION_DEPENDS_sum = "mtd-utils-native" · line 309

Quoted 5 lines
meta/classes/image_types.bbclass +2 -0
@@ -303,9 +305,17 @@ CONVERSION_DEPENDS_sum = "mtd-utils-native"
 CONVERSION_DEPENDS_bmap = "bmap-tools-native"
 CONVERSION_DEPENDS_u-boot = "u-boot-tools-native"
 CONVERSION_DEPENDS_vmdk = "qemu-system-native"
+CONVERSION_DEPENDS_vhdx = "qemu-native"
+CONVERSION_DEPENDS_vhd = "qemu-native"

Is this intended to be different from the dependencies from vmdk above? You've got "qemu-native", vmdk has "qemu-system-native".

meta/classes/image_types.bbclass CONVERSION_DEPENDS_sum = "mtd-utils-native" · line 318

Quoted 9 lines
meta/classes/image_types.bbclass +6 -0
 CONVERSION_DEPENDS_vdi = "qemu-system-native"
 CONVERSION_DEPENDS_qcow2 = "qemu-system-native"
 CONVERSION_DEPENDS_base64 = "coreutils-native"
+CONVERSION_DEPENDS_u-boot = "u-boot-mkimage-native"
+CONVERSION_DEPENDS_vmdk = "qemu-native"
+CONVERSION_DEPENDS_vhdx = "qemu-native"
+CONVERSION_DEPENDS_vhd = "qemu-native"
+CONVERSION_DEPENDS_vdi = "qemu-native"
+CONVERSION_DEPENDS_qcow2 = "qemu-native"

This looks like it overwrites the above assignments. It also modifies the dependencies for other image types like u-boot and qcow2. What's the reason for these lines?

Quoted 17 lines
meta/classes/image_types.bbclass +1 -1
 RUNNABLE_IMAGE_TYPES ?= "ext2 ext3 ext4"
 RUNNABLE_MACHINE_PATTERNS ?= "qemu"
@@ -313,7 +323,7 @@ RUNNABLE_MACHINE_PATTERNS ?= "qemu"
 DEPLOYABLE_IMAGE_TYPES ?= "hddimg iso"
 
 # The IMAGE_TYPES_MASKED variable will be used to mask out from the IMAGE_FSTYPES,
-# images that will not be built at do_rootfs time: vmdk, vdi, qcow2, hddimg, iso, etc.
+# images that will not be built at do_rootfs time: vmdk, vhd, vhdx, vdi, qcow2, hddimg, iso, etc.
 IMAGE_TYPES_MASKED ?= ""
 
 # bmap requires python3 to be in the PATH
meta/recipes-core/images/build-appliance-image_15.0.0.bb +0 -0
index 8b95026218..c5c9d385ef 100644

meta/recipes-core/images/build-appliance-image_15.0.0.bb IMAGE_ROOTFS_EXTRA_SPACE = "41943040" · line 23

Quoted 5 lines
meta/recipes-core/images/build-appliance-image_15.0.0.bb +1 -1
@@ -20,7 +20,7 @@ IMAGE_ROOTFS_EXTRA_SPACE = "41943040"
 APPEND += "rootfstype=ext4 quiet"
 
 DEPENDS = "zip-native python3-pip-native"
-IMAGE_FSTYPES = "wic.vmdk"
+IMAGE_FSTYPES = "wic.vmdk wic.vhd wic.vhdx"

Do we need to generate vhd and vhdx images for the build appliance? Are you actually using these or just trying to build all relevant images?

Quoted 41 lines
meta/recipes-core/images/build-appliance-image_15.0.0.bb +2 -0
 inherit core-image module-base setuptools3
 
@@ -129,6 +129,8 @@ create_bundle_files () {
        mkdir -p Yocto_Build_Appliance
        cp *.vmx* Yocto_Build_Appliance
        ln -sf ${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.wic.vmdk Yocto_Build_Appliance/Yocto_Build_Appliance.vmdk
+       ln -sf ${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.wic.vhdx Yocto_Build_Appliance/Yocto_Build_Appliance.vhdx
+       ln -sf ${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.wic.vhd Yocto_Build_Appliance/Yocto_Build_Appliance.vhd
        zip -r ${IMGDEPLOYDIR}/Yocto_Build_Appliance-${DATETIME}.zip Yocto_Build_Appliance
        ln -sf Yocto_Build_Appliance-${DATETIME}.zip ${IMGDEPLOYDIR}/Yocto_Build_Appliance.zip
 }
scripts/runqemu +4 -2
index e5e66f3453..dd92a64553 100755
@@ -94,11 +94,13 @@ Examples:
   runqemu qemux86-64 core-image-sato ext4
   runqemu qemux86-64 wic-image-minimal wic
   runqemu path/to/bzImage-qemux86.bin path/to/nfsrootdir/ serial
-  runqemu qemux86 iso/hddimg/wic.vmdk/wic.qcow2/wic.vdi/ramfs/cpio.gz...
+  runqemu qemux86 iso/hddimg/wic.vmdk/wic.vhd/wic.vhdx/wic.qcow2/wic.vdi/ramfs/cpio.gz...
   runqemu qemux86 qemuparams="-m 256"
   runqemu qemux86 bootparams="psplash=false"
   runqemu path/to/<image>-<machine>.wic
   runqemu path/to/<image>-<machine>.wic.vmdk
+  runqemu path/to/<image>-<machine>.wic.vhdx
+  runqemu path/to/<image>-<machine>.wic.vhd
 """)
 
 def check_tun():
@@ -179,7 +181,7 @@ class BaseConfig(object):
         self.portlocks = {}
         self.bitbake_e = ''
         self.snapshot = False
-        self.wictypes = ('wic', 'wic.vmdk', 'wic.qcow2', 'wic.vdi')
+        self.wictypes = ('wic', 'wic.vmdk', 'wic.qcow2', 'wic.vdi', "wic.vhd", "wic.vhdx")
         self.fstypes = ('ext2', 'ext3', 'ext4', 'jffs2', 'nfs', 'btrfs',
                         'cpio.gz', 'cpio', 'ramfs', 'tar.bz2', 'tar.gz')
         self.vmtypes = ('hddimg', 'iso')

scripts/runqemu class BaseConfig(object): · line 1211

Quoted 8 lines
scripts/runqemu +1 -1
@@ -1203,7 +1205,7 @@ class BaseConfig(object):
             return
         if 'wic.' in self.fstype:
             self.fstype = self.fstype[4:]
-        rootfs_format = self.fstype if self.fstype in ('vmdk', 'qcow2', 'vdi') else 'raw'
+        rootfs_format = self.fstype if self.fstype in ('vmdk', 'vhd', 'vhdx', 'qcow2', 'vdi') else 'raw'
 
         qb_rootfs_opt = self.get('QB_ROOTFS_OPT')
         if qb_rootfs_opt:

I actually recommend splitting the runqemu changes off into another patch. So you'd have one patch for image_types, one patch for bitbake and one patch for runqemu.

Thanks,

Signature · 2 lines
Paul Barker
Konsulko Group
#4 lore raw
Quoted 82 lines · Paul Barker
Quoted 31 lines · Anatol Belski

From: Sinan Kaya <[email protected]>

This patch brings support for generating VHD/VHDX from WIC. It touches different areas but it needs to be applied at once for all the parts to concert. The patch could be split, if needed, otherwise considering OE-Core as target.

---
  bitbake/lib/toaster/orm/models.py                  |  4 ++--
  meta/classes/image-live.bbclass                    |  2 +-
  meta/classes/image_types.bbclass                   | 14 ++++++++++++--
  .../images/build-appliance-image_15.0.0.bb         |  4 +++-
  scripts/runqemu                                    |  8 +++++---
  5 files changed, 23 insertions(+), 9 deletions(-)
bitbake/lib/toaster/orm/models.py +1 -1
index 7f7e922ade..49dc7dae36 100644
@@ -583,7 +583,7 @@ class Build(models.Model):
          note that this is the actual list of extensions stored on Target objects
          for this build, and not the value of IMAGE_FSTYPES.
 
-        Returns comma-separated string, e.g. "vmdk, ext4"
+        Returns comma-separated string, e.g. "vmdk, vhd, vhdx, ext4"
          """
          extensions = []
 

bitbake/lib/toaster/orm/models.py class Target_Image_File(models.Model): · line 976

Quoted 8 lines
bitbake/lib/toaster/orm/models.py +1 -1
@@ -970,7 +970,7 @@ class Target_Image_File(models.Model):
          'ext3', 'ext3.gz', 'ext4', 'ext4.gz', 'f2fs', 'hddimg', 'iso', 'jffs2',
          'jffs2.sum', 'multiubi', 'squashfs', 'squashfs-lz4', 'squashfs-lzo',
          'squashfs-xz', 'tar', 'tar.bz2', 'tar.gz', 'tar.lz4', 'tar.xz', 'ubi',
-        'ubifs', 'wic', 'wic.bz2', 'wic.gz', 'wic.lzma'
+        'ubifs', "vhd", 'vhdx', 'wic', 'wic.bz2', 'wic.gz', 'wic.lzma'
      }
 
      target = models.ForeignKey(Target, on_delete=models.CASCADE)

The above changes to bitbake need to be submitted to the bitbake-devel list (https://lists.openembedded.org/g/bitbake-devel) and should be based on the bitbake repository
(https://git.openembedded.org/bitbake/), i.e. the leading "bitbake/" in the path should be dropped.

Quoted 35 lines
meta/classes/image-live.bbclass +1 -1
index 9ea5ddc312..1b2183eadd 100644
@@ -234,7 +234,7 @@ build_hddimg() {
                                 bberror "${HDDDIR}/rootfs.img rootfs size is greather than or equal to 4GB,"
                                 bberror "and this doesn't work on a FAT filesystem. You can either:"
                                 bberror "1) Reduce the size of rootfs.img, or,"
-                               bbfatal "2) Use wic, vmdk or vdi instead of hddimg\n"
+                               bbfatal "2) Use wic, vmdk,vhd, vhdx or vdi instead of hddimg\n"
                         fi
                 fi
 
meta/classes/image_types.bbclass +3 -1
index 286009057e..0586c040bc 100644
@@ -269,7 +269,7 @@ IMAGE_TYPES = " \
  # CONVERSION_CMD/DEPENDS.
  COMPRESSIONTYPES ?= ""
 
-CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip zst sum md5sum sha1sum sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vdi qcow2 base64 ${COMPRESSIONTYPES}"
+CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip zst sum md5sum sha1sum sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vhd vhdx vdi qcow2 base64 ${COMPRESSIONTYPES}"
  CONVERSION_CMD_lzma = "lzma -k -f -7 ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"
  CONVERSION_CMD_gz = "gzip -f -9 -n -c --rsyncable ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz"
  CONVERSION_CMD_bz2 = "pbzip2 -f -k ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"
@@ -288,6 +288,8 @@ CONVERSION_CMD_sha512sum = "sha512sum ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}
  CONVERSION_CMD_bmap = "bmaptool create ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} -o ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.bmap"
  CONVERSION_CMD_u-boot = "mkimage -A ${UBOOT_ARCH} -O linux -T ramdisk -C none -n ${IMAGE_NAME} -d ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.u-boot"
  CONVERSION_CMD_vmdk = "qemu-img convert -O vmdk ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.vmdk"
+CONVERSION_CMD_vhdx = "qemu-img convert -O vhdx -o subformat=dynamic ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.vhdx"
+CONVERSION_CMD_vhd = "qemu-img convert -O vpc -o subformat=fixed ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.vhd"
  CONVERSION_CMD_vdi = "qemu-img convert -O vdi ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.vdi"
  CONVERSION_CMD_qcow2 = "qemu-img convert -O qcow2 ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.qcow2"
  CONVERSION_CMD_base64 = "base64 ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.base64"
Quoted 8 lines

meta/classes/image_types.bbclass CONVERSION_DEPENDS_sum = "mtd-utils-native" · line 309

Quoted 6 lines
meta/classes/image_types.bbclass +2 -0
@@ -303,9 +305,17 @@ CONVERSION_DEPENDS_sum = "mtd-utils-native"
  CONVERSION_DEPENDS_bmap = "bmap-tools-native"
  CONVERSION_DEPENDS_u-boot = "u-boot-tools-native"
  CONVERSION_DEPENDS_vmdk = "qemu-system-native"
+CONVERSION_DEPENDS_vhdx = "qemu-native"
+CONVERSION_DEPENDS_vhd = "qemu-native"

Is this intended to be different from the dependencies from vmdk above? You've got "qemu-native", vmdk has "qemu-system-native".

Oh, this might be the exact point why for the autobuilder fail. And the other things should not be overridden, how it looks like.

Quoted 32 lines

meta/classes/image_types.bbclass CONVERSION_DEPENDS_sum = "mtd-utils-native" · line 318

Quoted 10 lines
meta/classes/image_types.bbclass +6 -0
  CONVERSION_DEPENDS_vdi = "qemu-system-native"
  CONVERSION_DEPENDS_qcow2 = "qemu-system-native"
  CONVERSION_DEPENDS_base64 = "coreutils-native"
+CONVERSION_DEPENDS_u-boot = "u-boot-mkimage-native"
+CONVERSION_DEPENDS_vmdk = "qemu-native"
+CONVERSION_DEPENDS_vhdx = "qemu-native"
+CONVERSION_DEPENDS_vhd = "qemu-native"
+CONVERSION_DEPENDS_vdi = "qemu-native"
+CONVERSION_DEPENDS_qcow2 = "qemu-native"

This looks like it overwrites the above assignments. It also modifies the dependencies for other image types like u-boot and qcow2. What's the reason for these lines?

Quoted 18 lines
meta/classes/image_types.bbclass +1 -1
  RUNNABLE_IMAGE_TYPES ?= "ext2 ext3 ext4"
  RUNNABLE_MACHINE_PATTERNS ?= "qemu"
@@ -313,7 +323,7 @@ RUNNABLE_MACHINE_PATTERNS ?= "qemu"
  DEPLOYABLE_IMAGE_TYPES ?= "hddimg iso"
 
  # The IMAGE_TYPES_MASKED variable will be used to mask out from the IMAGE_FSTYPES,
-# images that will not be built at do_rootfs time: vmdk, vdi, qcow2, hddimg, iso, etc.
+# images that will not be built at do_rootfs time: vmdk, vhd, vhdx, vdi, qcow2, hddimg, iso, etc.
  IMAGE_TYPES_MASKED ?= ""
 
  # bmap requires python3 to be in the PATH
meta/recipes-core/images/build-appliance-image_15.0.0.bb +0 -0
index 8b95026218..c5c9d385ef 100644
@@ -20,7 +20,7 @@ IMAGE_ROOTFS_EXTRA_SPACE = "41943040"
  APPEND += "rootfstype=ext4 quiet"
 
Quoted 6 lines

meta/recipes-core/images/build-appliance-image_15.0.0.bb IMAGE_ROOTFS_EXTRA_SPACE = "41943040" · line 23

Quoted 3 lines
meta/recipes-core/images/build-appliance-image_15.0.0.bb +1 -1
  DEPENDS = "zip-native python3-pip-native"
-IMAGE_FSTYPES = "wic.vmdk"
+IMAGE_FSTYPES = "wic.vmdk wic.vhd wic.vhdx"

Do we need to generate vhd and vhdx images for the build appliance? Are you actually using these or just trying to build all relevant images?

Yep, we use the the VHD/VHDX. As the recipe is a generic appliance, it seemed the right place to contribute this change.

Quoted 46 lines
Quoted 46 lines
meta/recipes-core/images/build-appliance-image_15.0.0.bb +2 -0
  inherit core-image module-base setuptools3
 
@@ -129,6 +129,8 @@ create_bundle_files () {
         mkdir -p Yocto_Build_Appliance
         cp *.vmx* Yocto_Build_Appliance
         ln -sf ${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.wic.vmdk Yocto_Build_Appliance/Yocto_Build_Appliance.vmdk
+       ln -sf ${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.wic.vhdx Yocto_Build_Appliance/Yocto_Build_Appliance.vhdx
+       ln -sf ${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.wic.vhd Yocto_Build_Appliance/Yocto_Build_Appliance.vhd
         zip -r ${IMGDEPLOYDIR}/Yocto_Build_Appliance-${DATETIME}.zip Yocto_Build_Appliance
         ln -sf Yocto_Build_Appliance-${DATETIME}.zip ${IMGDEPLOYDIR}/Yocto_Build_Appliance.zip
  }
scripts/runqemu +5 -3
index e5e66f3453..dd92a64553 100755
@@ -94,11 +94,13 @@ Examples:
    runqemu qemux86-64 core-image-sato ext4
    runqemu qemux86-64 wic-image-minimal wic
    runqemu path/to/bzImage-qemux86.bin path/to/nfsrootdir/ serial
-  runqemu qemux86 iso/hddimg/wic.vmdk/wic.qcow2/wic.vdi/ramfs/cpio.gz...
+  runqemu qemux86 iso/hddimg/wic.vmdk/wic.vhd/wic.vhdx/wic.qcow2/wic.vdi/ramfs/cpio.gz...
    runqemu qemux86 qemuparams="-m 256"
    runqemu qemux86 bootparams="psplash=false"
    runqemu path/to/<image>-<machine>.wic
    runqemu path/to/<image>-<machine>.wic.vmdk
+  runqemu path/to/<image>-<machine>.wic.vhdx
+  runqemu path/to/<image>-<machine>.wic.vhd
  """)
 
  def check_tun():
@@ -179,7 +181,7 @@ class BaseConfig(object):
          self.portlocks = {}
          self.bitbake_e = ''
          self.snapshot = False
-        self.wictypes = ('wic', 'wic.vmdk', 'wic.qcow2', 'wic.vdi')
+        self.wictypes = ('wic', 'wic.vmdk', 'wic.qcow2', 'wic.vdi', "wic.vhd", "wic.vhdx")
          self.fstypes = ('ext2', 'ext3', 'ext4', 'jffs2', 'nfs', 'btrfs',
                          'cpio.gz', 'cpio', 'ramfs', 'tar.bz2', 'tar.gz')
          self.vmtypes = ('hddimg', 'iso')
@@ -1203,7 +1205,7 @@ class BaseConfig(object):
              return
          if 'wic.' in self.fstype:
              self.fstype = self.fstype[4:]
-        rootfs_format = self.fstype if self.fstype in ('vmdk', 'qcow2', 'vdi') else 'raw'
+        rootfs_format = self.fstype if self.fstype in ('vmdk', 'vhd', 'vhdx', 'qcow2', 'vdi') else 'raw'
 
Quoted 5 lines

scripts/runqemu class BaseConfig(object): · line 1211

Quoted 2 lines
scripts/runqemu +0 -0
          qb_rootfs_opt = self.get('QB_ROOTFS_OPT')
          if qb_rootfs_opt:

I actually recommend splitting the runqemu changes off into another patch. So you'd have one patch for image_types, one patch for bitbake and one patch for runqemu.

ACK, i'll do that and send the bitbake to the dedicated list. Initially i was just concerned as i'm not sure how to link those parts together. Probably could just link to the related patch on the web interface, anyway.

Thanks!

Anatol

Quoted 5 lines

Thanks,