i2c: i801: Add support for Intel Alder Lake PCH-P
PATCH 1/1 i2c: i801: Add support for Intel Alder Lake PCH-P
Add PCI ID of SMBus controller on Intel Alder Lake PCH-P.
--- drivers/i2c/busses/i2c-i801.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/i2c/busses/i2c-i801.c +4 -0
@@ -73,6 +73,7 @@* Jasper Lake (SOC) 0x4da3 32 hard yes yes yes * Comet Lake-V (PCH) 0xa3a3 32 hard yes yes yes * Alder Lake-S (PCH) 0x7aa3 32 hard yes yes yes +* Alder Lake-P (PCH) 0x51a3 32 hard yes yes yes * * Features supported by this driver: * Software PEC no
@@ -230,6 +231,7 @@#define PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS 0x43a3#define PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS 0x4b23#define PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS 0x4da3 +#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS 0x51a3#define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS 0x5ad4#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS 0x7aa3#define PCI_DEVICE_ID_INTEL_LYNXPOINT_SMBUS 0x8c22
@@ -1087,6 +1089,7 @@ static const struct pci_device_id i801_ids[] = { { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS) }, { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS) }, { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS) }, + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS) }, { 0, } };
@@ -1776,6 +1779,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)case PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS :case PCI_DEVICE_ID_INTEL_EBG_SMBUS :case PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS : +case PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS : priv->features |=FEATURE_BLOCK_PROC ; priv->features |=FEATURE_I2C_BLOCK_READ ; priv->features |=FEATURE_IRQ ;
Signature · 1 line
2.29.2
Quoted 3 lines · Jarkko Nikula
Add PCI ID of SMBus controller on Intel Alder Lake PCH-P.
Signed-off-by Jarkko Nikula <[email protected]>
Do we still update Documentation/i2c/busses/i2c-i801.rst?
And maybe we should add Jarkko as i801 maintainer because Jean is usually fine with such changes?
Quoted 43 lines
--- drivers/i2c/busses/i2c-i801.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/i2c/busses/i2c-i801.c +4
-0@@ -73,6 +73,7 @@* Jasper Lake (SOC) 0x4da3 32 hard yes yes yes * Comet Lake-V (PCH) 0xa3a3 32 hard yes yes yes * Alder Lake-S (PCH) 0x7aa3 32 hard yes yes yes +* Alder Lake-P (PCH) 0x51a3 32 hard yes yes yes * * Features supported by this driver: * Software PEC no @@ -230,6 +231,7 @@#define PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS 0x43a3#define PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS 0x4b23#define PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS 0x4da3 +#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS 0x51a3#define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS 0x5ad4#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS 0x7aa3#define PCI_DEVICE_ID_INTEL_LYNXPOINT_SMBUS 0x8c22@@ -1087,6 +1089,7 @@ static const struct pci_device_id i801_ids[] = { { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS) }, { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS) }, { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS) }, + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS) }, { 0, } };@@ -1776,6 +1779,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)case PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS :case PCI_DEVICE_ID_INTEL_EBG_SMBUS :case PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS : +case PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS : priv->features |=FEATURE_BLOCK_PROC ; priv->features |=FEATURE_I2C_BLOCK_READ ; priv->features |=FEATURE_IRQ ;Signature · 1 line
2.29.2
Quoted 7 lines · Wolfram Sang
Quoted 3 lines · Jarkko Nikula
Add PCI ID of SMBus controller on Intel Alder Lake PCH-P.
Signed-off-by Jarkko Nikula <[email protected]>Do we still update
Documentation/i2c/busses/i2c-i801.rst?
Actually need to avoid patching it and Kconfig for each new chipset variant and make them shorter was my motivation behind commit 80d943ab19e9 ("i2c: i801: Consolidate chipset names in documentation and Kconfig").
Here Alder Lake name was added by the commit 332fdaebb64e ("i2c: i801: Add support for Intel Alder Lake PCH-S").
Quoted 3 lines
And maybe we should add Jarkko as i801 maintainer because Jean is usually fine with such changes?
I'm not sure am I up to the task? Meaning I don't feel I know it so well. I've been mostly adding new PCI IDs to new platforms.
Jarkko
Wolfram Sang
AppliedQuoted 4 lines
Actually need to avoid patching it and
Kconfigfor each new chipset variant and make them shorter was my motivation behind commit80d943ab19e9("i2c:
i801: Consolidate chipset names in documentation andKconfig").
OK, I'll try to remember next time ;)
Quoted 5 lines
Quoted 3 lines
And maybe we should add Jarkko as i801 maintainer because Jean is usually fine with such changes?
I'm not sure am I up to the task? Meaning I don't feel I know it so well. I've been mostly adding new PCI IDs to new platforms.
OK, I was just asking. Jean seems to be MIA, so:
Applied to for-next, thanks!
Jean Delvare
Reviewed-byQuoted 9 lines · Wolfram Sang
Quoted 3 lines
Actually need to avoid patching it and
Kconfigfor each new chipset variant and make them shorter was my motivation behind commit80d943ab19e9("i2c:
i801: Consolidate chipset names in documentation andKconfig").OK, I'll try to remember next time ;)
Quoted 3 lines
Quoted 3 lines
And maybe we should add Jarkko as i801 maintainer because Jean is usually fine with such changes?
Quoted 6 lines
Quoted 2 lines
I'm not sure am I up to the task? Meaning I don't feel I know it so well. I've been mostly adding new PCI IDs to new platforms.
OK, I was just asking. Jean seems to be MIA, so:
Applied to for-next, thanks!
Sorry, I somehow missed this thread. Looks all good to me, thanks Jarkko and Wolfram.
Signature · 2 lines
Jean Delvare SUSE L3 Support