Skip to contentSkip to conversation

x86/mm/mtrr: remove definition of DEBUG

PATCH Superseded [email protected] 2 participants 3 messages Jan 14, 2021 x86

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/mm/mtrr: remove definition of DEBUG

From: Tom Rix <[email protected]>

Defining DEBUG should only be done in development. So remove DEBUG.

---
 arch/x86/kernel/cpu/mtrr/generic.c | 1 -
 1 file changed, 1 deletion(-)
arch/x86/kernel/cpu/mtrr/generic.c +0 -1
index a29997e6cf9e..b90f3f437765 100644
@@ -3,7 +3,6 @@
  * This only handles 32bit MTRR on 32bit hosts. This is strictly wrong
  * because MTRRs can span up to 40 bits (36bits on most modern x86)
  */
-#define DEBUG
 
 #include <linux/export.h>
 #include <linux/init.h>
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 15 lines · On Thu, Jan 14, 2021 at 08:27:43AM -0800, [email protected] wrote:

From: Tom Rix <[email protected]>

Defining DEBUG should only be done in development. So remove DEBUG.

---
 arch/x86/kernel/cpu/mtrr/generic.c | 1 -
 1 file changed, 1 deletion(-)
arch/x86/kernel/cpu/mtrr/generic.c +0 -0
index a29997e6cf9e..b90f3f437765 100644

arch/x86/kernel/cpu/mtrr/generic.c line 8

Quoted 7 lines
arch/x86/kernel/cpu/mtrr/generic.c +0 -1
@@ -3,7 +3,6 @@
  * This only handles 32bit MTRR on 32bit hosts. This is strictly wrong
  * because MTRRs can span up to 40 bits (36bits on most modern x86)
  */
-#define DEBUG
 
 #include <linux/export.h>
 #include <linux/init.h>

Wanna merge all 4 in arch/x86/

arch/x86/kernel/cpu/mtrr/generic.c:6:#define DEBUG arch/x86/kernel/cpu/mtrr/mtrr.c:34:#define DEBUG arch/x86/kernel/pci-iommu_table.c:8:#define DEBUG 1 arch/x86/mm/mmio-mod.c:13:#define DEBUG 1

into a single patch?

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
author
#2 lore raw
Quoted 25 lines · Borislav Petkov
Quoted 15 lines · On Thu, Jan 14, 2021 at 08:27:43AM -0800, [email protected] wrote:

From: Tom Rix <[email protected]>

Defining DEBUG should only be done in development. So remove DEBUG.

---
 arch/x86/kernel/cpu/mtrr/generic.c | 1 -
 1 file changed, 1 deletion(-)
arch/x86/kernel/cpu/mtrr/generic.c +0 -0
index a29997e6cf9e..b90f3f437765 100644

arch/x86/kernel/cpu/mtrr/generic.c line 8

Quoted 7 lines
arch/x86/kernel/cpu/mtrr/generic.c +0 -1
@@ -3,7 +3,6 @@
  * This only handles 32bit MTRR on 32bit hosts. This is strictly wrong
  * because MTRRs can span up to 40 bits (36bits on most modern x86)
  */
-#define DEBUG
 
 #include <linux/export.h>
 #include <linux/init.h>

Wanna merge all 4 in arch/x86/

Quoted 6 lines

arch/x86/kernel/cpu/mtrr/generic.c:6:#define DEBUG arch/x86/kernel/cpu/mtrr/mtrr.c:34:#define DEBUG arch/x86/kernel/pci-iommu_table.c:8:#define DEBUG 1 arch/x86/mm/mmio-mod.c:13:#define DEBUG 1

into a single patch?

Yes, i'll take care of that.

Tom

Quoted 2 lines

Thx.