ACPI: introduce support for FPDT table
PATCH 1/1 ACPI: introduce support for FPDT table
ACPI Firmware Performance Data Table (FPDT) provides information about firmware performance during system boot, S3 suspend and S3 resume.
Have the kernel parse the FPDT table, and expose the firmware performance data to userspace as sysfs attributes under /sys/firmware/acpi/fpdt/.
--- Documentation/ABI/testing/sysfs-firmware-acpi | 43 +++ drivers/acpi/Kconfig | 8 + drivers/acpi/Makefile | 1 + drivers/acpi/acpi_fpdt.c | 263 ++++++++++++++++++ 4 files changed, 315 insertions(+) create mode 100644 drivers/acpi/acpi_fpdt.c
Documentation/ABI/testing/sysfs-firmware-acpi +43 -0
@@ -1,3 +1,46 @@ +What: /sys/firmware/acpi/fpdt/ +Date: Jan 2021 +Contact: Zhang Rui <[email protected]> +Description: + ACPI Firmware Performance Data Table (FPDT) provides + information for firmware performance data for system boot, + S3 suspend and S3 resume. This sysfs entry contains the + performance data retrieved from the FPDT. + + boot: + firmware_start_ns: Timer value logged at the beginning + of firmware image execution. In nanoseconds. + bootloader_load_ns: Timer value logged just prior to + loading the OS boot loader into memory. + In nanoseconds. + bootloader_launch_ns: Timer value logged just prior to + launching the currently loaded OS boot loader + image. In nanoseconds. + exitbootservice_start_ns: Timer value logged at the + point when the OS loader calls the + ExitBootServices function for UEFI compatible + firmware. In nanoseconds. + exitbootservice_end_ns: Timer value logged at the point + just prior to the OS loader gaining control + back from the ExitBootServices function for + UEFI compatible firmware. In nanoseconds. + suspend: + suspend_start_ns: Timer value recorded at the previous + OS write to SLP_TYP upon entry to S3. In + nanoseconds. + suspend_end_ns: Timer value recorded at the previous + firmware write to SLP_TYP used to trigger + hardware entry to S3. In nanoseconds. + resume: + resume_count: A count of the number of S3 resume cycles + since the last full boot sequence. + resume_avg_ns: Average timer value of all resume cycles + logged since the last full boot sequence, + including the most recent resume. In nanoseconds. + resume_prev_ns: Timer recorded at the end of the previous + platform runtime firmware S3 resume, just prior to + handoff to the OS waking vector. In nanoseconds. + What: /sys/firmware/acpi/bgrt/ Date: January 2012 Contact: Matthew Garrett <[email protected]>
drivers/acpi/Kconfig +8 -0
@@ -87,6 +87,14 @@ config ACPI_SPCR_TABLE This table provides information about the configuration of the earlycon console. +config ACPI_FPDT + bool "ACPI Firmware Performance Data Table(FPDT)" + depends on X86_64 + help + Enable support for the Firmware Performance Data Table (FPDT). + This table provides information on the timing of the system + boot, S3 suspend and S3 resume firmware code paths. + config ACPI_LPIT bool depends on X86_64
drivers/acpi/Makefile +1 -0
@@ -57,6 +57,7 @@ acpi-$(CONFIG_X86) += x86/utils.o acpi-$(CONFIG_X86) += x86/s2idle.o acpi-$(CONFIG_DEBUG_FS) += debugfs.o acpi-y += acpi_lpat.o +acpi-$(CONFIG_ACPI_FPDT) += acpi_fpdt.o acpi-$(CONFIG_ACPI_LPIT) += acpi_lpit.o acpi-$(CONFIG_ACPI_GENERIC_GSI) += irq.o acpi-$(CONFIG_ACPI_WATCHDOG) += acpi_watchdog.o
drivers/acpi/acpi_fpdt.c new file +263 -0
263 lines not on this page · raw message
Signature · 1 line
2.17.1
Sorry that I lost track of this patch for a long time.
Now it seems that this feature is needed, when /dev/mem is not available.
Thanks,
rui
Quoted 406 lines
-----Original Message-----
From: Zhang, Rui <[email protected]>
Sent: Friday, January 15, 2021 6:02 PM
To: [email protected]
Cc: [email protected]; Brandt, Todd E <[email protected]>; Zhang, Rui <[email protected]>
Subject: [PATCH] ACPI: introduce support for FPDT table
Importance: HighACPI Firmware Performance Data Table (FPDT) provides information about firmware performance during system boot, S3 suspend and S3 resume.
Have the kernel parse the FPDT table, and expose the firmware performance data to userspace as sysfs attributes under
/sys/firmware/acpi/fpdt/.Tested-by Todd Brandt <[email protected]>Signed-off-by Zhang Rui <[email protected]>--- Documentation/ABI/testing/sysfs-firmware-acpi | 43 +++ drivers/acpi/Kconfig | 8 + drivers/acpi/Makefile | 1 + drivers/acpi/acpi_fpdt.c | 263 ++++++++++++++++++ 4 files changed, 315 insertions(+) create mode 100644 drivers/acpi/acpi_fpdt.cDocumentation/ABI/testing/sysfs-firmware-acpi +11
-0@@ -1,3 +1,46 @@ +What: /sys/firmware/acpi/fpdt/ +Date: Jan 2021 +Contact: Zhang Rui <[email protected]> +Description: + ACPI Firmware Performance Data Table (FPDT) provides + information for firmware performance data for system boot, + S3 suspend and S3 resume. This sysfs entry contains the + performance data retrieved from the FPDT. + + boot: + firmware_start_ns: Timer value logged at thebeginning
Documentation/ABI/testing/sysfs-firmware-acpi +1
-0+ of firmware image execution. Innanoseconds.
Documentation/ABI/testing/sysfs-firmware-acpi +4
-0+ bootloader_load_ns: Timer value logged just prior to + loading the OS boot loader into memory. + In nanoseconds. + bootloader_launch_ns: Timer value logged just priorto
Documentation/ABI/testing/sysfs-firmware-acpi +1
-0+ launching the currently loaded OS bootloader
Documentation/ABI/testing/sysfs-firmware-acpi +6
-0+ image. In nanoseconds. + exitbootservice_start_ns: Timer value logged at the + point when the OS loader calls the + ExitBootServices function for UEFI compatible + firmware. In nanoseconds. + exitbootservice_end_ns: Timer value logged at thepoint
Documentation/ABI/testing/sysfs-firmware-acpi +5
-0+ just prior to the OS loader gaining control + back from the ExitBootServices function for + UEFI compatible firmware. In nanoseconds. + suspend: + suspend_start_ns: Timer value recorded at theprevious
Documentation/ABI/testing/sysfs-firmware-acpi +3
-0+ OS write to SLP_TYP upon entry to S3. In + nanoseconds. + suspend_end_ns: Timer value recorded at theprevious
Documentation/ABI/testing/sysfs-firmware-acpi +4
-0+ firmware write to SLP_TYP used to trigger + hardware entry to S3. In nanoseconds. + resume: + resume_count: A count of the number of S3 resumecycles
Documentation/ABI/testing/sysfs-firmware-acpi +2
-0+ since the last full boot sequence. + resume_avg_ns: Average timer value of all resumecycles
Documentation/ABI/testing/sysfs-firmware-acpi +2
-0+ logged since the last full boot sequence, + including the most recent resume. Innanoseconds.
Documentation/ABI/testing/sysfs-firmware-acpi +1
-0+ resume_prev_ns: Timer recorded at the end of theprevious
Documentation/ABI/testing/sysfs-firmware-acpi +1
-0+ platform runtime firmware S3 resume, justprior to
Documentation/ABI/testing/sysfs-firmware-acpi +1
-0+ handoff to the OS waking vector. Innanoseconds.
Documentation/ABI/testing/sysfs-firmware-acpi +1
-0+ What: /sys/firmware/acpi/bgrt/ Date: January 2012 Contact: Matthew Garrett <[email protected]>drivers/acpi/Kconfig index renamed from drivers/acpi/Kconfig +0
-0
ebcf534514be..84930fa2dc32100644drivers/acpi/Kconfig +8
-0@@ -87,6 +87,14 @@ config ACPI_SPCR_TABLE This table provides information about the configuration of the earlycon console. +config ACPI_FPDT + bool "ACPI Firmware Performance Data Table(FPDT)" + depends on X86_64 + help + Enable support for the Firmware Performance Data Table (FPDT). + This table provides information on the timing of the system + boot, S3 suspend and S3 resume firmware code paths. + config ACPI_LPIT bool depends on X86_64drivers/acpi/Makefile index renamed from drivers/acpi/Makefile +0
-0
076894a3330f..eb93bb7b6479100644drivers/acpi/Makefile +1
-0@@ -57,6 +57,7 @@ acpi-$(CONFIG_X86) += x86/utils.o acpi-$(CONFIG_X86) += x86/s2idle.o acpi-$(CONFIG_DEBUG_FS) += debugfs.o acpi-y += acpi_lpat.o +acpi-$(CONFIG_ACPI_FPDT) += acpi_fpdt.o acpi-$(CONFIG_ACPI_LPIT) += acpi_lpit.o acpi-$(CONFIG_ACPI_GENERIC_GSI) += irq.o acpi-$(CONFIG_ACPI_WATCHDOG) += acpi_watchdog.odrivers/acpi/acpi_fpdt.c new file mode renamed from drivers/acpi/acpi_fpdt.c +0
-0100644 index 000000000000..b8108117262a
drivers/acpi/acpi_fpdt.c new file +147
-0@@ -0,0 +1,263 @@ +// SPDX-License-Identifier: GPL-2.0-only + +/* +* FPDT support for exporting boot and suspend/resume performance data +* +* Copyright (C) 2021 Intel Corporation. All rights reserved. +*/ + +#define pr_fmt (fmt) "ACPI FPDT: " fmt + +#include <linux/acpi.h> + +/* +* FPDT contains ACPI table header and a number of fpdt_subtable_entries. +* Each fpdt_subtable_entry points to a subtable: FBPT or S3PT. +* Each FPDT subtable (FBPT/S3PT) is composed of a fpdt_subtable_header +* and a number of fpdt performance records. +* Each FPDT performance record is composed of a fpdt_record_header and +* performance data fields, for boot or suspend or resume phase. +*/ +enum fpdt_subtable_type { +SUBTABLE_FBPT , +SUBTABLE_S3PT , +}; + +struct fpdt_subtable_entry { +u16 type;/* refer to enum fpdt_subtable_type */ +u8 length; +u8 revision; +u32 reserved; +u64 address;/* physical address of the S3PT/FBPT table */ +}; + +struct fpdt_subtable_header { +u32 signature; +u32 length; +}; + +enum fpdt_record_type { +RECORD_S3_RESUME , +RECORD_S3_SUSPEND , +RECORD_BOOT , +}; + +struct fpdt_record_header { +u16 type;/* refer to enum fpdt_record_type */ +u8 length; +u8 revision; +}; + +struct resume_performance_record { +struct fpdt_record_header header; +u32 resume_count; +u64 resume_prev; +u64 resume_avg; +} __attribute__((packed)); + +struct boot_performance_record { +struct fpdt_record_header header; +u32 reserved; +u64 firmware_start; +u64 bootloader_load; +u64 bootloader_launch; +u64 exitbootservice_start; +u64 exitbootservice_end; +} __attribute__((packed)); + +struct suspend_performance_record { +struct fpdt_record_header header; +u64 suspend_start; +u64 suspend_end; +} __attribute__((packed)); + + +static struct resume_performance_record *record_resume;static struct +suspend_performance_record *record_suspend;static struct +boot_performance_record *record_boot; + +#define FPDT_ATTR (phase, name) \ +static ssize_t name##_show(struct kobject *kobj, \ + struct kobj_attribute *attr, char *buf) \ +{ \ + return sprintf(buf, "%llu\n", record_##phase->name); \ +} \ +static struct kobj_attribute name##_attr = \ +__ATTR(name##_ns, 0444, name##_show, NULL) + +FPDT_ATTR (resume, resume_prev); +FPDT_ATTR (resume, resume_avg); +FPDT_ATTR (suspend, suspend_start); +FPDT_ATTR (suspend, suspend_end); +FPDT_ATTR (boot, firmware_start); +FPDT_ATTR (boot, bootloader_load); +FPDT_ATTR (boot, bootloader_launch); +FPDT_ATTR (boot, exitbootservice_start);FPDT_ATTR (boot, +exitbootservice_end); + +static ssize_t resume_count_show (struct kobject *kobj, +struct kobj_attribute *attr,char *buf) { +return sprintf (buf,"%u\n" , record_resume->resume_count); } + +static struct kobj_attribute resume_count_attr = +__ATTR_RO (resume_count); + +static struct attribute *resume_attrs[] = { + &resume_count_attr.attr, + &resume_prev_attr.attr, + &resume_avg_attr.attr, +NULL +}; + +static const struct attribute_group resume_attr_group = { + .attrs = resume_attrs, + .name ="resume" , +}; + +static struct attribute *suspend_attrs[] = { + &suspend_start_attr.attr, + &suspend_end_attr.attr, +NULL +}; + +static const struct attribute_group suspend_attr_group = { + .attrs = suspend_attrs, + .name ="suspend" , +}; + +static struct attribute *boot_attrs[] = { + &firmware_start_attr.attr, + &bootloader_load_attr.attr, + &bootloader_launch_attr.attr, + &exitbootservice_start_attr.attr, + &exitbootservice_end_attr.attr, +NULL +}; + +static const struct attribute_group boot_attr_group = { + .attrs = boot_attrs, + .name ="boot" , +}; + +static struct kobject *fpdt_kobj; + +static int fpdt_process_subtable (u64 address,u32 subtable_type) { +struct fpdt_subtable_header *subtable_header; +struct fpdt_record_header *record_header; + char *signature = (subtable_type == SUBTABLE_FBPT ? "FBPT" :"S3PT");
drivers/acpi/acpi_fpdt.c new file +4
-0+u32 length, offset; +int result; + + subtable_header = acpi_os_map_memory(address,
sizeof(*subtable_header));drivers/acpi/acpi_fpdt.c new file +5
-0+if (!subtable_header) +return -ENOMEM ; + + if (strncmp((char *)&subtable_header->signature, signature, 4)) { + pr_info(FW_BUG "subtable signature and typemismatch!\n");
drivers/acpi/acpi_fpdt.c new file +5
-0+return -EINVAL ; + } + + length = subtable_header->length; + acpi_os_unmap_memory(subtable_header,
sizeof(*subtable_header));drivers/acpi/acpi_fpdt.c new file +14
-0+ + subtable_header = acpi_os_map_memory(address, length); + if (!subtable_header) + return -ENOMEM; + + offset = sizeof(*subtable_header); + while (offset < length) { + record_header = (void *)subtable_header + offset; + offset += record_header->length; + + switch (record_header->type) { + case RECORD_S3_RESUME: + if (subtable_type != SUBTABLE_S3PT) { + pr_err(FW_BUG "Invalid record %d forsubtable %s\n",
drivers/acpi/acpi_fpdt.c new file +5
-0+ record_header->type, signature); +return -EINVAL ; + } +if (record_resume) { + pr_err("Duplicate resume performancerecord found.\n");
drivers/acpi/acpi_fpdt.c new file +3
-0+continue ; + } + record_resume = (struct
resume_performance_record*)record_header;drivers/acpi/acpi_fpdt.c new file +1
-0+ result = sysfs_create_group(fpdt_kobj,
&resume_attr_group);drivers/acpi/acpi_fpdt.c new file +6
-0+if (result) +return result; +break ; +case RECORD_S3_SUSPEND : + if (subtable_type != SUBTABLE_S3PT) { + pr_err(FW_BUG "Invalid %d forsubtable %s\n",
drivers/acpi/acpi_fpdt.c new file +5
-0+ record_header->type, signature); +continue ; + } +if (record_suspend) { + pr_err("Duplicate suspend performancerecord found.\n");
drivers/acpi/acpi_fpdt.c new file +3
-0+continue ; + } + record_suspend = (struct
suspend_performance_record*)record_header;drivers/acpi/acpi_fpdt.c new file +1
-0+ result = sysfs_create_group(fpdt_kobj,
&suspend_attr_group);drivers/acpi/acpi_fpdt.c new file +6
-0+if (result) +return result; +break ; +case RECORD_BOOT : + if (subtable_type != SUBTABLE_FBPT) { + pr_err(FW_BUG "Invalid %d forsubtable %s\n",
drivers/acpi/acpi_fpdt.c new file +5
-0+ record_header->type, signature); +return -EINVAL ; + } +if (record_boot) { + pr_err("Duplicate boot performance recordfound.\n");
drivers/acpi/acpi_fpdt.c new file +3
-0+continue ; + } + record_boot = (struct boot_performance_record*)record_header;
drivers/acpi/acpi_fpdt.c new file +1
-0+ result = sysfs_create_group(fpdt_kobj,
&boot_attr_group);drivers/acpi/acpi_fpdt.c new file +6
-0+if (result) +return result; +break ; + +default : + pr_err(FW_BUG "Invalid record %d found.\n",
record_header->type);drivers/acpi/acpi_fpdt.c new file +32
-0+return -EINVAL ; + } + } +return 0 ; +} + +void acpi_init_fpdt (void ) +{ +acpi_status status; +struct acpi_table_header *header; +struct fpdt_subtable_entry *subtable; +u32 offset =sizeof (*header); + + status =acpi_get_table (ACPI_SIG_FPDT ,0 , &header); + +if (ACPI_FAILURE (status)) +return ; + + fpdt_kobj =kobject_create_and_add ("fpdt" , acpi_kobj); +if (!fpdt_kobj) +return ; + +while (offset < header->length) { + subtable = (void *)header + offset; +switch (subtable->type) { +case SUBTABLE_FBPT : +case SUBTABLE_S3PT : +fpdt_process_subtable (subtable->address, + subtable->type); +break ; +default : + pr_info(FW_BUG, "Invalid subtable type %dfound.\n",
drivers/acpi/acpi_fpdt.c new file +8
-1+ subtable->type); +return ; + } + offset +=sizeof (*subtable); + } +} + +fs_initcall (acpi_init_fpdt); --2.17.1
kernel test robot
build botI love your patch! Perhaps something to improve:
Hi Zhang,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pm/linux-next]
[also build test WARNING on linus/master v5.11-rc3 next-20210115] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zhang-Rui/ACPI-introduce-support-for-FPDT-table/20210115-175532 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/48fba58f7364b11bb5f0ea5b2e3843c7580c95dd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Zhang-Rui/ACPI-introduce-support-for-FPDT-table/20210115-175532 git checkout 48fba58f7364b11bb5f0ea5b2e3843c7580c95dd # save the attached .config to linux build tree make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
>> drivers/acpi/acpi_fpdt.c:230:6: warning: no previous prototype for 'acpi_init_fpdt' [-Wmissing-prototypes]
230 | void acpi_init_fpdt(void)
| ^~~~~~~~~~~~~~
In file included from include/linux/printk.h:7,
from include/linux/kernel.h:16,
from include/linux/list.h:9,
from include/linux/kobject.h:19,
from include/linux/of.h:17,
from include/linux/irqdomain.h:35,
from include/linux/acpi.h:13,
from drivers/acpi/acpi_fpdt.c:11:
drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt':
>> include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
14 | #define KERN_INFO KERN_SOH "6" /* informational */
| ^~~~~~~~
include/linux/printk.h:373:9: note: in expansion of macro 'KERN_INFO'
373 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~
drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro 'pr_info'
255 | pr_info(FW_BUG, "Invalid subtable type %d found.\n",
| ^~~~~~~vim +/acpi_init_fpdt +230 drivers/acpi/acpi_fpdt.c
229
> 230 void acpi_init_fpdt(void)
231 {
232 acpi_status status;
233 struct acpi_table_header *header;
234 struct fpdt_subtable_entry *subtable;
235 u32 offset = sizeof(*header);
236
237 status = acpi_get_table(ACPI_SIG_FPDT, 0, &header);
238
239 if (ACPI_FAILURE(status))
240 return;
241
242 fpdt_kobj = kobject_create_and_add("fpdt", acpi_kobj);
243 if (!fpdt_kobj)
244 return;
245
246 while (offset < header->length) {
247 subtable = (void *)header + offset;
248 switch (subtable->type) {
249 case SUBTABLE_FBPT:
250 case SUBTABLE_S3PT:
251 fpdt_process_subtable(subtable->address,
252 subtable->type);
253 break;
254 default:
255 pr_info(FW_BUG, "Invalid subtable type %d found.\n",
256 subtable->type);
257 return;
258 }
259 offset += sizeof(*subtable);
260 }
261 }
262
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Quoted 10 lines · Zhang Rui
ACPI Firmware Performance Data Table (FPDT) provides information about firmware performance during system boot, S3 suspend and S3 resume.
Have the kernel parse the FPDT table, and expose the firmware performance data to userspace as sysfs attributes under
/sys/firmware/acpi/fpdt/.Tested-by Todd Brandt <[email protected]>Signed-off-by Zhang Rui <[email protected]>
Applied as 5.12 material with a minor adjustment of the Kconfig entry, thanks!
Quoted 362 lines
--- Documentation/ABI/testing/sysfs-firmware-acpi | 43 +++ drivers/acpi/Kconfig | 8 + drivers/acpi/Makefile | 1 + drivers/acpi/acpi_fpdt.c | 263 ++++++++++++++++++ 4 files changed, 315 insertions(+) create mode 100644 drivers/acpi/acpi_fpdt.cDocumentation/ABI/testing/sysfs-firmware-acpi +43
-0@@ -1,3 +1,46 @@ +What: /sys/firmware/acpi/fpdt/ +Date: Jan 2021 +Contact: Zhang Rui <[email protected]> +Description: + ACPI Firmware Performance Data Table (FPDT) provides + information for firmware performance data for system boot, + S3 suspend and S3 resume. This sysfs entry contains the + performance data retrieved from the FPDT. + + boot: + firmware_start_ns: Timer value logged at the beginning + of firmware image execution. In nanoseconds. + bootloader_load_ns: Timer value logged just prior to + loading the OS boot loader into memory. + In nanoseconds. + bootloader_launch_ns: Timer value logged just prior to + launching the currently loaded OS boot loader + image. In nanoseconds. + exitbootservice_start_ns: Timer value logged at the + point when the OS loader calls the + ExitBootServices function for UEFI compatible + firmware. In nanoseconds. + exitbootservice_end_ns: Timer value logged at the point + just prior to the OS loader gaining control + back from the ExitBootServices function for + UEFI compatible firmware. In nanoseconds. + suspend: + suspend_start_ns: Timer value recorded at the previous + OS write to SLP_TYP upon entry to S3. In + nanoseconds. + suspend_end_ns: Timer value recorded at the previous + firmware write to SLP_TYP used to trigger + hardware entry to S3. In nanoseconds. + resume: + resume_count: A count of the number of S3 resume cycles + since the last full boot sequence. + resume_avg_ns: Average timer value of all resume cycles + logged since the last full boot sequence, + including the most recent resume. In nanoseconds. + resume_prev_ns: Timer recorded at the end of the previous + platform runtime firmware S3 resume, just prior to + handoff to the OS waking vector. In nanoseconds. + What: /sys/firmware/acpi/bgrt/ Date: January 2012 Contact: Matthew Garrett <[email protected]>drivers/acpi/Kconfig +8
-0@@ -87,6 +87,14 @@ config ACPI_SPCR_TABLE This table provides information about the configuration of the earlycon console. +config ACPI_FPDT + bool "ACPI Firmware Performance Data Table(FPDT)" + depends on X86_64 + help + Enable support for the Firmware Performance Data Table (FPDT). + This table provides information on the timing of the system + boot, S3 suspend and S3 resume firmware code paths. + config ACPI_LPIT bool depends on X86_64drivers/acpi/Makefile +1
-0@@ -57,6 +57,7 @@ acpi-$(CONFIG_X86) += x86/utils.o acpi-$(CONFIG_X86) += x86/s2idle.o acpi-$(CONFIG_DEBUG_FS) += debugfs.o acpi-y += acpi_lpat.o +acpi-$(CONFIG_ACPI_FPDT) += acpi_fpdt.o acpi-$(CONFIG_ACPI_LPIT) += acpi_lpit.o acpi-$(CONFIG_ACPI_GENERIC_GSI) += irq.o acpi-$(CONFIG_ACPI_WATCHDOG) += acpi_watchdog.odrivers/acpi/acpi_fpdt.c new file +263
-1@@ -0,0 +1,263 @@ +// SPDX-License-Identifier: GPL-2.0-only + +/* +* FPDT support for exporting boot and suspend/resume performance data +* +* Copyright (C) 2021 Intel Corporation. All rights reserved. +*/ + +#define pr_fmt (fmt) "ACPI FPDT: " fmt + +#include <linux/acpi.h> + +/* +* FPDT contains ACPI table header and a number of fpdt_subtable_entries. +* Each fpdt_subtable_entry points to a subtable: FBPT or S3PT. +* Each FPDT subtable (FBPT/S3PT) is composed of a fpdt_subtable_header +* and a number of fpdt performance records. +* Each FPDT performance record is composed of a fpdt_record_header and +* performance data fields, for boot or suspend or resume phase. +*/ +enum fpdt_subtable_type { +SUBTABLE_FBPT , +SUBTABLE_S3PT , +}; + +struct fpdt_subtable_entry { +u16 type;/* refer to enum fpdt_subtable_type */ +u8 length; +u8 revision; +u32 reserved; +u64 address;/* physical address of the S3PT/FBPT table */ +}; + +struct fpdt_subtable_header { +u32 signature; +u32 length; +}; + +enum fpdt_record_type { +RECORD_S3_RESUME , +RECORD_S3_SUSPEND , +RECORD_BOOT , +}; + +struct fpdt_record_header { +u16 type;/* refer to enum fpdt_record_type */ +u8 length; +u8 revision; +}; + +struct resume_performance_record { +struct fpdt_record_header header; +u32 resume_count; +u64 resume_prev; +u64 resume_avg; +} __attribute__((packed)); + +struct boot_performance_record { +struct fpdt_record_header header; +u32 reserved; +u64 firmware_start; +u64 bootloader_load; +u64 bootloader_launch; +u64 exitbootservice_start; +u64 exitbootservice_end; +} __attribute__((packed)); + +struct suspend_performance_record { +struct fpdt_record_header header; +u64 suspend_start; +u64 suspend_end; +} __attribute__((packed)); + + +static struct resume_performance_record *record_resume; +static struct suspend_performance_record *record_suspend; +static struct boot_performance_record *record_boot; + +#define FPDT_ATTR (phase, name) \ +static ssize_t name##_show(struct kobject *kobj, \ + struct kobj_attribute *attr, char *buf) \ +{ \ + return sprintf(buf, "%llu\n", record_##phase->name); \ +} \ +static struct kobj_attribute name##_attr = \ +__ATTR(name##_ns, 0444, name##_show, NULL) + +FPDT_ATTR (resume, resume_prev); +FPDT_ATTR (resume, resume_avg); +FPDT_ATTR (suspend, suspend_start); +FPDT_ATTR (suspend, suspend_end); +FPDT_ATTR (boot, firmware_start); +FPDT_ATTR (boot, bootloader_load); +FPDT_ATTR (boot, bootloader_launch); +FPDT_ATTR (boot, exitbootservice_start); +FPDT_ATTR (boot, exitbootservice_end); + +static ssize_t resume_count_show (struct kobject *kobj, +struct kobj_attribute *attr,char *buf) +{ +return sprintf (buf,"%u\n" , record_resume->resume_count); +} + +static struct kobj_attribute resume_count_attr = +__ATTR_RO (resume_count); + +static struct attribute *resume_attrs[] = { + &resume_count_attr.attr, + &resume_prev_attr.attr, + &resume_avg_attr.attr, +NULL +}; + +static const struct attribute_group resume_attr_group = { + .attrs = resume_attrs, + .name ="resume" , +}; + +static struct attribute *suspend_attrs[] = { + &suspend_start_attr.attr, + &suspend_end_attr.attr, +NULL +}; + +static const struct attribute_group suspend_attr_group = { + .attrs = suspend_attrs, + .name ="suspend" , +}; + +static struct attribute *boot_attrs[] = { + &firmware_start_attr.attr, + &bootloader_load_attr.attr, + &bootloader_launch_attr.attr, + &exitbootservice_start_attr.attr, + &exitbootservice_end_attr.attr, +NULL +}; + +static const struct attribute_group boot_attr_group = { + .attrs = boot_attrs, + .name ="boot" , +}; + +static struct kobject *fpdt_kobj; + +static int fpdt_process_subtable (u64 address,u32 subtable_type) +{ +struct fpdt_subtable_header *subtable_header; +struct fpdt_record_header *record_header; +char *signature = (subtable_type ==SUBTABLE_FBPT ?"FBPT" :"S3PT" ); +u32 length, offset; +int result; + + subtable_header =acpi_os_map_memory (address,sizeof (*subtable_header)); +if (!subtable_header) +return -ENOMEM ; + +if (strncmp ((char *)&subtable_header->signature, signature,4 )) { +pr_info (FW_BUG "subtable signature and type mismatch!\n" ); +return -EINVAL ; + } + + length = subtable_header->length; +acpi_os_unmap_memory (subtable_header,sizeof (*subtable_header)); + + subtable_header =acpi_os_map_memory (address, length); +if (!subtable_header) +return -ENOMEM ; + + offset =sizeof (*subtable_header); +while (offset < length) { + record_header = (void *)subtable_header + offset; + offset += record_header->length; + +switch (record_header->type) { +case RECORD_S3_RESUME : +if (subtable_type !=SUBTABLE_S3PT ) { +pr_err (FW_BUG "Invalid record %d for subtable %s\n" , + record_header->type, signature); +return -EINVAL ; + } +if (record_resume) { +pr_err ("Duplicate resume performance record found.\n" ); +continue ; + } + record_resume = (struct resume_performance_record *)record_header; + result =sysfs_create_group (fpdt_kobj, &resume_attr_group); +if (result) +return result; +break ; +case RECORD_S3_SUSPEND : +if (subtable_type !=SUBTABLE_S3PT ) { +pr_err (FW_BUG "Invalid %d for subtable %s\n" , + record_header->type, signature); +continue ; + } +if (record_suspend) { +pr_err ("Duplicate suspend performance record found.\n" ); +continue ; + } + record_suspend = (struct suspend_performance_record *)record_header; + result =sysfs_create_group (fpdt_kobj, &suspend_attr_group); +if (result) +return result; +break ; +case RECORD_BOOT : +if (subtable_type !=SUBTABLE_FBPT ) { +pr_err (FW_BUG "Invalid %d for subtable %s\n" , + record_header->type, signature); +return -EINVAL ; + } +if (record_boot) { +pr_err ("Duplicate boot performance record found.\n" ); +continue ; + } + record_boot = (struct boot_performance_record *)record_header; + result =sysfs_create_group (fpdt_kobj, &boot_attr_group); +if (result) +return result; +break ; + +default : +pr_err (FW_BUG "Invalid record %d found.\n" , record_header->type); +return -EINVAL ; + } + } +return 0 ; +} + +void acpi_init_fpdt (void ) +{ +acpi_status status; +struct acpi_table_header *header; +struct fpdt_subtable_entry *subtable; +u32 offset =sizeof (*header); + + status =acpi_get_table (ACPI_SIG_FPDT ,0 , &header); + +if (ACPI_FAILURE (status)) +return ; + + fpdt_kobj =kobject_create_and_add ("fpdt" , acpi_kobj); +if (!fpdt_kobj) +return ; + +while (offset < header->length) { + subtable = (void *)header + offset; +switch (subtable->type) { +case SUBTABLE_FBPT : +case SUBTABLE_S3PT : +fpdt_process_subtable (subtable->address, + subtable->type); +break ; +default : +pr_info (FW_BUG ,"Invalid subtable type %d found.\n" , + subtable->type); +return ; + } + offset +=sizeof (*subtable); + } +} + +fs_initcall (acpi_init_fpdt); --2.17.1