swapping01: fix parameter truncation in abs
PATCH 1/1 swapping01: fix parameter truncation in abs
Parameters passed to abs(int) are of type long. Use labs(long) instead to avoid value truncation.
Fixes the following warning:
swapping01.c: In function ?check_swapping?:
swapping01.c:133:7: warning: absolute value function ?abs? given an argument of type ?long int? but has parameter of type ?int? which may cause truncation of value [-Wabsolute-value]
133 | if (abs(swap_free_now - SAFE_READ_MEMINFO("SwapFree:")) < 512)
| ^~~
--- testcases/kernel/mem/swapping/swapping01.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/mem/swapping/swapping01.c +1 -1
@@ -130,7 +130,7 @@ static void check_swapping(void)while (i <10 ) { swap_free_now =SAFE_READ_MEMINFO ("SwapFree:" );sleep (1 ); -if (abs (swap_free_now -SAFE_READ_MEMINFO ("SwapFree:" )) <512 ) +if (labs (swap_free_now -SAFE_READ_MEMINFO ("SwapFree:" )) <512 )break ; i++;
Signature · 1 line
2.26.2
PATCH 1/1 swapping01: fix parameter truncation in abs
Hi Alexander,
Quoted 9 lines
Parameters passed to abs(int) are of type long. Use labs(long) instead to avoid value truncation.
Fixes the following warning:
swapping01.c: In function ?check_swapping?:
swapping01.c:133:7: warning: absolute value function ?abs? given an argument of type ?long int? but has parameter of type ?int? which may cause truncation of value [-Wabsolute-value]
133 | if (abs(swap_free_now - SAFE_READ_MEMINFO("SwapFree:"))< 512)| ^~~
Merged this obvious fix. Thanks!
Kind regards,
Petr