arm64: a37xx: pci: Fix printing debug messages
PATCH 1/1 arm64: a37xx: pci: Fix printing debug messages
Value pcie->dev in function pcie_advk_probe() is not initialized yet so use dev as argument for dev_dbg()/dev_warn().
Function pcie_advk_wait_pio() itself prints error message on failure so do not print duplicate error message in caller.
Signed-off-by Pali Roh?r <[email protected]>
--- drivers/pci/pci-aardvark.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/pci/pci-aardvark.c +2 -3
@@ -448,7 +448,6 @@ static int pcie_advk_write_config(struct udevice *bus, pci_dev_t bdf,advk_writel (pcie,1 ,PIO_START );if (!pcie_advk_wait_pio (pcie)) { -dev_dbg (pcie->dev,"- wait pio timeout\n" );return -EINVAL ; }
@@ -630,12 +629,12 @@ static int pcie_advk_probe(struct udevice *dev)* clock should be gated as well. */ if (dm_gpio_is_valid (&pcie->reset_gpio)) { -dev_dbg (pcie->dev,"Toggle PCIE Reset GPIO ...\n" ); +dev_dbg (dev,"Toggle PCIE Reset GPIO ...\n" );dm_gpio_set_value (&pcie->reset_gpio,1 );mdelay (200 );dm_gpio_set_value (&pcie->reset_gpio,0 ); }else { -dev_warn (pcie->dev,"PCIE Reset on GPIO support is missing\n" ); +dev_warn (dev,"PCIE Reset on GPIO support is missing\n" ); } pcie->first_busno =dev_seq (dev);
Signature · 1 line
2.20.1
PATCH 1/1 arm64: a37xx: pci: Fix printing debug messages
Quoted 7 lines · Pali Roh?r
Value
pcie->devin functionpcie_advk_probe()is not initialized yet so use dev as argument for dev_dbg()/dev_warn().Function
pcie_advk_wait_pio()itself prints error message on failure so do not print duplicate error message in caller.Signed-off-by Pali Roh?r <[email protected]>
Reviewed-by Stefan Roese <[email protected]>
Thanks,
Stefan
Quoted 22 lines
--- drivers/pci/pci-aardvark.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/pci/pci-aardvark.c +0
-2@@ -448,7 +448,6 @@ static int pcie_advk_write_config(struct udevice *bus, pci_dev_t bdf,advk_writel (pcie,1 ,PIO_START );if (!pcie_advk_wait_pio (pcie)) { -dev_dbg (pcie->dev,"- wait pio timeout\n" );return -EINVAL ; }@@ -630,12 +629,12 @@ static int pcie_advk_probe(struct udevice *dev)* clock should be gated as well. */ if (dm_gpio_is_valid (&pcie->reset_gpio)) { -dev_dbg (pcie->dev,"Toggle PCIE Reset GPIO ...\n" );
drivers/pci/pci-aardvark.c static int pcie_advk_probe(struct udevice *dev) · line 640
Quoted 10 lines
drivers/pci/pci-aardvark.c +2
-1+dev_dbg (dev,"Toggle PCIE Reset GPIO ...\n" );dm_gpio_set_value (&pcie->reset_gpio,1 );mdelay (200 );dm_gpio_set_value (&pcie->reset_gpio,0 ); }else { -dev_warn (pcie->dev,"PCIE Reset on GPIO support is missing\n" ); +dev_warn (dev,"PCIE Reset on GPIO support is missing\n" ); } pcie->first_busno =dev_seq (dev);
Viele Gr??e,
Stefan
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de