Skip to contentSkip to conversation

package/zstd: build multithreaded host-zstd

PATCH New Thomas De Schampheleire 2 participants 2 messages Jan 18, 2021 Zstd

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/zstd: build multithreaded host-zstd

From: Thomas De Schampheleire <[email protected]>

Under the assumption that all Buildroot build hosts nowadays are multithreaded, we can boost performance of host-zstd by enabling multithreaded operation.

See also commit 52154e52069d20105f62191e6c9f903f188a5129.

---
 package/zstd/zstd.mk | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
package/zstd/zstd.mk +8 -6
index c3af9bd58c..a4f0632fcf 100644
@@ -76,18 +76,20 @@ define ZSTD_INSTALL_TARGET_CMDS
 		DESTDIR=$(TARGET_DIR) PREFIX=/usr -C $(@D)/lib $(ZSTD_INSTALL_LIBS)
 endef
 
-# note: no 'HAVE_...' options for host library build only
+# note: only limited 'HAVE_...' options for host library build only
+HOST_ZSTD_OPTS = HAVE_THREAD=1
+
 define HOST_ZSTD_BUILD_CMDS
-	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \
-		-C $(@D)/lib libzstd.a libzstd
-	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \
+	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) $(HOST_ZSTD_OPTS) \
+		-C $(@D)/lib libzstd.a-mt libzstd-mt
+	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) $(HOST_ZSTD_OPTS) \
 		-C $(@D) zstd
 endef
 
 define HOST_ZSTD_INSTALL_CMDS
-	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \
+	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) $(HOST_ZSTD_OPTS) \
 		DESTDIR=$(HOST_DIR) PREFIX=/usr -C $(@D)/lib install
-	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \
+	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) $(HOST_ZSTD_OPTS) \
 		DESTDIR=$(HOST_DIR) PREFIX=/usr -C $(@D)/programs install
 endef
 
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 package/zstd: build multithreaded host-zstd

Quoted 6 lines · On Mon, 18 Jan 2021 21:37:52 +0100 Thomas De Schampheleire…

From: Thomas De Schampheleire <[email protected]>

Under the assumption that all Buildroot build hosts nowadays are multithreaded, we can boost performance of host-zstd by enabling multithreaded operation.

Quoted 6 lines

See also commit 52154e52069d20105f62191e6c9f903f188a5129.

---
 package/zstd/zstd.mk | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com