Skip to contentSkip to conversation

PCI: add Telit Vendor ID

PATCH In review Daniele Palmas 3 participants 4 messages Jan 19, 2021 – Jan 20, 2021 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: add Telit Vendor ID

Add Telit Vendor ID to pci_ids.h

---
Reference: https://pcisig.com/membership/member-companies?combine=telit

---
 include/linux/pci_ids.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/pci_ids.h +2 -0
index d8156a5dbee8..b10a04783287 100644
@@ -2590,6 +2590,8 @@
 
 #define PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS	0x1c36
 
+#define PCI_VENDOR_ID_TELIT		0x1c5d
+
 #define PCI_VENDOR_ID_CIRCUITCO		0x1cc8
 #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD	0x0001
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 1 line · Daniele Palmas

Add Telit Vendor ID to pci_ids.h

From the top of the file:

* Do not add new entries to this file unless the definitions
* are shared between multiple drivers.

If this is the case, include this patch in a series that adds multiple uses or mention the uses in this commit log.

Quoted 23 lines

---
Reference: https://pcisig.com/membership/member-companies?combine=telit

---
 include/linux/pci_ids.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/pci_ids.h +2 -0
index d8156a5dbee8..b10a04783287 100644
@@ -2590,6 +2590,8 @@
 
 #define PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS	0x1c36
 
+#define PCI_VENDOR_ID_TELIT		0x1c5d
+
 #define PCI_VENDOR_ID_CIRCUITCO		0x1cc8
 #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD	0x0001
 
Signature · 1 line
2.17.1
#2 lore raw
Quoted 10 lines · Bjorn Helgaas
Quoted 1 line · Daniele Palmas

Add Telit Vendor ID to pci_ids.h

From the top of the file:

* Do not add new entries to this file unless the definitions
* are shared between multiple drivers.

If this is the case, include this patch in a series that adds multiple uses or mention the uses in this commit log.

Also, when you do, follow the subject convention (run "git log --oneline include/linux/pci_ids.h" to see it).

Quoted 23 lines
Quoted 23 lines

---
Reference: https://pcisig.com/membership/member-companies?combine=telit

---
 include/linux/pci_ids.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/pci_ids.h +2 -0
index d8156a5dbee8..b10a04783287 100644
@@ -2590,6 +2590,8 @@
 
 #define PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS	0x1c36
 
+#define PCI_VENDOR_ID_TELIT		0x1c5d
+
 #define PCI_VENDOR_ID_CIRCUITCO		0x1cc8
 #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD	0x0001
 
Signature · 1 line
2.17.1
#3 lore raw
In reply to Bjorn Helgaas

Hi Daniele,

Quoted 11 lines · Bjorn Helgaas
Quoted 1 line · Daniele Palmas

Add Telit Vendor ID to pci_ids.h

From the top of the file:

* Do not add new entries to this file unless the definitions
* are shared between multiple drivers.

If this is the case, include this patch in a series that adds multiple uses or mention the uses in this commit log.

Ok, in that case, you can add this define directly in mhi_pci_generic along with a new entry for matching the sub-vendor/device IDs of your module.

Regards,
Loic

Quoted 24 lines
Quoted 24 lines

---
Reference: https://pcisig.com/membership/member-companies?combine=telit

---
 include/linux/pci_ids.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/pci_ids.h +2 -1
index d8156a5dbee8..b10a04783287 100644
@@ -2590,6 +2590,8 @@
 
 #define PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS  0x1c36
 
+#define PCI_VENDOR_ID_TELIT          0x1c5d
+
 #define PCI_VENDOR_ID_CIRCUITCO              0x1cc8
 #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD       0x0001
 
--

2.17.1