Skip to contentSkip to conversation

kbuild: stop removing stale <linux/version.h> file

PATCH In review Masahiro Yamada 1 participant 2 messages Jan 20, 2021 – Jan 27, 2021 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: stop removing stale <linux/version.h> file

Revert commit 223c24a7dba9 ("kbuild: Automatically remove stale <linux/version.h> file").

It was more than 6 years ago. I do not expect anybody to start git-bisect for such a big window.

---

 Makefile | 2 --
 1 file changed, 2 deletions(-)
Makefile +0 -2
index 23d0494e48bc..ebbf7158dfa0 100644
@@ -257,7 +257,6 @@ export building_out_of_srctree srctree objtree VPATH
 # of make so .config is not included in this case either (for *config).
 
 version_h := include/generated/uapi/linux/version.h
-old_version_h := include/linux/version.h
 
 clean-targets := %clean mrproper cleandocs
 no-dot-config-targets := $(clean-targets) \
@@ -1261,7 +1260,6 @@ endef
 
 $(version_h): FORCE
 	$(call filechk,version.h)
-	$(Q)rm -f $(old_version_h)
 
 include/generated/utsrelease.h: include/config/kernel.release FORCE
 	$(call filechk,utsrelease.h)
Signature · 1 line
2.27.0
#1 lore raw
Quoted 9 lines · Masahiro Yamada

Revert commit 223c24a7dba9 ("kbuild: Automatically remove stale <linux/version.h> file").

It was more than 6 years ago. I do not expect anybody to start git-bisect for such a big window.

---

Applied to linux-kbuild.

Quoted 26 lines
 Makefile | 2 --
 1 file changed, 2 deletions(-)
Makefile +0 -3
index 23d0494e48bc..ebbf7158dfa0 100644
@@ -257,7 +257,6 @@ export building_out_of_srctree srctree objtree VPATH
 # of make so .config is not included in this case either (for *config).
 
 version_h := include/generated/uapi/linux/version.h
-old_version_h := include/linux/version.h
 
 clean-targets := %clean mrproper cleandocs
 no-dot-config-targets := $(clean-targets) \
@@ -1261,7 +1260,6 @@ endef
 
 $(version_h): FORCE
        $(call filechk,version.h)
-       $(Q)rm -f $(old_version_h)
 
 include/generated/utsrelease.h: include/config/kernel.release FORCE
        $(call filechk,utsrelease.h)
--

2.27.0

Signature · 2 lines
Best Regards
Masahiro Yamada