tests/kms_rotation_crc: reduce execution time
PATCH v4 1/2 tests/kms_rotation_crc: reduce execution time
Restricting the execution to 2 pipes
with this change we see 50% improvement in time efficiency.
v2: Updated commit message.
--- tests/kms_rotation_crc.c | 4 ++++ 1 file changed, 4 insertions(+)
tests/kms_rotation_crc.c +4 -0
@@ -421,6 +421,10 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_formif (IS_CHERRYVIEW (data->devid) && pipe !=PIPE_B )continue ; +/* restricting the execution to 2 pipes to reduce execution time*/ +if (pipe >PIPE_B && !data->extended) +break ; +igt_output_set_pipe (output, pipe); plane =igt_output_get_plane_type (output, plane_type);
Signature · 6 lines
2.19.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH v4 2/2 HAX remove rotation tests from blacklist
--- tests/intel-ci/blacklist-pre-merge.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/intel-ci/blacklist-pre-merge.txt +1 -1
@@ -17,7 +17,7 @@ # # Data acquired on 2020-02-19 by Martin Peres ############################################################################### -igt@kms_rotation_crc@.* +#igt@kms_rotation_crc@.* ###############################################################################
Signature · 6 lines
2.19.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 16 lines · Jeevan B
Restricting the execution to 2 pipes
with this change we see 50% improvement in time efficiency.v2: Updated commit message.
Signed-off-by Jeevan B <[email protected]>Reviewed-by Uma Shankar <[email protected]>--- tests/kms_rotation_crc.c | 4 ++++ 1 file changed, 4 insertions(+)tests/kms_rotation_crc.c +0
-0
tests/kms_rotation_crc.c static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form · line 427
Quoted 7 lines
tests/kms_rotation_crc.c +4
-0@@ -421,6 +421,10 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_formif (IS_CHERRYVIEW (data->devid) && pipe !=PIPE_B )continue ; +/* restricting the execution to 2 pipes to reduce execution time*/ +if (pipe >PIPE_B && !data->extended) +break ; +
What's the plan for platforms that might have two pipes as A+C?
Signature · 5 lines
Petri Latvala _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v4,1/2] tests/kms_rotation_crc: reduce execution time
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,v4,1/2] tests/kms_rotation_crc: reduce execution time
URL : https://patchwork.freedesktop.org/series/86084/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9650 -> IGTPW_5408
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_5408 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_5408, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5408:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hangcheck:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-byt-j1900/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-byt-j1900/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in IGTPW_5408 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-tgl-y/igt@debugfs_test@read_all_entries.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-7500u: [PASS][5] -> [DMESG-WARN][6] ([i915#2605])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-kbl-7500u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-kbl-7500u/igt@[email protected]
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-snb-2600: NOTRUN -> [SKIP][7] ([fdo#109271]) +30 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-snb-2600/igt@[email protected]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-snb-2600: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-snb-2600/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-snb-2600: [DMESG-WARN][9] ([i915#2772]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-snb-2600/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-snb-2600/igt@[email protected]
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [DMESG-WARN][11] ([i915#402]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#2772]: https://gitlab.freedesktop.org/drm/intel/issues/2772
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (43 -> 37)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5960 -> IGTPW_5408
CI-20190529: 20190529
CI_DRM_9650: 3f989d1bb4cfd91e25549f9fd7a750412581dcc4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5408: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/index.html
IGT_5960: ace82fcd5f3623f8dde7c220a825873dc53dfae4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 29 lines
-----Original Message-----
From: Petri Latvala <[email protected]>
Sent: Wednesday, January 20, 2021 5:51 PM
To: B, Jeevan <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution timetests/kms_rotation_crc.c static void test_plane_rotation(data_t *data, int
Quoted 16 lines · Jeevan B
Restricting the execution to 2 pipes
with this change we see 50% improvement in time efficiency.v2: Updated commit message.
Signed-off-by Jeevan B <[email protected]>Reviewed-by Uma Shankar <[email protected]>--- tests/kms_rotation_crc.c | 4 ++++ 1 file changed, 4 insertions(+)tests/kms_rotation_crc.c index renamed from tests/kms_rotation_crc.c +0
-0
33a97cca..cc404a61100644tests/kms_rotation_crc.c +0
-0@@ -421,6 +421,10 @@ static void test_plane_rotation(data_t *data, int
plane_type, booltest_bad_formQuoted 3 lines
tests/kms_rotation_crc.c +0
-0if (IS_CHERRYVIEW (data->devid) && pipe !=PIPE_B )continue ;
Quoted 7 lines
tests/kms_rotation_crc.c static void test_plane_rotation(data_t *data, int · line 424
Quoted 1 line
tests/kms_rotation_crc.c +1
-0+/* restricting the execution to 2 pipes to reduce execution time*/
tests/kms_rotation_crc.c static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form · line 427
Quoted 3 lines
tests/kms_rotation_crc.c +3
-0+if (pipe >PIPE_B && !data->extended) +break ; +What's the plan for platforms that might have two pipes as A+C?
Hmm, Can we add a flag check here ??
So that I can exit when tests gets executed on 2 pipes.
Thanks
Jeevan B
Quoted 4 lines
--
Petri Latvala
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 31 lines · Jeevan
Quoted 31 lines
-----Original Message-----
From: Petri Latvala <[email protected]>
Sent: Wednesday, January 20, 2021 5:51 PM
To: B, Jeevan <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution timetests/kms_rotation_crc.c static void test_plane_rotation(data_t *data, int
Quoted 16 lines · Jeevan B
Restricting the execution to 2 pipes
with this change we see 50% improvement in time efficiency.v2: Updated commit message.
Signed-off-by Jeevan B <[email protected]>Reviewed-by Uma Shankar <[email protected]>--- tests/kms_rotation_crc.c | 4 ++++ 1 file changed, 4 insertions(+)tests/kms_rotation_crc.c index renamed from tests/kms_rotation_crc.c +0
-0
33a97cca..cc404a61100644tests/kms_rotation_crc.c +0
-0@@ -421,6 +421,10 @@ static void test_plane_rotation(data_t *data, int
plane_type, booltest_bad_formtests/kms_rotation_crc.c static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
Quoted 4 lines
tests/kms_rotation_crc.c +1
-0if (IS_CHERRYVIEW (data->devid) && pipe !=PIPE_B )continue ; +/* restricting the execution to 2 pipes to reduce execution time*/
Quoted 7 lines
Quoted 5 lines
tests/kms_rotation_crc.c static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form · line 427
Quoted 3 lines
tests/kms_rotation_crc.c +3
-0+if (pipe >PIPE_B && !data->extended) +break ; +What's the plan for platforms that might have two pipes as A+C?
Hmm, Can we add a flag check here ??
So that I can exit when tests gets executed on 2 pipes.
Yeah a separate counter is what you need to do here.
Signature · 5 lines
Petri Latvala _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev