Skip to contentSkip to conversation

ubifs: ubifs_purge_xattrs() wrongly called

DISCUSSION Sascha Hauer 2 participants 2 messages Jan 20, 2021 – Jan 21, 2021 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

Hi All,

I just noticed that ubifs_purge_xattrs() is wrongly called from ubifs_unlink() when a dentry is deleted. Deleting a dentry doesn't mean that the inode the xattrs are attached to is going away. Removing a file that has hardlinks will result in removing the xattrs when instead they should stay until the last link is removed.

ubifs_purge_xattrs() only removes the xattrs when their number exceeds ubifs_xattr_max_cnt(). Otherwise it does nothing, so it's unlikely to hit this bug in real life.

I am not sure how to fix that. Maybe calling ubifs_purge_xattrs() from ubifs_evict_inode() would be correct, but I haven't looked deeper into this.

Sascha

Signature · 8 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
#1 lore raw

Sascha,

Quoted 8 lines · Sascha Hauer

Hi All,

I just noticed that ubifs_purge_xattrs() is wrongly called from ubifs_unlink() when a dentry is deleted. Deleting a dentry doesn't mean that the inode the xattrs are attached to is going away. Removing a file that has hardlinks will result in removing the xattrs when instead they should stay until the last link is removed.

you are right, that's a bug we need to address.

Quoted 3 lines

ubifs_purge_xattrs() only removes the xattrs when their number exceeds ubifs_xattr_max_cnt(). Otherwise it does nothing, so it's unlikely to hit this bug in real life.

Yes. The idea is being able to remove inodes from old filesystems where we didn't
had the limitation.

Quoted 3 lines

I am not sure how to fix that. Maybe calling ubifs_purge_xattrs() from ubifs_evict_inode() would be correct, but I haven't looked deeper into this.

I can't remember right now why I didn't use the evict path. Hmmm.

Signature · 6 lines
Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/