gpiolib: cdev: clear debounce period if line set to output
Kent Gibson
reviewerPATCH 1/1 gpiolib: cdev: clear debounce period if line set to output
When set_config changes a line from input to output debounce is implicitly disabled, as debounce makes no sense for outputs, but the debounce period is not being cleared and is still reported in the line info.
So clear the debounce period when the debouncer is stopped in edge_detector_stop().
Fixed: 65cff7047640 ("gpiolib: cdev: support setting debounce")
--- drivers/gpio/gpiolib-cdev.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpio/gpiolib-cdev.c +2 -0
@@ -776,6 +776,8 @@ static void edge_detector_stop(struct line *line)cancel_delayed_work_sync (&line->work);WRITE_ONCE (line->sw_debounced,0 );WRITE_ONCE (line->eflags,0 ); +if (line->desc) +WRITE_ONCE (line->desc->debounce_period_us,0 );/* do not change line->level - see comment in debounced_value() */ }
Signature · 1 line
2.30.0
Quoted 10 lines · Kent Gibson
When
set_configchanges a line from input to output debounce is implicitly disabled, as debounce makes no sense for outputs, but the debounce period is not being cleared and is still reported in the line info.So clear the debounce period when the debouncer is stopped in
edge_detector_stop().Fixed:
65cff7047640("gpiolib: cdev: support setting debounce")Signed-off-by Kent Gibson <[email protected]>
Yours,
Linus Walleij
Quoted 10 lines · Kent Gibson
When
set_configchanges a line from input to output debounce is implicitly disabled, as debounce makes no sense for outputs, but the debounce period is not being cleared and is still reported in the line info.So clear the debounce period when the debouncer is stopped in
edge_detector_stop().Fixed:
65cff7047640("gpiolib: cdev: support setting debounce")
The actual hash for this commit is 65cff7046406 - I fixed that locally.
Patch applied for fixes, thanks!
Bartosz
Quoted 21 lines
Signed-off-by Kent Gibson <[email protected]>--- drivers/gpio/gpiolib-cdev.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpio/gpiolib-cdev.c +2
-1@@ -776,6 +776,8 @@ static void edge_detector_stop(struct line *line)cancel_delayed_work_sync (&line->work);WRITE_ONCE (line->sw_debounced,0 );WRITE_ONCE (line->eflags,0 ); +if (line->desc) +WRITE_ONCE (line->desc->debounce_period_us,0 );/* do not change line->level - see comment in debounced_value() */ } --2.30.0