Skip to contentSkip to conversation

ibmvnic: workaround QT Creator/libCPlusPlus segfault

PATCH Superseded Alexey Dobriyan 3 participants 5 messages Jan 21, 2021 – Jan 22, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ibmvnic: workaround QT Creator/libCPlusPlus segfault

My name is Alexey and I've tried to use IDE for kernel development.

QT Creator segfaults while parsing ibmvnic.c which is annoying as it will start parsing after restart only to crash again.

The workaround is to either exclude ibmvnic.c from list of project files or to apply dummy ifdef to hide the offending code.

https://bugzilla.redhat.com/show_bug.cgi?id=1886548

---

 drivers/net/ethernet/ibm/ibmvnic.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/net/ethernet/ibm/ibmvnic.c +3 -0
@@ -5080,6 +5080,8 @@ static void ibmvnic_tasklet(struct tasklet_struct *t)
 	unsigned long flags;
 	bool done = false;
 
+	/* workaround QT Creator/libCPlusPlus.so segfault with dummy ifdef */
+#ifdef CONFIG_IBMVNIC
 	spin_lock_irqsave(&queue->lock, flags);
 	while (!done) {
 		/* Pull all the valid messages off the CRQ */
@@ -5100,6 +5102,7 @@ static void ibmvnic_tasklet(struct tasklet_struct *t)
 	if (atomic_read(&adapter->running_cap_crqs) != 0)
 		adapter->wait_capability = true;
 	spin_unlock_irqrestore(&queue->lock, flags);
+#endif
 }
 
 static int ibmvnic_reenable_crq_queue(struct ibmvnic_adapter *adapter)
#1 lore raw

PATCH v2 1/1 ibmvnic: workaround QT Creator/libCPlusPlus segfault

My name is Alexey and I've tried to use IDE for kernel development.

QT Creator segfaults while parsing ibmvnic.c which is annoying as it will start parsing after restart only to crash again.

The workaround is to either exclude ibmvnic.c from list of project files or to apply dummy ifdef to hide the offending code.

https://bugzilla.redhat.com/show_bug.cgi?id=1886548

---

fix modular case

 drivers/net/ethernet/ibm/ibmvnic.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/net/ethernet/ibm/ibmvnic.c +3 -0
@@ -5080,6 +5080,8 @@ static void ibmvnic_tasklet(struct tasklet_struct *t)
 	unsigned long flags;
 	bool done = false;
 
+	/* workaround QT Creator/libCPlusPlus.so segfault with dummy if */
+#if IS_ENABLED(CONFIG_IBMVNIC)
 	spin_lock_irqsave(&queue->lock, flags);
 	while (!done) {
 		/* Pull all the valid messages off the CRQ */
@@ -5100,6 +5102,7 @@ static void ibmvnic_tasklet(struct tasklet_struct *t)
 	if (atomic_read(&adapter->running_cap_crqs) != 0)
 		adapter->wait_capability = true;
 	spin_unlock_irqrestore(&queue->lock, flags);
+#endif
 }
 
 static int ibmvnic_reenable_crq_queue(struct ibmvnic_adapter *adapter)
#4 lore raw
In reply to Alexey Dobriyan
Quoted 9 lines · Alexey Dobriyan

My name is Alexey and I've tried to use IDE for kernel development.

QT Creator segfaults while parsing ibmvnic.c which is annoying as it will start parsing after restart only to crash again.

The workaround is to either exclude ibmvnic.c from list of project files or to apply dummy ifdef to hide the offending code.

https://bugzilla.redhat.com/show_bug.cgi?id=1886548

Sorry, but this is not going to be accepted.

Can you narrow it down further. In bugzilla, you say the includes are wrong. How exactly?

Andrew

maintainer
#2 lore raw
In reply to Alexey Dobriyan
Quoted 11 lines · On Fri, 22 Jan 2021 01:07:39 +0300 Alexey Dobriyan wrote:

My name is Alexey and I've tried to use IDE for kernel development.

QT Creator segfaults while parsing ibmvnic.c which is annoying as it will start parsing after restart only to crash again.

The workaround is to either exclude ibmvnic.c from list of project files or to apply dummy ifdef to hide the offending code.

https://bugzilla.redhat.com/show_bug.cgi?id=1886548

That's a bug in QT Creator and whatever parsing it does/uses.

Sorry we can't take this patch, there is no indication that the kernel code is actually wrong here.

#3 lore raw
Quoted 9 lines · Jakub Kicinski
Quoted 8 lines · On Fri, 22 Jan 2021 01:07:39 +0300 Alexey Dobriyan wrote:

My name is Alexey and I've tried to use IDE for kernel development.

QT Creator segfaults while parsing ibmvnic.c which is annoying as it will start parsing after restart only to crash again.

The workaround is to either exclude ibmvnic.c from list of project files or to apply dummy ifdef to hide the offending code.

Quoted 8 lines
Quoted 3 lines

https://bugzilla.redhat.com/show_bug.cgi?id=1886548

That's a bug in QT Creator and whatever parsing it does/uses.

Sorry we can't take this patch, there is no indication that the kernel code is actually wrong here.

It is QtC bug. It will take ages for distros to pick up the fix (which doesn't even exist probably).