Skip to contentSkip to conversation

perf tools fixes for v5.11, 2nd batch

GIT PULL Merged Arnaldo Carvalho de Melo 3 participants 4 messages Jan 22, 2021 – Jan 25, 2021

lore
Share & tools
lore
#0 lore raw

Hi Linus,

Please consider pulling,

Best regards,

- Arnaldo

The following changes since commit 9f29bd8b2e7132b409178d1367dae1813017bd0e:

Merge tag 'fs_for_v5.11-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs (2021-01-21 11:45:40 -0800)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-tools-fixes-v5.11-2-2021-01-22

for you to fetch changes up to 8adc0a06d68a2e433b960377e515e7a6b19b429f:

perf script: Fix overrun issue for dynamically-allocated PMU type number (2021-01-21 17:25:33 -0300)

----------------------------------------------------------------
perf tools fixes for 5.11, 2nd batch:

- Fix id index used in Intel PT for heterogeneous systems.

- Fix overrun issue in 'perf script' for dynamically-allocated PMU type number.

- Fix 'perf stat' metrics containing the 'duration_time' synthetic event.

- Fix system PMU 'perf stat' metrics.

Test results in the signed tag at:

https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tag/?h=perf-tools-fixes-v5.11-2-2021-01-22

Adrian Hunter (1):
perf evlist: Fix id index for heterogeneous systems

Jin Yao (1):
perf script: Fix overrun issue for dynamically-allocated PMU type number

John Garry (2):
perf metricgroup: Fix for metrics containing duration_time perf metricgroup: Fix system PMU metrics

 tools/lib/perf/evlist.c       | 17 ++++-------------
 tools/perf/builtin-script.c   | 18 +++++++++++++++++-
 tools/perf/util/metricgroup.c | 16 +++++++++++-----
 3 files changed, 32 insertions(+), 19 deletions(-)
#1 lore raw
Quoted 2 lines · Arnaldo Carvalho de Melo

Test results in the signed tag at:

Side note: I'd actually prefer if you didn't do this. These big things end up being (a hidden) part of the merge commit (and that's how the tag verification works after-the-fact: ie I don't just verify the tag when I pull, you can also do the verification later), and it really makes zero sense to add 28kB of data to each merge just because you hid them in the signed tag.

It would actually be better to have it just in the email at the end, not in the tag.

Please?

Linus

#2 lore raw

Em Fri, Jan 22, 2021 at 01:59:02PM -0800, Linus Torvalds escreveu:

Quoted 11 lines · Arnaldo Carvalho de Melo
Quoted 2 lines

Test results in the signed tag at:

Side note: I'd actually prefer if you didn't do this. These big things end up being (a hidden) part of the merge commit (and that's how the tag verification works after-the-fact: ie I don't just verify the tag when I pull, you can also do the verification later), and it really makes zero sense to add 28kB of data to each merge just because you hid them in the signed tag.

Quoted 4 lines

It would actually be better to have it just in the email at the end, not in the tag.

Please?

Sure, intention was to record that tests were done and where it was done, and at the same time not to bother you with test results in the pull request.

But as you point out and was discussed somewhere else, it doesn't ends up accessible upstream, so I'll do as you suggest and just leave it in the cover letter, as I did in the past when submitting to Ingo.

Thanks,

- Arnaldo

merge bot Merged
#3 lore raw
In reply to Arnaldo Carvalho de Melo
The pull request you sent on Fri, 22 Jan 2021 10:51:56 -0300:

The pull request you sent on Fri, 22 Jan 2021 10:51:56 -0300:

Quoted 1 line

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-tools-fixes-v5.11-2-2021-01-22

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/faba877b3bccb5af79f0cd8c6af93392030e6e41

Thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html