Skip to contentSkip to conversation

regulator: Make regulator_sync_voltage() usable by coupled regulators

PATCH In review Dmitry Osipenko 2 participants 2 messages Jan 22, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 regulator: Make regulator_sync_voltage() usable by coupled regulators

Make regulator_sync_voltage() to re-balance voltage state of a coupled regulators instead of changing the voltage directly.

---

Changelog:

v4: - Now not using goto in the code, like it was suggested by Mark Brown
in a review comment to v3.

v3: - This patch is factored out from [1] to ease merging of the patches
that will use the regulator_sync_voltage(). The goal is to get this change merged into 5.12, it will remove dependency for the Tegra Core power domain driver which will target 5.13.

[1] https://patchwork.ozlabs.org/project/linux-tegra/list/?series=221130

 drivers/regulator/core.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/regulator/core.c +5 -1
index 3ae5ccd9277d..8e197b785a31 100644
@@ -4148,7 +4148,11 @@ int regulator_sync_voltage(struct regulator *regulator)
 	if (ret < 0)
 		goto out;
 
-	ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
+	/* balance only, if regulator is coupled */
+	if (rdev->coupling_desc.n_coupled > 1)
+		ret = regulator_balance_voltage(rdev, PM_SUSPEND_ON);
+	else
+		ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
 
 out:
 	regulator_unlock(rdev);
Signature · 1 line
2.29.2
maintainer
#1 lore raw
Quoted 2 lines · Dmitry Osipenko

Make regulator_sync_voltage() to re-balance voltage state of a coupled regulators instead of changing the voltage directly.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: Make regulator_sync_voltage() usable by coupled regulators

      commit: 24be0c715617ed9bfc63fa9483f8bda1214b9763

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark