Skip to contentSkip to conversation

PHY: Ingenic: compile phy-ingenic-usb only if it was enabled

PATCH Superseded Qiujun Huang 2 participants 2 messages Jan 23, 2021 – Jan 24, 2021 Generic PHY framework

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PHY: Ingenic: compile phy-ingenic-usb only if it was enabled

We should compile this driver only if we opened PHY_INGENIC_USB.

---
 drivers/phy/ingenic/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/ingenic/Makefile +1 -1
index 65d5ea00fc9d..a00306651423 100644
@@ -1,2 +1,2 @@
 # SPDX-License-Identifier: GPL-2.0
-obj-y		+= phy-ingenic-usb.o
+obj-$(PHY_INGENIC_USB)		+= phy-ingenic-usb.o
Signature · 1 line
2.25.1
#1 lore raw

Hi, thank you for your patch.

Quoted 1 line · Qiujun Huang

We should compile this driver only if we opened PHY_INGENIC_USB.

'opened' -> 'enable'.

Quoted 1 line

You will need to add a Fixes: tag and Cc linux-stable, since the problem is already in 5.10.

Cheers,
-Paul

Quoted 15 lines
---
 drivers/phy/ingenic/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/ingenic/Makefile +1 -2
index 65d5ea00fc9d..a00306651423 100644
@@ -1,2 +1,2 @@
 # SPDX-License-Identifier: GPL-2.0
-obj-y		+= phy-ingenic-usb.o
+obj-$(PHY_INGENIC_USB)		+= phy-ingenic-usb.o
--

2.25.1