sgi-xp: remove h from printk format specifier
PATCH 1/1 sgi-xp: remove h from printk format specifier
From: Tom Rix <[email protected]>
This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
unnecessary %h[xudi] and %hh[xudi]")
Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi].
Signed-off-by Tom Rix <[email protected]>
--- drivers/misc/sgi-xp/xpnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/sgi-xp/xpnet.c +2 -2
@@ -208,7 +208,7 @@ xpnet_receive(short partid, int channel, struct xpnet_message *msg) }else { dst = (void *)((u64 )skb->data & ~(L1_CACHE_BYTES -1 ));dev_dbg (xpnet,"transferring buffer to the skb->data area;\n\t" -"xp_remote_memcpy(0x%p, 0x%p, %hu)\n" , dst, +"xp_remote_memcpy(0x%p, 0x%p, %u)\n" , dst, (void *)msg->buf_pa, msg->size); ret =xp_remote_memcpy (xp_pa (dst), msg->buf_pa, msg->size);
@@ -218,7 +218,7 @@ xpnet_receive(short partid, int channel, struct xpnet_message *msg)* !!! appears in_use and we can't just call * !!! dev_kfree_skb. */ -dev_err (xpnet,"xp_remote_memcpy(0x%p, 0x%p, 0x%hx) " +dev_err (xpnet,"xp_remote_memcpy(0x%p, 0x%p, 0x%x) " "returned error=0x%x\n" , dst, (void *)msg->buf_pa, msg->size, ret);
Signature · 1 line
2.27.0
Reviewed-by Steve Wahl <[email protected]>
Quoted 39 lines · On Sat, Jan 23, 2021 at 08:00:03AM -0800, [email protected] wrote:
From: Tom Rix <[email protected]>
This change fixes the checkpatch warning described in this commit commit
cbacb5ab0aa0("docs: printk-formats: Stop encouraging use of
unnecessary %h[xudi] and %hh[xudi]")Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi].
Signed-off-by Tom Rix <[email protected]>--- drivers/misc/sgi-xp/xpnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/misc/sgi-xp/xpnet.c +2
-2@@ -208,7 +208,7 @@ xpnet_receive(short partid, int channel, struct xpnet_message *msg) }else { dst = (void *)((u64 )skb->data & ~(L1_CACHE_BYTES -1 ));dev_dbg (xpnet,"transferring buffer to the skb->data area;\n\t" -"xp_remote_memcpy(0x%p, 0x%p, %hu)\n" , dst, +"xp_remote_memcpy(0x%p, 0x%p, %u)\n" , dst, (void *)msg->buf_pa, msg->size); ret =xp_remote_memcpy (xp_pa (dst), msg->buf_pa, msg->size);@@ -218,7 +218,7 @@ xpnet_receive(short partid, int channel, struct xpnet_message *msg)* !!! appears in_use and we can't just call * !!! dev_kfree_skb. */ -dev_err (xpnet,"xp_remote_memcpy(0x%p, 0x%p, 0x%hx) " +dev_err (xpnet,"xp_remote_memcpy(0x%p, 0x%p, 0x%x) " "returned error=0x%x\n" , dst, (void *)msg->buf_pa, msg->size, ret);Signature · 1 line
2.27.0
Signature · 1 line
Steve Wahl, Hewlett Packard Enterprise