iproute get: force rtm_dst_len to 32/128
Subsystems (2)
PATCH 1/1 iproute get: force rtm_dst_len to 32/128
Since NETLINK_GET_STRICT_CHK was enabled, the kernel rejects commands that pass a prefix length, eg:
ip route get `1.0.0.0/1
Error: ipv4: Invalid values in header for route get request.
ip route get 0.0.0.0/0
Error: ipv4: rtm_src_len and rtm_dst_len must be 32 for IPv4
Since there's no point in setting a rtm_dst_len that we know is going to be rejected, just force it to the right value if it's passed on the command line.
Bug-Debian: https://bugs.debian.org/944730
---
As mentioned by David on:
https://www.spinics.net/lists/netdev/msg624125.html
ip/iproute.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
ip/iproute.c +6 -1
@@ -2069,7 +2069,12 @@ static int iproute_get(int argc, char **argv)if (addr.bytelen)addattr_l (&req.n,sizeof (req),RTA_DST , &addr.data, addr.bytelen); - req.r.rtm_dst_len = addr.bitlen; +if (req.r.rtm_family ==AF_INET ) + req.r.rtm_dst_len =32 ; +else if (req.r.rtm_family ==AF_INET6 ) + req.r.rtm_dst_len =128 ; +else + req.r.rtm_dst_len = addr.bitlen; address_found = true; } argc--; argv++;
Signature · 1 line
2.29.2
Quoted 7 lines · Luca Boccassi
Since
NETLINK_GET_STRICT_CHKwas enabled, the kernel rejects commands that pass a prefix length, eg:ip route get `1.0.0.0/1
Error: ipv4: Invalid values in header for route get request.
ip route get 0.0.0.0/0
Error: ipv4:rtm_src_lenandrtm_dst_lenmust be 32 for IPv4
Those are not the best responses from the kernel for the mask setting. I should have been clearer about src and dst masks.
Quoted 25 lines
Since there's no point in setting a
rtm_dst_lenthat we know is going to be rejected, just force it to the right value if it's passed on the command line.Bug-Debian: https://bugs.debian.org/944730
Reported-By Clément 'wxcafé' Hertling <[email protected]>Signed-off-by Luca Boccassi <[email protected]>---
As mentioned by David on:https://www.spinics.net/lists/netdev/msg624125.html
ip/iproute.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)ip/iproute.c +0
-0@@ -2069,7 +2069,12 @@ static int iproute_get(int argc, char **argv)if (addr.bytelen)addattr_l (&req.n,sizeof (req),RTA_DST , &addr.data, addr.bytelen);
ip/iproute.c static int iproute_get(int argc, char **argv) · line 2080
Quoted 10 lines
ip/iproute.c +6
-1- req.r.rtm_dst_len = addr.bitlen; +if (req.r.rtm_family ==AF_INET ) + req.r.rtm_dst_len =32 ; +else if (req.r.rtm_family ==AF_INET6 ) + req.r.rtm_dst_len =128 ; +else + req.r.rtm_dst_len = addr.bitlen; address_found = true; } argc--; argv++;
Since the kernel used to blindly ignore the mask, having iproute2 fix it up seems acceptable.
I think it would be good to educate the user about invalid settings as well - get them to fix scripts and mind set.
PATCH v2 1/1 iproute: force rtm_dst_len to 32/128
In reply to Luca BoccassiSince NETLINK_GET_STRICT_CHK was enabled, the kernel rejects commands that pass a prefix length, eg:
ip route get `1.0.0.0/1
Error: ipv4: Invalid values in header for route get request.
ip route get 0.0.0.0/0
Error: ipv4: rtm_src_len and rtm_dst_len must be 32 for IPv4
Since there's no point in setting a rtm_dst_len that we know is going to be rejected, just force it to the right value if it's passed on the command line. Print a warning to stderr to notify users.
Bug-Debian: https://bugs.debian.org/944730
---
v2: added a warning
ip/iproute.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
ip/iproute.c +12 -1
@@ -2069,7 +2069,18 @@ static int iproute_get(int argc, char **argv)if (addr.bytelen)addattr_l (&req.n,sizeof (req),RTA_DST , &addr.data, addr.bytelen); - req.r.rtm_dst_len = addr.bitlen; +if (req.r.rtm_family ==AF_INET && addr.bitlen !=32 ) { +fprintf (stderr, +"Warning: /%u as prefix is invalid, only /32 (or none) is supported.\n" , + addr.bitlen); + req.r.rtm_dst_len =32 ; + }else if (req.r.rtm_family ==AF_INET6 && addr.bitlen !=128 ) { +fprintf (stderr, +"Warning: /%u as prefix is invalid, only /128 (or none) is supported.\n" , + addr.bitlen); + req.r.rtm_dst_len =128 ; + }else + req.r.rtm_dst_len = addr.bitlen; address_found = true; } argc--; argv++;
Signature · 1 line
2.29.2
Quoted 52 lines · David Ahern
Quoted 7 lines · Luca Boccassi
Since
NETLINK_GET_STRICT_CHKwas enabled, the kernel rejects commands that pass a prefix length, eg:ip route get `1.0.0.0/1
Error: ipv4: Invalid values in header for route get request.
ip route get 0.0.0.0/0
Error: ipv4:rtm_src_lenandrtm_dst_lenmust be 32 for IPv4Those are not the best responses from the kernel for the mask setting. I should have been clearer about src and dst masks.
Quoted 25 lines
Since there's no point in setting a
rtm_dst_lenthat we know is going to be rejected, just force it to the right value if it's passed on the command line.Bug-Debian: https://bugs.debian.org/944730
Reported-By Clément 'wxcafé' Hertling <[email protected]>Signed-off-by Luca Boccassi <[email protected]>---
As mentioned by David on:https://www.spinics.net/lists/netdev/msg624125.html
ip/iproute.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)ip/iproute.c +0
-0@@ -2069,7 +2069,12 @@ static int iproute_get(int argc, char **argv)if (addr.bytelen)addattr_l (&req.n,sizeof (req),RTA_DST , &addr.data, addr.bytelen);ip/iproute.c static int iproute_get(int argc, char **argv) · line 2080
Quoted 10 lines
ip/iproute.c +6
-1- req.r.rtm_dst_len = addr.bitlen; +if (req.r.rtm_family ==AF_INET ) + req.r.rtm_dst_len =32 ; +else if (req.r.rtm_family ==AF_INET6 ) + req.r.rtm_dst_len =128 ; +else + req.r.rtm_dst_len = addr.bitlen; address_found = true; } argc--; argv++;Since the kernel used to blindly ignore the mask, having iproute2 fix it up seems acceptable.
Quoted 2 lines
I think it would be good to educate the user about invalid settings as well - get them to fix scripts and mind set.
Sent v2 with a warning print to stderr.
Kind regards,
Luca Boccassi