Skip to contentSkip to conversation

drm/i915/gt: use new tasklet API in execlist selftest

PATCH New Emil Renner Berthing 2 participants 2 messages Jan 26, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/gt: use new tasklet API in execlist selftest

This converts the execlist selftest to use the new tasklet API in commit 12cc923f1ccc ("tasklet: Introduce new initialization API")

---
Hi Chris,

I seem to have missed some tasklist manipulation in the execlist selftest. Feel free to squash this into my previous patch ("drm/i915/gt: use new tasklet API for execution list") or leave it like this. Whatever is fine by me.

/Emil

---
 drivers/gpu/drm/i915/gt/selftest_execlists.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/selftest_execlists.c +2 -2
index 264b5ebdb021..ba55cd018f5b 100644
@@ -609,7 +609,7 @@ static int live_hold_reset(void *arg)
 		}
 		tasklet_disable(&engine->execlists.tasklet);
 
-		engine->execlists.tasklet.func(engine->execlists.tasklet.data);
+		engine->execlists.tasklet.callback(&engine->execlists.tasklet);
 		GEM_BUG_ON(execlists_active(&engine->execlists) != rq);
 
 		i915_request_get(rq);
@@ -4610,7 +4610,7 @@ static int reset_virtual_engine(struct intel_gt *gt,
 	}
 	tasklet_disable(&engine->execlists.tasklet);
 
-	engine->execlists.tasklet.func(engine->execlists.tasklet.data);
+	engine->execlists.tasklet.callback(&engine->execlists.tasklet);
 	GEM_BUG_ON(execlists_active(&engine->execlists) != rq);
 
 	/* Fake a preemption event; failed of course */
Signature · 6 lines
2.30.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: use new tasklet API in execlist selftest

== Series Details ==

== Series Details ==

Series: drm/i915/gt: use new tasklet API in execlist selftest
URL : https://patchwork.freedesktop.org/series/86312/
State : failure

== Summary ==

Applying: drm/i915/gt: use new tasklet API in execlist selftest Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/gt/selftest_execlists.c
Falling back to patching base and 3-way merge... Auto-merging drivers/gpu/drm/i915/gt/selftest_execlists.c No changes -- Patch already applied.

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx