i3c/master/mipi-i3c-hci: Specify HAS_IOMEM dependency
PATCH 1/1 i3c/master/mipi-i3c-hci: Specify HAS_IOMEM dependency
The MIPI i3c HCI driver makes use of IOMEM functions like devm_platform_ioremap_resource(), which are only available if CONFIG_HAS_IOMEM is defined.
This causes the driver to be enabled under make ARCH=um allyesconfig, even though it won't build.
By adding a dependency on HAS_IOMEM, the driver will not be enabled on architectures which don't support it.
--- drivers/i3c/master/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/i3c/master/Kconfig +1 -0
@@ -25,6 +25,7 @@ config DW_I3C_MASTER config MIPI_I3C_HCI tristate "MIPI I3C Host Controller Interface driver (EXPERIMENTAL)" depends on I3C + depends on HAS_IOMEM help Support for hardware following the MIPI Aliance's I3C Host Controller Interface specification.
Signature · 1 line
2.30.0.280.ga3ce27912f-goog
Quoted 4 lines · David Gow
The MIPI i3c HCI driver makes use of IOMEM functions like
devm_platform_ioremap_resource(), which are only available ifCONFIG_HAS_IOMEMis defined.
Quoted 8 lines
This causes the driver to be enabled under make ARCH=um allyesconfig, even though it won't build.
By adding a dependency on
HAS_IOMEM, the driver will not be enabled on architectures which don't support it.Fixes 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")Signed-off-by David Gow <[email protected]>
Quoted 20 lines
--- drivers/i3c/master/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/i3c/master/Kconfig +1
-0@@ -25,6 +25,7 @@ config DW_I3C_MASTER config MIPI_I3C_HCI tristate "MIPI I3C Host Controller Interface driver (EXPERIMENTAL)" depends on I3C + depends on HAS_IOMEM help Support for hardware following the MIPI Aliance's I3C Host Controller Interface specification.Signature · 1 line
2.30.0.280.ga3ce27912f-goog
Quoted 4 lines · David Gow
The MIPI i3c HCI driver makes use of IOMEM functions like
devm_platform_ioremap_resource(), which are only available ifCONFIG_HAS_IOMEMis defined.
Quoted 8 lines
This causes the driver to be enabled under make ARCH=um allyesconfig, even though it won't build.
By adding a dependency on
HAS_IOMEM, the driver will not be enabled on architectures which don't support it.Fixes 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")Signed-off-by David Gow <[email protected]>
Quoted 25 lines
--- drivers/i3c/master/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/i3c/master/Kconfig +1
-0@@ -25,6 +25,7 @@ config DW_I3C_MASTER config MIPI_I3C_HCI tristate "MIPI I3C Host Controller Interface driver (EXPERIMENTAL)" depends on I3C + depends on HAS_IOMEM help Support for hardware following the MIPI Aliance's I3C Host Controller Interface specification.Signature · 7 lines
2.30.0.280.ga3ce27912f-goog -- linux-i3c mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-i3c
Signature · 3 lines
linux-i3c mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-i3c
Quoted 8 lines · David Gow
The MIPI i3c HCI driver makes use of IOMEM functions like
devm_platform_ioremap_resource(), which are only available ifCONFIG_HAS_IOMEMis defined.This causes the driver to be enabled under make ARCH=um allyesconfig, even though it won't build.
[...]
Applied, thanks!
[1/1] i3c/master/mipi-i3c-hci: Specify HAS_IOMEM dependency
commit: 9d909f1b1e91b4aa7d016ed14b7b76dbf2675414
Best regards,
Signature · 6 lines
Alexandre Belloni <[email protected]> -- linux-i3c mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-i3c