Skip to contentSkip to conversation

elfutils: split libdebuginfod into its own package

PATCH Superseded Dorinda 3 participants 3 messages Jan 27, 2021

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Dorinda

author
#0 lore raw

PATCH v4 1/1 elfutils: split libdebuginfod into its own package

Added package options for libdebuginfod.
Added GPLv2+ | LGPLv3+ license for libdebuginfod with reference to https://sourceware.org/git/?p=elfutils.git;a=blob;f=debuginfod/debuginfod-client.c;h=de26af5bb26e187b51d9ea00d5826e199a96d01a;hb=HEAD

[YOCTO #13807]

---
v4:
-changed LIC_FILES_CHKSUM for debuginfod-client.c

 meta/recipes-devtools/elfutils/elfutils_0.182.bb | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
meta/recipes-devtools/elfutils/elfutils_0.182.bb +7 -3
index f63208d72b..0b4c30b936 100644
@@ -1,8 +1,10 @@
 SUMMARY = "Utilities and libraries for handling compiled object files"
 HOMEPAGE = "https://sourceware.org/elfutils"
 SECTION = "base"
-LICENSE = "GPLv2 & LGPLv3+ & GPLv3+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
+LICENSE = "GPLv2 & GPLv2+ & LGPLv3+ & GPLv3+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
+                    file://debuginfod/debuginfod-client.c;md5=0cf97982735b2ea53f5d7fcd7d88dafe \
+                    "
 DEPENDS = "zlib virtual/libintl"
 DEPENDS_append_libc-musl = " argp-standalone fts musl-obstack "
 # The Debian patches below are from:
@@ -91,7 +93,7 @@ EXTRA_OEMAKE_class-nativesdk = ""
 BBCLASSEXTEND = "native nativesdk"
 
 # Package utilities separately
-PACKAGES =+ "${PN}-binutils libelf libasm libdw"
+PACKAGES =+ "${PN}-binutils libelf libasm libdw libdebuginfod"
 
 # shared libraries are licensed GPLv2 or GPLv3+, binaries GPLv3+
 # according to NEWS file:
@@ -103,6 +105,7 @@ LICENSE_${PN} = "GPLv3+"
 LICENSE_libelf = "GPLv2 | LGPLv3+"
 LICENSE_libasm = "GPLv2 | LGPLv3+"
 LICENSE_libdw = "GPLv2 | LGPLv3+"
+LICENSE_libdebuginfod = "GPLv2+ | LGPLv3+"
 
 FILES_${PN}-binutils = "\
     ${bindir}/eu-addr2line \
@@ -115,6 +118,7 @@ FILES_${PN}-binutils = "\
 FILES_libelf = "${libdir}/libelf-${PV}.so ${libdir}/libelf.so.*"
 FILES_libasm = "${libdir}/libasm-${PV}.so ${libdir}/libasm.so.*"
 FILES_libdw  = "${libdir}/libdw-${PV}.so ${libdir}/libdw.so.* ${libdir}/elfutils/lib*"
+FILES_libdebuginfod = "${libdir}/libdebuginfod-${PV}.so ${libdir}/libdebuginfod.so.*"
 # Some packages have the version preceeding the .so instead properly
 # versioned .so.<version>, so we need to reorder and repackage.
 #FILES_${PN} += "${libdir}/*-${PV}.so ${base_libdir}/*-${PV}.so"
Signature · 1 line
2.17.1
#1 lore raw

Hi Dorinda,

Quoted 18 lines · Dorinda

Added package options for libdebuginfod.
Added GPLv2+ | LGPLv3+ license for libdebuginfod with reference to https://sourceware.org/git/?p=elfutils.git;a=blob;f=debuginfod/debuginfod-client.c;h=de26af5bb26e187b51d9ea00d5826e199a96d01a;hb=HEAD

[YOCTO #13807]

---
v4:

(quoted diff) +0 -1
-changed LIC_FILES_CHKSUM for debuginfod-client.c
 
 meta/recipes-devtools/elfutils/elfutils_0.182.bb | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
meta/recipes-devtools/elfutils/elfutils_0.182.bb +0 -0
index f63208d72b..0b4c30b936 100644

meta/recipes-devtools/elfutils/elfutils_0.182.bb line 6

Quoted 8 lines
meta/recipes-devtools/elfutils/elfutils_0.182.bb +3 -2
@@ -1,8 +1,10 @@
 SUMMARY = "Utilities and libraries for handling compiled object files"
 HOMEPAGE = "https://sourceware.org/elfutils"
 SECTION = "base"
-LICENSE = "GPLv2 & LGPLv3+ & GPLv3+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
+LICENSE = "GPLv2 & GPLv2+ & LGPLv3+ & GPLv3+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
+                    file://debuginfod/debuginfod-client.c;md5=0cf97982735b2ea53f5d7fcd7d88dafe \

That won't fly. Any change to debuginfod/debuginfod-client.c will trigger a build error because of license changes (which isn't necessarily the case).

This makes it harder to upgrade the recipe (usually, just changing the recipe version in the filename is enough, and changes to LIC_FILES_CHKSUM smell fishy).

You want to use:
file://debuginfod/debuginfod-client.c;endline=27;md5=xxxxxx

c.f. https://docs.yoctoproject.org/dev-manual/common-tasks.html#specifying-the-lic-files-chksum-variable

Cheers,
Quentin

#2 lore raw
Quoted 34 lines · Quentin Schulz

Hi Dorinda,

Quoted 21 lines · Dorinda

Added package options for libdebuginfod.
Added GPLv2+ | LGPLv3+ license for libdebuginfod with reference to https://sourceware.org/git/?p=elfutils.git;a=blob;f=debuginfod/debuginfod-client.c;h=de26af5bb26e187b51d9ea00d5826e199a96d01a;hb=HEAD

[YOCTO #13807]

---
v4:
-changed LIC_FILES_CHKSUM for debuginfod-client.c

 meta/recipes-devtools/elfutils/elfutils_0.182.bb | 10 +++++++---

 1 file changed, 7 insertions(+), 3 deletions(-)
meta/recipes-devtools/elfutils/elfutils_0.182.bb +0 -0
index f63208d72b..0b4c30b936 100644
@@ -1,8 +1,10 @@

 SUMMARY = "Utilities and libraries for handling compiled object files" HOMEPAGE = "https://sourceware.org/elfutils"
 SECTION = "base"

meta/recipes-devtools/elfutils/elfutils_0.182.bb line 6

Quoted 5 lines
meta/recipes-devtools/elfutils/elfutils_0.182.bb +3 -2
-LICENSE = "GPLv2 & LGPLv3+ & GPLv3+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
+LICENSE = "GPLv2 & GPLv2+ & LGPLv3+ & GPLv3+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
+                    file://debuginfod/debuginfod-client.c;md5=0cf97982735b2ea53f5d7fcd7d88dafe \

That won't fly. Any change to debuginfod/debuginfod-client.c will trigger a build error because of license changes (which isn't necessarily the case).

Quoted 8 lines

This makes it harder to upgrade the recipe (usually, just changing the recipe version in the filename is enough, and changes to LIC_FILES_CHKSUM smell fishy).

You want to use:
file://debuginfod/debuginfod-client.c;endline=27;md5=xxxxxx

c.f. https://docs.yoctoproject.org/dev-manual/common-tasks.html#specifying-the-lic-files-chksum-variable

To be fair I think that was in a previous patch and my comments weren't clear, I was asking for the ${WORKDIR} piece to be removed but not the parameters which were correct!

Cheers,

Richard