Skip to contentSkip to conversation

drm/bridge: anx7625: enable DSI EOTP

PATCH In review Xin Ji 4 participants 7 messages Jan 28, 2021 – Feb 5, 2021

Subsystems (3)
lore
Share & tools
lore

Xin Ji

author
#0 lore raw

PATCH 1/1 drm/bridge: anx7625: enable DSI EOTP

Enable DSI EOTP feature for fixing some panel screen constance shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.

---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/bridge/analogix/anx7625.c +0 -1
index 65cc059..e31eeb1b 100644
@@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
 	dsi->format = MIPI_DSI_FMT_RGB888;
 	dsi->mode_flags = MIPI_DSI_MODE_VIDEO	|
 		MIPI_DSI_MODE_VIDEO_SYNC_PULSE	|
-		MIPI_DSI_MODE_EOT_PACKET	|
 		MIPI_DSI_MODE_VIDEO_HSE;
 
 	if (mipi_dsi_attach(dsi) < 0) {
Signature · 1 line
2.7.4
#1 lore raw

Hi Xin,

Thanks for the patch.

Quoted 4 lines · Xin Ji

Enable DSI EOTP feature for fixing some panel screen constance shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.

I don't think I quite understand how removing the MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could you extrapolate on this in the commit message?

Quoted 21 lines
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/bridge/analogix/anx7625.c +0 -2
index 65cc059..e31eeb1b 100644
@@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
        dsi->format = MIPI_DSI_FMT_RGB888;
        dsi->mode_flags = MIPI_DSI_MODE_VIDEO   |
                MIPI_DSI_MODE_VIDEO_SYNC_PULSE  |
-               MIPI_DSI_MODE_EOT_PACKET        |
                MIPI_DSI_MODE_VIDEO_HSE;
 
        if (mipi_dsi_attach(dsi) < 0) {
--

2.7.4

#2 lore raw
Quoted 7 lines · Robert Foss

Hi Xin,

Thanks for the patch.

Quoted 1 line · Xin Ji
Quoted 7 lines
Quoted 3 lines

Enable DSI EOTP feature for fixing some panel screen constance shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.

I don't think I quite understand how removing the MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could you extrapolate on this in the commit message?

That confused me as well, but it turns out that's how the flag is defined:

```
/* disable EoT packets in HS mode */
#define MIPI_DSI_MODE_EOT_PACKET BIT(9)
```

(https://elixir.bootlin.com/linux/latest/source/include/drm/drm_mipi_dsi.h#L129)

I'm almost tempted to put together a mass patch to rename all of these flags...

Quoted 18 lines
Quoted 18 lines
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/bridge/analogix/anx7625.c +0 -1
index 65cc059..e31eeb1b 100644
@@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
        dsi->format = MIPI_DSI_FMT_RGB888;
        dsi->mode_flags = MIPI_DSI_MODE_VIDEO   |
                MIPI_DSI_MODE_VIDEO_SYNC_PULSE  |
-               MIPI_DSI_MODE_EOT_PACKET        |
                MIPI_DSI_MODE_VIDEO_HSE;
 
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/bridge/analogix/anx7625.c +0 -1
        if (mipi_dsi_attach(dsi) < 0) {
--

2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:

Quoted 12 lines · Robert Foss
Quoted 11 lines

Hi Xin,

Thanks for the patch.

Quoted 3 lines · Xin Ji

Enable DSI EOTP feature for fixing some panel screen constance shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.

I don't think I quite understand how removing the MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could you extrapolate on this in the commit message?

Quoted 8 lines

That confused me as well, but it turns out that's how the flag is defined:

```
/* disable EoT packets in HS mode */
#define MIPI_DSI_MODE_EOT_PACKET BIT(9)
```

(https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)

I'm almost tempted to put together a mass patch to rename all of these flags...

Yes that would be good, many of these flags were just copy pasted from some hw datasheet, without good analysis how to adapt them to the framework.

Regards

Andrzej

Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
---
  drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
  1 file changed, 1 deletion(-)
drivers/gpu/drm/bridge/analogix/anx7625.c +0 -1
index 65cc059..e31eeb1b 100644
@@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
         dsi->format = MIPI_DSI_FMT_RGB888;
         dsi->mode_flags = MIPI_DSI_MODE_VIDEO   |
                 MIPI_DSI_MODE_VIDEO_SYNC_PULSE  |
-               MIPI_DSI_MODE_EOT_PACKET        |
                 MIPI_DSI_MODE_VIDEO_HSE;
 
Quoted 9 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/bridge/analogix/anx7625.c +0 -1
         if (mipi_dsi_attach(dsi) < 0) {
--

2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw
Quoted 22 lines · Andrzej Hajda

W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:

Quoted 19 lines · Robert Foss
Quoted 11 lines

Hi Xin,

Thanks for the patch.

Quoted 3 lines · Xin Ji

Enable DSI EOTP feature for fixing some panel screen constance shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.

I don't think I quite understand how removing the MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could you extrapolate on this in the commit message?

That confused me as well, but it turns out that's how the flag is defined:

```
/* disable EoT packets in HS mode */
#define MIPI_DSI_MODE_EOT_PACKET BIT(9)
```

(https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)

Quoted 5 lines
Quoted 1 line

I'm almost tempted to put together a mass patch to rename all of these flags...

Yes that would be good, many of these flags were just copy pasted from some hw datasheet, without good analysis how to adapt them to the framework.

I'll look into it (but that shouldn't block this patch).

Quoted 33 lines

Regards

Andrzej

Quoted 26 lines
Quoted 17 lines
Quoted 17 lines
---
  drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
  1 file changed, 1 deletion(-)
drivers/gpu/drm/bridge/analogix/anx7625.c +0 -1
index 65cc059..e31eeb1b 100644
@@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
         dsi->format = MIPI_DSI_FMT_RGB888;
         dsi->mode_flags = MIPI_DSI_MODE_VIDEO   |
                 MIPI_DSI_MODE_VIDEO_SYNC_PULSE  |
-               MIPI_DSI_MODE_EOT_PACKET        |
                 MIPI_DSI_MODE_VIDEO_HSE;
 
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/bridge/analogix/anx7625.c +0 -1
         if (mipi_dsi_attach(dsi) < 0) {
--

2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reviewed-by
#5 lore raw
Quoted 6 lines · Nicolas Boichat
Quoted 4 lines · Andrzej Hajda

W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:

Quoted 1 line · Robert Foss
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Hi Xin,

Thanks for the patch.

Quoted 3 lines · Xin Ji

Enable DSI EOTP feature for fixing some panel screen constance shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.

Does "constance shift" have a typo? Should it be "constant shift"?

With that sorted out feel free to add my r-b.

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines

I don't think I quite understand how removing the MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could you extrapolate on this in the commit message?

That confused me as well, but it turns out that's how the flag is defined:

```
/* disable EoT packets in HS mode */
#define MIPI_DSI_MODE_EOT_PACKET BIT(9)
```

(https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

I'm almost tempted to put together a mass patch to rename all of these flags...

Yes that would be good, many of these flags were just copy pasted from some hw datasheet, without good analysis how to adapt them to the framework.

I'll look into it (but that shouldn't block this patch).

Thanks for clearing this up Nicolas & Andrzej!
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author
#6 lore raw
Quoted 12 lines · Robert Foss
Quoted 11 lines · Nicolas Boichat
Quoted 9 lines · Andrzej Hajda

W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:

Quoted 6 lines · Robert Foss
Quoted 5 lines

Hi Xin,

Thanks for the patch.

On Thu, 28 Jan 2021 at 12:17, Xin Ji <[email protected]> wrote:

Quoted 8 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Enable DSI EOTP feature for fixing some panel screen constance shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.

Does "constance shift" have a typo? Should it be "constant shift"?

With that sorted out feel free to add my r-b.

Hi Robert Foss, thanks, I'll correct it.
Thanks,
Xin

Quoted 20 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 4 lines

I don't think I quite understand how removing the MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could you extrapolate on this in the commit message?

That confused me as well, but it turns out that's how the flag is defined:

```
/* disable EoT packets in HS mode */
#define MIPI_DSI_MODE_EOT_PACKET BIT(9)
```

(https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

I'm almost tempted to put together a mass patch to rename all of these flags...

Yes that would be good, many of these flags were just copy pasted from some hw datasheet, without good analysis how to adapt them to the framework.

I'll look into it (but that shouldn't block this patch).

Thanks for clearing this up Nicolas & Andrzej!