Skip to contentSkip to conversation

ARM: dts: am33xx: add aliases for mmc interfaces

PATCH In review Mans Rullgard 2 participants 2 messages Jan 28, 2021 – Feb 4, 2021 2 messages not in the archive Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: am33xx: add aliases for mmc interfaces

Without DT aliases, the numbering of mmc interfaces is unpredictable. Adding them makes it possible to refer to devices consistently. The popular suggestion to use UUIDs obviously doesn't work with a blank device fresh from the factory.

See fa2d0aa96941 "mmc: core: Allow setting slot index via device tree alias" for more discussion.

---
 arch/arm/boot/dts/am33xx.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/boot/dts/am33xx.dtsi +3 -0
index 4c2298024137..f09a61cac2dc 100644
@@ -40,6 +40,9 @@ aliases {
 		ethernet1 = &cpsw_emac1;
 		spi0 = &spi0;
 		spi1 = &spi1;
+		mmc0 = &mmc1;
+		mmc1 = &mmc2;
+		mmc2 = &mmc3;
 	};
 
 	cpus {
Signature · 1 line
2.30.0

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 14 lines · Måns Rullgård
Quoted 11 lines · Tony Lindgren
Quoted 7 lines · Mans Rullgard

Without DT aliases, the numbering of mmc interfaces is unpredictable. Adding them makes it possible to refer to devices consistently. The popular suggestion to use UUIDs obviously doesn't work with a blank device fresh from the factory.

See fa2d0aa96941 "mmc: core: Allow setting slot index via device tree alias" for more discussion.

Sounds good to me, but will wait a few days before applying to make sure this is still what we have agreed on :)

Quoted 7 lines

If it helps the decision, my existing systems fail to boot without something like this due to the eMMC moving from /dev/mmcblk1 to mmcblk0, at least sometimes. I guess the kernel cares deeply about not breaking userspace, except when it doesn't give a damn.

I've been fighting this problem in various forms for the last 10 years or so, and I was hoping it would finally be over.

Yes this issue has been bugging folks for long time. Applying into fixes thanks.

Tony