vmlinux.lds.h: Define SANTIZER_DISCARDS with CONFIG_GCOV_KERNEL=y
PATCH 1/1 vmlinux.lds.h: Define SANTIZER_DISCARDS with CONFIG_GCOV_KERNEL=y
clang produces .eh_frame sections when CONFIG_GCOV_KERNEL is enabled, even when -fno-asynchronous-unwind-tables is in KBUILD_CFLAGS:
$ make CC=clang vmlinux ... ld: warning: orphan section `.eh_frame' from `init/main.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/version.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts_initrd.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/initramfs.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/calibrate.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/init_task.o' being placed in section `.eh_frame' ...
$ rg "GCOV_KERNEL|GCOV_PROFILE_ALL" .config CONFIG_GCOV_KERNEL=y CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y CONFIG_GCOV_PROFILE_ALL=y
This was already handled for a couple of other options in commit d812db78288d ("vmlinux.lds.h: Avoid KASAN and KCSAN's unwanted sections") and there is an open LLVM bug for this issue. Take advantage of that section for this config as well so that there are no more orphan warnings.
--- include/asm-generic/vmlinux.lds.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
include/asm-generic/vmlinux.lds.h +3 -2
@@ -988,12 +988,13 @@#endif /* -* Clang's -fsanitize=kernel-address and -fsanitize=thread produce +* Clang's -fsanitize=kernel-address, -fsanitize=thread, +* and -fprofile-arcs -ftest-coverage produce unwanted * unwanted sections (.eh_frame and .init_array.*), but * CONFIG_CONSTRUCTORS wants to keep any .init_array.* sections. * https://bugs.llvm.org/show_bug.cgi?id=46478 */ -#if defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN ) +#if defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN ) || defined(CONFIG_GCOV_KERNEL )# ifdef CONFIG_CONSTRUCTORS # define SANITIZER_DISCARDS \ *(.eh_frame)
base-commit: bec4c2968fce2f44ce62d05288a633cd99a722eb
Signature · 1 line
2.30.0
Quoted 26 lines · Nathan Chancellor
clang produces .eh_frame sections when
CONFIG_GCOV_KERNELis enabled, even when -fno-asynchronous-unwind-tables is inKBUILD_CFLAGS:$ make CC=clang vmlinux ... ld: warning: orphan section `.eh_frame' from `init/main.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/version.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts_initrd.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/initramfs.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/calibrate.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/init_task.o' being placed in section `.eh_frame' ...$ rg "GCOV_KERNEL|GCOV_PROFILE_ALL" .config CONFIG_GCOV_KERNEL=y CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y CONFIG_GCOV_PROFILE_ALL=yThis was already handled for a couple of other options in commit
d812db78288d("vmlinux.lds.h: Avoid KASAN and KCSAN's unwanted sections") and there is an open LLVM bug for this issue. Take advantage of that section for this config as well so that there are no more orphan warnings.
Quoted 4 lines
I suspect we're going to need to add module level attributes in LLVM IR for these options, then check those when synthesizing new function definitions within LLVM. At least we'll be able to point to this file and say "hey, this is a general problem in LLVM, and here are 3 specific cases now where it's a problem." Not a large problem, but would help us save some bytes in the final object. LLVM is not producing data in this section for all code, just these synthesized routines.
Quoted 29 lines
--- include/asm-generic/vmlinux.lds.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)include/asm-generic/vmlinux.lds.h +3
-2@@ -988,12 +988,13 @@#endif /* -* Clang's -fsanitize=kernel-address and -fsanitize=thread produce +* Clang's -fsanitize=kernel-address, -fsanitize=thread, +* and -fprofile-arcs -ftest-coverage produce unwanted * unwanted sections (.eh_frame and .init_array.*), but * CONFIG_CONSTRUCTORS wants to keep any .init_array.* sections. * https://bugs.llvm.org/show_bug.cgi?id=46478 */ -#if defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN ) +#if defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN ) || defined(CONFIG_GCOV_KERNEL )# ifdef CONFIG_CONSTRUCTORS # define SANITIZER_DISCARDS \ *(.eh_frame)base-commit:
bec4c2968fce2f44ce62d05288a633cd99a722eb--
2.30.0
Signature · 2 lines
Thanks, ~Nick Desaulniers
Fangrui Song
Reviewed-byQuoted 34 lines · Nick Desaulniers
Quoted 26 lines · Nathan Chancellor
clang produces .eh_frame sections when
CONFIG_GCOV_KERNELis enabled, even when -fno-asynchronous-unwind-tables is inKBUILD_CFLAGS:$ make CC=clang vmlinux ... ld: warning: orphan section `.eh_frame' from `init/main.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/version.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts_initrd.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/initramfs.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/calibrate.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/init_task.o' being placed in section `.eh_frame' ...$ rg "GCOV_KERNEL|GCOV_PROFILE_ALL" .config CONFIG_GCOV_KERNEL=y CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y CONFIG_GCOV_PROFILE_ALL=yThis was already handled for a couple of other options in commit
d812db78288d("vmlinux.lds.h: Avoid KASAN and KCSAN's unwanted sections") and there is an open LLVM bug for this issue. Take advantage of that section for this config as well so that there are no more orphan warnings.Quoted 4 lines
Reviewed-by Nick Desaulniers <[email protected]>
Quoted 8 lines
I suspect we're going to need to add module level attributes in LLVM IR for these options, then check those when synthesizing new function definitions within LLVM. At least we'll be able to point to this file and say "hey, this is a general problem in LLVM, and here are 3 specific cases now where it's a problem." Not a large problem, but would help us save some bytes in the final object. LLVM is not producing data in this section for all code, just these synthesized routines.
Maybe. There are also a long list of security features which may impose additional requirements. Adding a module flag metadata for each such feature will be a long battle. For .eh_frame, I think it is important/generic enough and can benefit other applications that deserves special handling (and I can look into it). For .init_array, I am not too sure....
Quoted 25 lines
Quoted 25 lines
--- include/asm-generic/vmlinux.lds.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)include/asm-generic/vmlinux.lds.h +3
-2@@ -988,12 +988,13 @@#endif /* -* Clang's -fsanitize=kernel-address and -fsanitize=thread produce +* Clang's -fsanitize=kernel-address, -fsanitize=thread, +* and -fprofile-arcs -ftest-coverage produce unwanted * unwanted sections (.eh_frame and .init_array.*), but * CONFIG_CONSTRUCTORS wants to keep any .init_array.* sections. * https://bugs.llvm.org/show_bug.cgi?id=46478 */ -#if defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN ) +#if defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN ) || defined(CONFIG_GCOV_KERNEL )# ifdef CONFIG_CONSTRUCTORS # define SANITIZER_DISCARDS \ *(.eh_frame)
Quoted 4 lines
Quoted 4 lines
base-commit:
bec4c2968fce2f44ce62d05288a633cd99a722eb--
2.30.0
Drop -ftest-coverage. -ftest-coverage just produces .gcno and does not affect code generation.
PATCH v3 1/1 vmlinux.lds.h: Define SANTIZER_DISCARDS with CONFIG_GCOV_KERNEL=y
In reply to Nathan Chancellorclang produces .eh_frame sections when CONFIG_GCOV_KERNEL is enabled, even when -fno-asynchronous-unwind-tables is in KBUILD_CFLAGS:
$ make CC=clang vmlinux ... ld: warning: orphan section `.eh_frame' from `init/main.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/version.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts_initrd.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/initramfs.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/calibrate.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/init_task.o' being placed in section `.eh_frame' ...
$ rg "GCOV_KERNEL|GCOV_PROFILE_ALL" .config CONFIG_GCOV_KERNEL=y CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y CONFIG_GCOV_PROFILE_ALL=y
This was already handled for a couple of other options in commit d812db78288d ("vmlinux.lds.h: Avoid KASAN and KCSAN's unwanted sections") and there is an open LLVM bug for this issue. Take advantage of that section for this config as well so that there are no more orphan warnings.
---
v2 -> v3:
* Fix double "unwanted" in comment section per Sedat.
v1 -> v2:
* Keep configs and flag names alphabetized.
* Drop mention of -ftest-coverage since it does not cause this issue per Fangrui.
* Pick up review tags from Fangrui and Nick.
include/asm-generic/vmlinux.lds.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
include/asm-generic/vmlinux.lds.h +5 -4
@@ -988,12 +988,13 @@#endif /* -* Clang's -fsanitize=kernel-address and -fsanitize=thread produce -* unwanted sections (.eh_frame and .init_array.*), but -* CONFIG_CONSTRUCTORS wants to keep any .init_array.* sections. +* Clang's -fprofile-arcs, -fsanitize=kernel-address, and +* -fsanitize=thread produce unwanted sections (.eh_frame +* and .init_array.*), but CONFIG_CONSTRUCTORS wants to +* keep any .init_array.* sections. * https://bugs.llvm.org/show_bug.cgi?id=46478 */ -#if defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN ) +#if defined(CONFIG_GCOV_KERNEL ) || defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN )# ifdef CONFIG_CONSTRUCTORS # define SANITIZER_DISCARDS \ *(.eh_frame)
base-commit: bec4c2968fce2f44ce62d05288a633cd99a722eb
Signature · 1 line
2.30.0
Quoted 51 lines · Nathan Chancellor
clang produces .eh_frame sections when
CONFIG_GCOV_KERNELis enabled, even when -fno-asynchronous-unwind-tables is inKBUILD_CFLAGS:$ make CC=clang vmlinux ... ld: warning: orphan section `.eh_frame' from `init/main.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/version.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts_initrd.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/initramfs.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/calibrate.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/init_task.o' being placed in section `.eh_frame' ...$ rg "GCOV_KERNEL|GCOV_PROFILE_ALL" .config CONFIG_GCOV_KERNEL=y CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y CONFIG_GCOV_PROFILE_ALL=yThis was already handled for a couple of other options in commit
d812db78288d("vmlinux.lds.h: Avoid KASAN and KCSAN's unwanted sections") and there is an open LLVM bug for this issue. Take advantage of that section for this config as well so that there are no more orphan warnings.Reported-by kernel test robot <[email protected]>Reviewed-by Fangrui Song <[email protected]>Reviewed-by Nick Desaulniers <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>---
v1 -> v2:
* Keep configs and flag names alphabetized.
* Drop mention of -ftest-coverage since it does not cause this issue per Fangrui.
* Pick up review tags from Fangrui and Nick.
include/asm-generic/vmlinux.lds.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)include/asm-generic/vmlinux.lds.h +0
-0
include/asm-generic/vmlinux.lds.h line 992
Quoted 8 lines
include/asm-generic/vmlinux.lds.h +2
-3@@ -988,12 +988,13 @@#endif /* -* Clang's -fsanitize=kernel-address and -fsanitize=thread produce -* unwanted sections (.eh_frame and .init_array.*), but -* CONFIG_CONSTRUCTORS wants to keep any .init_array.* sections. +* Clang's -fprofile-arcs, -fsanitize=kernel-address, and +* -fsanitize=thread produce unwanted unwanted sections
Typo: double "unwanted".
- Sedat -
Quoted 18 lines
include/asm-generic/vmlinux.lds.h +3
-1+* (.eh_frame and .init_array.*), but CONFIG_CONSTRUCTORS +* wants to keep any .init_array.* sections. * https://bugs.llvm.org/show_bug.cgi?id=46478 */ -#if defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN ) +#if defined(CONFIG_GCOV_KERNEL ) || defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN )# ifdef CONFIG_CONSTRUCTORS # define SANITIZER_DISCARDS \ *(.eh_frame)base-commit:
bec4c2968fce2f44ce62d05288a633cd99a722eb--
2.30.0--
You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20210130002557.2681512-1-nathan%40kernel.org.
PATCH v2 1/1 vmlinux.lds.h: Define SANTIZER_DISCARDS with CONFIG_GCOV_KERNEL=y
In reply to Nathan Chancellorclang produces .eh_frame sections when CONFIG_GCOV_KERNEL is enabled, even when -fno-asynchronous-unwind-tables is in KBUILD_CFLAGS:
$ make CC=clang vmlinux ... ld: warning: orphan section `.eh_frame' from `init/main.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/version.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts_initrd.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/initramfs.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/calibrate.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/init_task.o' being placed in section `.eh_frame' ...
$ rg "GCOV_KERNEL|GCOV_PROFILE_ALL" .config CONFIG_GCOV_KERNEL=y CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y CONFIG_GCOV_PROFILE_ALL=y
This was already handled for a couple of other options in commit d812db78288d ("vmlinux.lds.h: Avoid KASAN and KCSAN's unwanted sections") and there is an open LLVM bug for this issue. Take advantage of that section for this config as well so that there are no more orphan warnings.
---
v1 -> v2:
* Keep configs and flag names alphabetized.
* Drop mention of -ftest-coverage since it does not cause this issue per Fangrui.
* Pick up review tags from Fangrui and Nick.
include/asm-generic/vmlinux.lds.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
include/asm-generic/vmlinux.lds.h +5 -4
@@ -988,12 +988,13 @@#endif /* -* Clang's -fsanitize=kernel-address and -fsanitize=thread produce -* unwanted sections (.eh_frame and .init_array.*), but -* CONFIG_CONSTRUCTORS wants to keep any .init_array.* sections. +* Clang's -fprofile-arcs, -fsanitize=kernel-address, and +* -fsanitize=thread produce unwanted unwanted sections +* (.eh_frame and .init_array.*), but CONFIG_CONSTRUCTORS +* wants to keep any .init_array.* sections. * https://bugs.llvm.org/show_bug.cgi?id=46478 */ -#if defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN ) +#if defined(CONFIG_GCOV_KERNEL ) || defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN )# ifdef CONFIG_CONSTRUCTORS # define SANITIZER_DISCARDS \ *(.eh_frame)
base-commit: bec4c2968fce2f44ce62d05288a633cd99a722eb
Signature · 1 line
2.30.0
Quoted 72 lines · Nathan Chancellor
clang produces .eh_frame sections when
CONFIG_GCOV_KERNELis enabled, even when -fno-asynchronous-unwind-tables is inKBUILD_CFLAGS:$ make CC=clang vmlinux ... ld: warning: orphan section `.eh_frame' from `init/main.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/version.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts_initrd.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/initramfs.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/calibrate.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/init_task.o' being placed in section `.eh_frame' ...$ rg "GCOV_KERNEL|GCOV_PROFILE_ALL" .config CONFIG_GCOV_KERNEL=y CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y CONFIG_GCOV_PROFILE_ALL=yThis was already handled for a couple of other options in commit
d812db78288d("vmlinux.lds.h: Avoid KASAN and KCSAN's unwanted sections") and there is an open LLVM bug for this issue. Take advantage of that section for this config as well so that there are no more orphan warnings.Reported-by kernel test robot <[email protected]>Reviewed-by Fangrui Song <[email protected]>Reviewed-by Nick Desaulniers <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>---
v2 -> v3:
* Fix double "unwanted" in comment section per Sedat.
v1 -> v2:
* Keep configs and flag names alphabetized.
* Drop mention of -ftest-coverage since it does not cause this issue per Fangrui.
* Pick up review tags from Fangrui and Nick.
include/asm-generic/vmlinux.lds.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)include/asm-generic/vmlinux.lds.h +5
-4@@ -988,12 +988,13 @@#endif /* -* Clang's -fsanitize=kernel-address and -fsanitize=thread produce -* unwanted sections (.eh_frame and .init_array.*), but -* CONFIG_CONSTRUCTORS wants to keep any .init_array.* sections. +* Clang's -fprofile-arcs, -fsanitize=kernel-address, and +* -fsanitize=thread produce unwanted sections (.eh_frame +* and .init_array.*), but CONFIG_CONSTRUCTORS wants to +* keep any .init_array.* sections. * https://bugs.llvm.org/show_bug.cgi?id=46478 */ -#if defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN ) +#if defined(CONFIG_GCOV_KERNEL ) || defined(CONFIG_KASAN_GENERIC ) || defined(CONFIG_KCSAN )# ifdef CONFIG_CONSTRUCTORS # define SANITIZER_DISCARDS \ *(.eh_frame)
Quoted 4 lines
base-commit:
bec4c2968fce2f44ce62d05288a633cd99a722ebSignature · 1 line
2.30.0
Andrew, Arnd, or Kees:
Would one of you be able to pick this up and get it to Linus? I think the 0day bot just tripped over this again:
https://lists.01.org/hyperkitty/list/[email protected]/message/BXBY7OPVMOCCUZSCFEZXI7RG65RJWJ52/
https://lists.01.org/hyperkitty/list/[email protected]/message/QF62LWM6YSNWWNOM7AXYK4734AKH2SVT/
Cheers,
Nathan
Kees Cook
AppliedQuoted 14 lines · Nathan Chancellor
clang produces .eh_frame sections when
CONFIG_GCOV_KERNELis enabled, even when -fno-asynchronous-unwind-tables is inKBUILD_CFLAGS:$ make CC=clang vmlinux ... ld: warning: orphan section `.eh_frame' from `init/main.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/version.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/do_mounts_initrd.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/initramfs.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/calibrate.o' being placed in section `.eh_frame' ld: warning: orphan section `.eh_frame' from `init/init_task.o' being placed in section `.eh_frame' ...
Quoted 1 line
[...]
Applied to kspp/linker/orphans, thanks!
[1/1] vmlinux.lds.h: Define SANTIZER_DISCARDS with CONFIG_GCOV_KERNEL=y
https://git.kernel.org/kees/c/f5b6a74d9c08
Signature · 1 line
Kees Cook