Skip to contentSkip to conversation

hw/char/exynos4210_uart: Fix missing call to report ready for input

PATCH Applied Iris Johnson 2 participants 2 messages Jan 30, 2021 – Feb 2, 2021 Arm Samsung Exynos

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/char/exynos4210_uart: Fix missing call to report ready for input

When the frontend device has no space for a read the fd is removed from polling to allow time for the guest to read and clear the buffer. Without the call to qemu_chr_fe_accept_input(), the poll will not be broken out of when the guest has cleared the buffer causing significant IO delays that get worse with smaller buffers.

---
 hw/char/exynos4210_uart.c | 1 +
 1 file changed, 1 insertion(+)
hw/char/exynos4210_uart.c +1 -0
index 6361df2ad3..51ba862d0b 100644
@@ -519,6 +519,7 @@ static uint64_t exynos4210_uart_read(void *opaque, hwaddr offset,
             s->reg[I_(UTRSTAT)] &= ~UTRSTAT_Rx_BUFFER_DATA_READY;
             res = s->reg[I_(URXH)];
         }
+        qemu_chr_fe_accept_input(&s->chr);
         exynos4210_uart_update_dmabusy(s);
         trace_exynos_uart_read(s->channel, offset,
                                exynos4210_uart_regname(offset), res);
Signature · 1 line
2.25.1
#1 lore raw
Quoted 11 lines · Iris Johnson

When the frontend device has no space for a read the fd is removed from polling to allow time for the guest to read and clear the buffer. Without the call to qemu_chr_fe_accept_input(), the poll will not be broken out of when the guest has cleared the buffer causing significant IO delays that get worse with smaller buffers.

---
 hw/char/exynos4210_uart.c | 1 +

Applied to target-arm.next, thanks.

-- PMM