intel_gpu_top: Update manual page for recent additions
PATCH 1/3 intel_gpu_top: Update manual page for recent additions
From: Tvrtko Ursulin <[email protected]>
Document numeric busyness overlay and sort selection.
--- man/intel_gpu_top.rst | 2 ++ 1 file changed, 2 insertions(+)
man/intel_gpu_top.rst +2 -0
@@ -55,6 +55,8 @@ Supported keys: 'q' Exit from the tool. '1' Toggle between aggregated engine class and physical engine mode. + 'n' Toggle display of numeric client busyness overlay. + 's' Toggle between sort modes (runtime, total runtime, client id). DEVICE SELECTION ================
Signature · 6 lines
2.27.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH 2/3 intel_gpu_top: Add option to hide inactive clients
From: Tvrtko Ursulin <[email protected]>
Allow hiding inactive clients (used no GPU time ever) in interactive mode by pressing 'i'.
--- man/intel_gpu_top.rst | 1 + tools/intel_gpu_top.c | 7 +++++++ 2 files changed, 8 insertions(+)
man/intel_gpu_top.rst +1 -0
@@ -57,6 +57,7 @@ Supported keys: '1' Toggle between aggregated engine class and physical engine mode. 'n' Toggle display of numeric client busyness overlay. 's' Toggle between sort modes (runtime, total runtime, client id). + 'i' Toggle display of clients which used no GPU time. DEVICE SELECTION ================
tools/intel_gpu_top.c +7 -0
@@ -1933,6 +1933,7 @@ print_clients_header(struct clients *clients, int lines, }static bool numeric_clients; +static bool filter_idle; static int print_client(struct client *c, struct engines *engines, double t, int lines,
@@ -1942,6 +1943,9 @@ print_client(struct client *c, struct engines *engines, double t, int lines,unsigned int i;if (output_mode ==INTERACTIVE ) { +if (filter_idle && !c->total_runtime) +return lines; + lines++;printf ("%6u %17s " , c->pid, c->print_name);
@@ -2118,6 +2122,9 @@ static void process_stdin(unsigned int timeout_us)case '1' : class_view ^= true;break ; +case 'i' : + filter_idle ^= true; +break ;case 'n' : numeric_clients ^= true;break ;
Signature · 6 lines
2.27.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Add option to hide inactive clients
Quoting Tvrtko Ursulin (2021-02-01 10:45:23)
Quoted 6 lines
From: Tvrtko Ursulin <[email protected]>
Allow hiding inactive clients (used no GPU time ever) in interactive mode by pressing 'i'.
Signed-off-by Tvrtko Ursulin <[email protected]>
Ok, that's where you meant. Coffee not winning the battle today.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH 3/3 intel_gpu_top: Fix interactive header
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Client stats refactoring broke the header layout with an extra newline.
--- tools/intel_gpu_top.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/intel_gpu_top.c +1 -1
@@ -1523,7 +1523,7 @@ print_header(const struct igt_device_card *card,printf ("\033[H\033[J" );if (lines++ < con_h) -printf ("intel-gpu-top: %s @ %s\n" , +printf ("intel-gpu-top: %s @ %s - " , codename, card->card);if (lines++ < con_h) { printf("%s/%s MHz; %s%% RC6; ",
Signature · 6 lines
2.27.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/3] intel_gpu_top: Fix interactive header
Quoting Tvrtko Ursulin (2021-02-01 10:45:24)
Quoted 3 lines
From: Tvrtko Ursulin <[email protected]>
Client stats refactoring broke the header layout with an extra newline.
Argh; keep the newline, or at least check the terminal width and make the newline conditional.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2021-02-01 10:45:22)
Quoted 3 lines
From: Tvrtko Ursulin <[email protected]>
Document numeric busyness overlay and sort selection.
I looked for a 'h' or '?' screen.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.BUILD: failure for series starting with [i-g-t,1/3] intel_gpu_top: Update manual page for recent additions
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,1/3] intel_gpu_top: Update manual page for recent additions
URL : https://patchwork.freedesktop.org/series/86527/
State : failure
== Summary ==
Applying: intel_gpu_top: Update manual page for recent additions Using index info to reconstruct a base tree...
M man/intel_gpu_top.rst
Falling back to patching base and 3-way merge...
Auto-merging man/intel_gpu_top.rst
CONFLICT (content): Merge conflict in man/intel_gpu_top.rst Patch failed at 0001 intel_gpu_top: Update manual page for recent additions When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev