Skip to contentSkip to conversation

ima_evm_utils: Add testing with elliptic curves prime192v1 and 256v1

PATCH In review Stefan Berger 1 participant 2 messages Feb 2, 2021 Keys-trusted

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ima_evm_utils: Add testing with elliptic curves prime192v1 and 256v1

Add test cases that test the signing and signature verification with the elliptic curves prime192v1 and prime256v1, also known as NIST P192 and P256. These curves will soon be supported by Linux. If OpenSSL cannot generate prime192v1 keys, as is the case on Fedora, where this curve is not supported, the respective tests will be skipped automatically.

---
 tests/gen-keys.sh      | 20 ++++++++++++++++++++
 tests/sign_verify.test | 15 +++++++++++++++
 2 files changed, 35 insertions(+)
tests/gen-keys.sh +20 -0
index 407876b..46130cf 100755
@@ -66,6 +66,26 @@ for m in 1024 2048; do
   fi
 done
 
+for curve in prime192v1 prime256v1; do
+  if [ "$1" = clean ] || [ "$1" = force ]; then
+    rm -f test-$curve.cer test-$curve.key test-$curve.pub
+  fi
+  if [ "$1" = clean ]; then
+    continue
+  fi
+  if [ ! -e test-$curve.key ]; then
+    log openssl req -verbose -new -nodes -utf8 -sha1 -days 10000 -batch -x509 \
+      -config test-ca.conf \
+      -newkey ec \
+      -pkeyopt ec_paramgen_curve:$curve \
+      -out test-$curve.cer -outform DER \
+      -keyout test-$curve.key
+    if [ -s test-$curve.key ]; then
+      log openssl pkey -in test-$curve.key -out test-$curve.pub -pubout
+    fi
+  fi
+done
+
 # EC-RDSA
 for m in \
   gost2012_256:A \
tests/sign_verify.test +15 -0
index 288e133..b4fffda 100755
@@ -366,6 +366,21 @@ sign_verify  rsa1024  sha384  0x030205:K:0080
 sign_verify  rsa1024  sha512  0x030206:K:0080
 sign_verify  rsa1024  rmd160  0x030203:K:0080
 
+# Test v2 signatures with ECDSA
+# Signature length can be 0x36-0x38 bytes long
+sign_verify  prime192v1 sha1   0x030202:K:003[678]
+sign_verify  prime192v1 sha224 0x030207:K:003[678]
+sign_verify  prime192v1 sha256 0x030204:K:003[678]
+sign_verify  prime192v1 sha384 0x030205:K:003[678]
+sign_verify  prime192v1 sha512 0x030206:K:003[678]
+
+# Signature length can be 0x46-0x48 bytes long
+sign_verify  prime256v1 sha1   0x030202:K:004[678]
+sign_verify  prime256v1 sha224 0x030207:K:004[678]
+sign_verify  prime256v1 sha256 0x030204:K:004[678]
+sign_verify  prime256v1 sha384 0x030205:K:004[678]
+sign_verify  prime256v1 sha512 0x030206:K:004[678]
+
 # Test v2 signatures with EC-RDSA
 _enable_gost_engine
 sign_verify  gost2012_256-A md_gost12_256 0x030212:K:0040
Signature · 1 line
2.26.2
#1 lore raw
Quoted 48 lines · Stefan Berger

Add test cases that test the signing and signature verification with the elliptic curves prime192v1 and prime256v1, also known as NIST P192 and P256. These curves will soon be supported by Linux. If OpenSSL cannot generate prime192v1 keys, as is the case on Fedora, where this curve is not supported, the respective tests will be skipped automatically.

---
  tests/gen-keys.sh      | 20 ++++++++++++++++++++
  tests/sign_verify.test | 15 +++++++++++++++
  2 files changed, 35 insertions(+)
tests/gen-keys.sh +20 -0
index 407876b..46130cf 100755
@@ -66,6 +66,26 @@ for m in 1024 2048; do
    fi
  done
 
+for curve in prime192v1 prime256v1; do
+  if [ "$1" = clean ] || [ "$1" = force ]; then
+    rm -f test-$curve.cer test-$curve.key test-$curve.pub
+  fi
+  if [ "$1" = clean ]; then
+    continue
+  fi
+  if [ ! -e test-$curve.key ]; then
+    log openssl req -verbose -new -nodes -utf8 -sha1 -days 10000 -batch -x509 \
+      -config test-ca.conf \
+      -newkey ec \
+      -pkeyopt ec_paramgen_curve:$curve \
+      -out test-$curve.cer -outform DER \
+      -keyout test-$curve.key
+    if [ -s test-$curve.key ]; then
+      log openssl pkey -in test-$curve.key -out test-$curve.pub -pubout
+    fi
+  fi
+done
+
  # EC-RDSA
  for m in \
    gost2012_256:A \
tests/sign_verify.test +0 -0
index 288e133..b4fffda 100755

tests/sign_verify.test sign_verify rsa1024 sha384 0x030205:K:0080 · line 371

Quoted 6 lines
tests/sign_verify.test +3 -0
@@ -366,6 +366,21 @@ sign_verify  rsa1024  sha384  0x030205:K:0080
  sign_verify  rsa1024  sha512  0x030206:K:0080
  sign_verify  rsa1024  rmd160  0x030203:K:0080
 
+# Test v2 signatures with ECDSA
+# Signature length can be 0x36-0x38 bytes long
+sign_verify  prime192v1 sha1   0x030202:K:003[678]

Actually valid sizes are also 0x35 and 0x45 below. Smaller ones seems to be rather rare, though, but I will leave my tests running. It depends on the r and s components of the signature and whether they have leading zeros, which will be cut away.

So I need to send a v2 for this.

   Stefan