usb: typec: tcpm: Set in_ams flag when Source caps have been received
Subsystems (3)
Badhri Jagan Sridharan
maintainerPATCH 1/1 usb: typec: tcpm: Set in_ams flag when Source caps have been received
Receiving the first packet in an AMS sequence signals the beginning of AMS. Set in_ams flag to true when SRC_CAPS are received during POWER_NEGOTIATION AMS.
This fixes the failure flagged while running TD.PD.SNK.E9 compliance test.
From Deterministic PD compliance MOI spec:
TD.PD.SNK.E9. GetSinkCap in Place of Accept
Description:
As Provider, the Tester intentionally sends a GetSinkCap message in place of Accept message and verifies the UUT will send a SoftReset and recover from the error.
Steps:
a) Run PROC.PD.E1 Bring-up according to the UUT role.
b) The Tester cycles VBus.
c) The Tester sends a Source Capabilities message to the UUT.
d) Upon receipt of a Request message from the UUT, the Tester replies with a GoodCRC message.
e) The Tester sends a GetSinkCap message to the UUT.
f) If a SoftReset is not received within 15 ms after the GetSinkCap EOP was sent, the test fails.
g) If a SoftReset is received timely, the Tester replies with an Accept message.
h) The Tester sends Source Capabilities message to the UUT repeatedly until nCapsCount reached or a GoodCRC is received. If nCapsCount reached, the test fails.
i) If a Request is not received timely within 30 ms after the GoodCRC EOP corresponding to Source Capabilities message was received, the test fails.
--- drivers/usb/typec/tcpm/tcpm.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/typec/tcpm/tcpm.c +1 -0
@@ -2243,6 +2243,7 @@ static void tcpm_pd_data_request(struct tcpm_port *port,* handled. */ port->ams =POWER_NEGOTIATION ; + port->in_ams = true;tcpm_set_state (port,SNK_NEGOTIATE_CAPABILITIES ,0 ); }else {if (port->ams ==GET_SOURCE_CAPABILITIES )
Signature · 1 line
2.30.0.365.g02bc693789-goog
Quoted 30 lines · Badhri Jagan Sridharan
Receiving the first packet in an AMS sequence signals the beginning of AMS. Set
in_amsflag to true whenSRC_CAPSare received duringPOWER_NEGOTIATIONAMS.
This fixes the failure flagged while running TD.PD.SNK.E9 compliance test.Quoted 1 line
From Deterministic PD compliance MOI spec:
TD.PD.SNK.E9. GetSinkCap in Place of Accept
Description:
As Provider, the Tester intentionally sends a GetSinkCap message in place of Accept message and verifies the UUT will send a SoftReset and recover from the error.
Steps:
a) Run PROC.PD.E1 Bring-up according to the UUT role.
b) The Tester cycles VBus.
c) The Tester sends a Source Capabilities message to the UUT.
d) Upon receipt of a Request message from the UUT, the Tester replies with a GoodCRC message.
e) The Tester sends a GetSinkCap message to the UUT.
f) If a SoftReset is not received within 15 ms after the GetSinkCap EOP was sent, the test fails.
g) If a SoftReset is received timely, the Tester replies with an Accept message.
h) The Tester sends Source Capabilities message to the UUT repeatedly until nCapsCount reached or a GoodCRC is received. If nCapsCount reached, the test fails.
i) If a Request is not received timely within 30 ms after the GoodCRC EOP corresponding to Source Capabilities message was received, the test fails.
Quoted 1 line
Signed-off-by Badhri Jagan Sridharan <[email protected]>
Quoted 17 lines
--- drivers/usb/typec/tcpm/tcpm.c | 1 + 1 file changed, 1 insertion(+)drivers/usb/typec/tcpm/tcpm.c +1
-0@@ -2243,6 +2243,7 @@ static void tcpm_pd_data_request(struct tcpm_port *port,* handled. */ port->ams =POWER_NEGOTIATION ; + port->in_ams = true;tcpm_set_state (port,SNK_NEGOTIATE_CAPABILITIES ,0 ); }else {if (port->ams ==GET_SOURCE_CAPABILITIES )
Quoted 30 lines · Badhri Jagan Sridharan
Receiving the first packet in an AMS sequence signals the beginning of AMS. Set
in_amsflag to true whenSRC_CAPSare received duringPOWER_NEGOTIATIONAMS.
This fixes the failure flagged while running TD.PD.SNK.E9 compliance test.Quoted 1 line
From Deterministic PD compliance MOI spec:
TD.PD.SNK.E9. GetSinkCap in Place of Accept
Description:
As Provider, the Tester intentionally sends a GetSinkCap message in place of Accept message and verifies the UUT will send a SoftReset and recover from the error.
Steps:
a) Run PROC.PD.E1 Bring-up according to the UUT role.
b) The Tester cycles VBus.
c) The Tester sends a Source Capabilities message to the UUT.
d) Upon receipt of a Request message from the UUT, the Tester replies with a GoodCRC message.
e) The Tester sends a GetSinkCap message to the UUT.
f) If a SoftReset is not received within 15 ms after the GetSinkCap EOP was sent, the test fails.
g) If a SoftReset is received timely, the Tester replies with an Accept message.
h) The Tester sends Source Capabilities message to the UUT repeatedly until nCapsCount reached or a GoodCRC is received. If nCapsCount reached, the test fails.
i) If a Request is not received timely within 30 ms after the GoodCRC EOP corresponding to Source Capabilities message was received, the test fails.
Quoted 1 line
Signed-off-by Badhri Jagan Sridharan <[email protected]>
Quoted 18 lines
--- drivers/usb/typec/tcpm/tcpm.c | 1 + 1 file changed, 1 insertion(+)drivers/usb/typec/tcpm/tcpm.c +1
-0@@ -2243,6 +2243,7 @@ static void tcpm_pd_data_request(struct tcpm_port *port,* handled. */ port->ams =POWER_NEGOTIATION ; + port->in_ams = true;tcpm_set_state (port,SNK_NEGOTIATE_CAPABILITIES ,0 ); }else {if (port->ams ==GET_SOURCE_CAPABILITIES )Signature · 1 line
2.30.0.365.g02bc693789-goog
thanks,
Signature · 1 line
heikki