Skip to contentSkip to conversation

dt-bindings: iio: dac: Add missing ad5686 compatible strings

PATCH In review Rob Herring 3 participants 4 messages Feb 2, 2021 – Feb 6, 2021

Subsystems (3)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: iio: dac: Add missing ad5686 compatible strings

The example uses 'adi,ad5686', but the schema fails to document it. Given the filename and there is a similar part AD5686, let's just add the compatible strings including the 'r' variant.

Cc Lars-Peter Clausen <[email protected]>
Cc Michael Hennerich <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Peter Meerwald-Stadler <[email protected]>
Cc Michael Auchter <[email protected]>
---
 Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml +2 -0
index 8065228e5df8..190919291828 100644
@@ -19,6 +19,8 @@ properties:
       - adi,ad5338r
       - adi,ad5671r
       - adi,ad5675r
+      - adi,ad5686
+      - adi,ad5686r
       - adi,ad5691r
       - adi,ad5692r
       - adi,ad5693
Signature · 1 line
2.27.0
#1 lore raw
Quoted 3 lines · Rob Herring

The example uses 'adi,ad5686', but the schema fails to document it. Given the filename and there is a similar part AD5686, let's just add the compatible strings including the 'r' variant.

There are two variants of this chip. One with a SPI interface and one with a I2C interface. This binding document only describes the I2C variants. But the ad5686 is a SPI variant.

I think this is a typo and we should replace ad5686 with ad5696, including the document name.

Quoted 25 lines
Cc Lars-Peter Clausen <[email protected]>
Cc Michael Hennerich <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Peter Meerwald-Stadler <[email protected]>
Cc Michael Auchter <[email protected]>
---
  Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
  1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml +2 -0
index 8065228e5df8..190919291828 100644
@@ -19,6 +19,8 @@ properties:
        - adi,ad5338r
        - adi,ad5671r
        - adi,ad5675r
+      - adi,ad5686
+      - adi,ad5686r
        - adi,ad5691r
        - adi,ad5692r
        - adi,ad5693
author maintainer
#2 lore raw
Quoted 8 lines · Lars-Peter Clausen
Quoted 3 lines · Rob Herring

The example uses 'adi,ad5686', but the schema fails to document it. Given the filename and there is a similar part AD5686, let's just add the compatible strings including the 'r' variant.

There are two variants of this chip. One with a SPI interface and one with a I2C interface. This binding document only describes the I2C variants. But the ad5686 is a SPI variant.

Right, I should have noticed that.

Quoted 2 lines

I think this is a typo and we should replace ad5686 with ad5696, including the document name.

Though we do frequently document both I2C and SPI variants in the same binding, given there's no existing SPI support and the example is wrong I agree.

Quoted 27 lines
Quoted 25 lines
Cc Lars-Peter Clausen <[email protected]>
Cc Michael Hennerich <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Peter Meerwald-Stadler <[email protected]>
Cc Michael Auchter <[email protected]>
---
  Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
  1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml +2 -0
index 8065228e5df8..190919291828 100644
@@ -19,6 +19,8 @@ properties:
        - adi,ad5338r
        - adi,ad5671r
        - adi,ad5675r
+      - adi,ad5686
+      - adi,ad5686r
        - adi,ad5691r
        - adi,ad5692r
        - adi,ad5693
maintainer
#3 lore raw
Quoted 10 lines · On Tue, 2 Feb 2021 15:10:22 -0600 Rob Herring <[email protected]> wrote:
Quoted 8 lines · Lars-Peter Clausen
Quoted 3 lines · Rob Herring

The example uses 'adi,ad5686', but the schema fails to document it. Given the filename and there is a similar part AD5686, let's just add the compatible strings including the 'r' variant.

There are two variants of this chip. One with a SPI interface and one with a I2C interface. This binding document only describes the I2C variants. But the ad5686 is a SPI variant.

Quoted 8 lines

Right, I should have noticed that.

Quoted 2 lines

I think this is a typo and we should replace ad5686 with ad5696, including the document name.

Though we do frequently document both I2C and SPI variants in the same binding, given there's no existing SPI support and the example is wrong I agree.

Ah, this is what I get for reading my emails out of order.

There is existing SPI driver support if that's what you mean we just haven't documented the binding for it.

Should work via the fallbacks in SPI that drop the vendor id off then match on the rest. As I mentioned in reply to v2. It's an old driver so kind of got DT support by accident.

I'll play catch up at some stage soon on missing binding docs, (I suspect there are quite a few for older IIO drivers)

Thanks,

Jonathan

Quoted 28 lines
Quoted 28 lines
Quoted 26 lines
Cc Lars-Peter Clausen <[email protected]>
Cc Michael Hennerich <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Peter Meerwald-Stadler <[email protected]>
Cc Michael Auchter <[email protected]>
---
  Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
  1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml +2 -0
index 8065228e5df8..190919291828 100644
@@ -19,6 +19,8 @@ properties:
        - adi,ad5338r
        - adi,ad5671r
        - adi,ad5675r
+      - adi,ad5686
+      - adi,ad5686r
        - adi,ad5691r
        - adi,ad5692r
        - adi,ad5693