Skip to contentSkip to conversation

dt-bindings: Fix undocumented compatible strings in examples

PATCH In review Rob Herring 12 participants 20 messages Feb 2, 2021 – Feb 6, 2021

Subsystems (24)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/3 dt-bindings: Fix undocumented compatible strings in examples

Running 'dt-validate -m' will flag any compatible strings missing a schema. Fix all the errors found in DT binding examples. Most of these are just typos.

Cc Stephen Boyd <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Herbert Xu <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Daniel Palmer <[email protected]>
Cc Bartosz Golaszewski <[email protected]>
Cc Avi Fishman <[email protected]>
Cc Tomer Maimon <[email protected]>
Cc Tali Perry <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Will Deacon <[email protected]>
Cc Andrew Jeffery <[email protected]>
Cc Joel Stanley <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>
Cc Vincent Cheng <[email protected]>
---
 .../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml        | 2 +-
 Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml  | 4 ++--
 Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml        | 2 +-
 Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
 .../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml          | 2 +-
 .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml         | 2 +-
 .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml   | 2 +-
 .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml   | 2 +-
 .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml   | 2 +-
 Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml          | 4 +---
 Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml    | 4 ++--
 11 files changed, 13 insertions(+), 15 deletions(-)
Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml +1 -1
index fa0ee03a527f..53cc6df0df96 100644
@@ -18,7 +18,7 @@ properties:
     const: 1
 
   compatible:
-    const: allwinner,sun9i-a80-usb-clocks
+    const: allwinner,sun9i-a80-usb-clks
 
   reg:
     maxItems: 1
Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml +2 -2
index eb241587efd1..118c5543e037 100644
@@ -66,8 +66,8 @@ properties:
       - arm,syscon-icst525-integratorcp-cm-mem
       - arm,integrator-cm-auxosc
       - arm,versatile-cm-auxosc
-      - arm,impd-vco1
-      - arm,impd-vco2
+      - arm,impd1-vco1
+      - arm,impd1-vco2
 
   clocks:
     description: Parent clock for the ICST VCO
Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml +1 -1
index 1465c9ebaf93..1d48ac712b23 100644
@@ -66,7 +66,7 @@ examples:
     #include <dt-bindings/soc/ti,sci_pm_domain.h>
 
     main_crypto: crypto@4e00000 {
-        compatible = "ti,j721-sa2ul";
+        compatible = "ti,j721e-sa2ul";
         reg = <0x4e00000 0x1200>;
         power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
         dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml +1 -1
index 1f2ef408bb43..fe1e1c63ffe3 100644
@@ -46,7 +46,7 @@ examples:
     #include <dt-bindings/gpio/msc313-gpio.h>
 
     gpio: gpio@207800 {
-      compatible = "mstar,msc313e-gpio";
+      compatible = "mstar,msc313-gpio";
       #gpio-cells = <2>;
       reg = <0x207800 0x200>;
       gpio-controller;
Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml +1 -1
index e3ef2d36f372..128444942aec 100644
@@ -17,7 +17,7 @@ maintainers:
 
 properties:
   compatible:
-    const: nuvoton,npcm7xx-i2c
+    const: nuvoton,npcm750-i2c
 
   reg:
     maxItems: 1
Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml +1 -1
index cde1afa8dfd6..349633108bbd 100644
@@ -93,7 +93,7 @@ examples:
     #include <dt-bindings/power/r8a7791-sysc.h>
 
     ipmmu_mx: iommu@fe951000 {
-        compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
+        compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
         reg = <0xfe951000 0x1000>;
         interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml +1 -1
index 54631dc1adb0..5dbb84049ff6 100644
@@ -63,7 +63,7 @@ examples:
         reg = <0x1e6e2000 0x1a8>;
 
         pinctrl: pinctrl {
-            compatible = "aspeed,g4-pinctrl";
+            compatible = "aspeed,ast2400-pinctrl";
 
             pinctrl_i2c3_default: i2c3_default {
                 function = "I2C3";
Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml +1 -1
index a90c0fe0495f..ad1c33364b38 100644
@@ -81,7 +81,7 @@ examples:
             reg = <0x1e6e2000 0x1a8>;
 
             pinctrl: pinctrl {
-                compatible = "aspeed,g5-pinctrl";
+                compatible = "aspeed,ast2500-pinctrl";
                 aspeed,external-nodes = <&gfx>, <&lhc>;
 
                 pinctrl_i2c3_default: i2c3_default {
Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml +1 -1
index c78ab7e2eee7..ad91c0bc54da 100644
@@ -95,7 +95,7 @@ examples:
         reg = <0x1e6e2000 0xf6c>;
 
         pinctrl: pinctrl {
-            compatible = "aspeed,g6-pinctrl";
+            compatible = "aspeed,ast2600-pinctrl";
 
             pinctrl_pwm10g1_default: pwm10g1_default {
                 function = "PWM10";
Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml +1 -3
index 239b49fad805..658cec67743e 100644
@@ -59,9 +59,7 @@ additionalProperties: false
 
 examples:
   - |
-    i2c@1 {
-        compatible = "abc,acme-1234";
-        reg = <0x01 0x400>;
+    i2c {
         #address-cells = <1>;
         #size-cells = <0>;
         phc@5b {
Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml +2 -2
index c1348db59374..054584d7543a 100644
@@ -57,8 +57,8 @@ examples:
      */
     #include <dt-bindings/soc/ti,sci_pm_domain.h>
 
-    watchdog0: rti@2200000 {
-        compatible = "ti,rti-wdt";
+    watchdog@2200000 {
+        compatible = "ti,j7-rti-wdt";
         reg = <0x2200000 0x100>;
         clocks = <&k3_clks 252 1>;
         power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
Signature · 6 lines
2.27.0

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
author maintainer
#1 lore raw

PATCH 2/3 dt-bindings: iommu: renesas,ipmmu-vmsa: Make 'power-domains' conditionally required

Fixing the compatible string typos results in an error in the example:

Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.example.dt.yaml:
iommu@fe951000: 'power-domains' is a required property

Based on the dts files, a 'power-domains' property only exists on Gen 3 which can be conditioned on !renesas,ipmmu-vmsa.

Cc Joerg Roedel <[email protected]>
Cc Will Deacon <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>
---
 .../bindings/iommu/renesas,ipmmu-vmsa.yaml           | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml +11 -1
index 349633108bbd..dda44976acc1 100644
@@ -76,7 +76,6 @@ required:
   - compatible
   - reg
   - '#iommu-cells'
-  - power-domains
 
 oneOf:
   - required:
@@ -86,6 +85,17 @@ oneOf:
 
 additionalProperties: false
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              const: renesas,ipmmu-vmsa
+    then:
+      required:
+        - power-domains
+
 examples:
   - |
     #include <dt-bindings/clock/r8a7791-cpg-mssr.h>
Signature · 6 lines
2.27.0

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
author maintainer
#3 lore raw

PATCH 3/3 dt-bindings: Fix errors in 'if' schemas

In reply to Rob Herring

Properties in if/then schemas weren't getting checked by the meta-schemas. Enabling meta-schema checks finds several errors.

The use of an 'items' schema (as opposed to the list form) is wrong in some cases as it applies to all entries. 'contains' is the correct schema to use in the case of multiple entries.

Cc Herbert Xu <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc Eric Anholt <[email protected]>
Cc Nicolas Saenz Julienne <[email protected]>
Cc Florian Fainelli <[email protected]>
Cc Ray Jui <[email protected]>
Cc Scott Branden <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Ulf Hansson <[email protected]>
Cc Kishon Vijay Abraham I <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Daniel Lezcano <[email protected]>
---
 .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml   | 3 +--
 .../devicetree/bindings/display/brcm,bcm2835-hvs.yaml    | 2 +-
 Documentation/devicetree/bindings/leds/ti,tca6507.yaml   | 1 +
 Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml  | 2 +-
 Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml | 3 +--
 .../devicetree/bindings/phy/renesas,usb2-phy.yaml        | 5 ++---
 .../devicetree/bindings/pinctrl/renesas,pfc.yaml         | 9 ++++-----
 .../bindings/timer/allwinner,sun5i-a13-hstimer.yaml      | 3 +--
 8 files changed, 12 insertions(+), 16 deletions(-)
Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml +1 -2
index 7a60d84289cc..6ab07eba7778 100644
@@ -46,8 +46,7 @@ properties:
 if:
   properties:
     compatible:
-      items:
-        const: allwinner,sun50i-h6-crypto
+      const: allwinner,sun50i-h6-crypto
 then:
   properties:
     clocks:
Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml +1 -1
index e826ab0adb75..2e8566f47e63 100644
@@ -36,7 +36,7 @@ if:
   properties:
     compatible:
       contains:
-        const: brcm,bcm2711-hvs"
+        const: brcm,bcm2711-hvs
 
 then:
   required:
Documentation/devicetree/bindings/leds/ti,tca6507.yaml +1 -0
index 94c307c98762..32c600387895 100644
@@ -69,6 +69,7 @@ patternProperties:
 if:
   patternProperties:
     "^gpio@[0-6]$":
+      type: object
       properties:
         compatible:
           contains:
Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml +1 -1
index 6bbf29b5c239..6c13703b31db 100644
@@ -123,7 +123,7 @@ required:
 if:
   properties:
     compatible:
-      items:
+      contains:
         enum:
           - renesas,sdhi-r7s72100
           - renesas,sdhi-r7s9210
Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml +1 -2
index 58c3ef8004ad..04edda504ab6 100644
@@ -99,8 +99,7 @@ patternProperties:
 if:
   properties:
     compatible:
-      items:
-        const: brcm,iproc-ns2-sata-phy
+      const: brcm,iproc-ns2-sata-phy
 then:
   properties:
     reg:
Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml +2 -3
index 829e8c7e467a..0f358d5b84ef 100644
@@ -81,9 +81,8 @@ properties:
 if:
   properties:
     compatible:
-      items:
-        enum:
-          - renesas,usb2-phy-r7s9210
+      contains:
+        const: renesas,usb2-phy-r7s9210
 then:
   required:
     - clock-names
Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml +4 -5
index 5b5b1b9d2ec7..5d3947902f2d 100644
@@ -76,11 +76,10 @@ required:
 if:
   properties:
     compatible:
-      items:
-        enum:
-          - renesas,pfc-r8a73a4
-          - renesas,pfc-r8a7740
-          - renesas,pfc-sh73a0
+      enum:
+        - renesas,pfc-r8a73a4
+        - renesas,pfc-r8a7740
+        - renesas,pfc-sh73a0
 then:
   required:
     - interrupts-extended
Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml +1 -2
index 40fc4bcb3145..b6a6d03a08b2 100644
@@ -46,8 +46,7 @@ required:
 if:
   properties:
     compatible:
-      items:
-        const: allwinner,sun5i-a13-hstimer
+      const: allwinner,sun5i-a13-hstimer
 
 then:
   properties:
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer Reviewed-by on v1 1/3
#10 lore raw
In reply to Rob Herring
Quoted 21 lines · Rob Herring

Running 'dt-validate -m' will flag any compatible strings missing a schema. Fix all the errors found in DT binding examples. Most of these are just typos.

Cc Stephen Boyd <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Herbert Xu <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Daniel Palmer <[email protected]>
Cc Bartosz Golaszewski <[email protected]>
Cc Avi Fishman <[email protected]>
Cc Tomer Maimon <[email protected]>
Cc Tali Perry <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Will Deacon <[email protected]>
Cc Andrew Jeffery <[email protected]>
Cc Joel Stanley <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Quoted 8 lines
Quoted 155 lines
---
 .../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml        | 2 +-
 Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml  | 4 ++--
 Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml        | 2 +-
 Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
 .../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml          | 2 +-
 .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml         | 2 +-
 .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml   | 2 +-
 .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml   | 2 +-
 .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml   | 2 +-
 Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml          | 4 +---
 Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml    | 4 ++--
 11 files changed, 13 insertions(+), 15 deletions(-)
Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml +1 -1
index fa0ee03a527f..53cc6df0df96 100644
@@ -18,7 +18,7 @@ properties:
     const: 1
 
   compatible:
-    const: allwinner,sun9i-a80-usb-clocks
+    const: allwinner,sun9i-a80-usb-clks
 
   reg:
     maxItems: 1
Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml +2 -2
index eb241587efd1..118c5543e037 100644
@@ -66,8 +66,8 @@ properties:
       - arm,syscon-icst525-integratorcp-cm-mem
       - arm,integrator-cm-auxosc
       - arm,versatile-cm-auxosc
-      - arm,impd-vco1
-      - arm,impd-vco2
+      - arm,impd1-vco1
+      - arm,impd1-vco2
 
   clocks:
     description: Parent clock for the ICST VCO
Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml +1 -1
index 1465c9ebaf93..1d48ac712b23 100644
@@ -66,7 +66,7 @@ examples:
     #include <dt-bindings/soc/ti,sci_pm_domain.h>
 
     main_crypto: crypto@4e00000 {
-        compatible = "ti,j721-sa2ul";
+        compatible = "ti,j721e-sa2ul";
         reg = <0x4e00000 0x1200>;
         power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
         dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml +1 -1
index 1f2ef408bb43..fe1e1c63ffe3 100644
@@ -46,7 +46,7 @@ examples:
     #include <dt-bindings/gpio/msc313-gpio.h>
 
     gpio: gpio@207800 {
-      compatible = "mstar,msc313e-gpio";
+      compatible = "mstar,msc313-gpio";
       #gpio-cells = <2>;
       reg = <0x207800 0x200>;
       gpio-controller;
Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml +1 -1
index e3ef2d36f372..128444942aec 100644
@@ -17,7 +17,7 @@ maintainers:
 
 properties:
   compatible:
-    const: nuvoton,npcm7xx-i2c
+    const: nuvoton,npcm750-i2c
 
   reg:
     maxItems: 1
Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml +1 -1
index cde1afa8dfd6..349633108bbd 100644
@@ -93,7 +93,7 @@ examples:
     #include <dt-bindings/power/r8a7791-sysc.h>
 
     ipmmu_mx: iommu@fe951000 {
-        compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
+        compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
         reg = <0xfe951000 0x1000>;
         interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml +1 -1
index 54631dc1adb0..5dbb84049ff6 100644
@@ -63,7 +63,7 @@ examples:
         reg = <0x1e6e2000 0x1a8>;
 
         pinctrl: pinctrl {
-            compatible = "aspeed,g4-pinctrl";
+            compatible = "aspeed,ast2400-pinctrl";
 
             pinctrl_i2c3_default: i2c3_default {
                 function = "I2C3";
Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml +1 -1
index a90c0fe0495f..ad1c33364b38 100644
@@ -81,7 +81,7 @@ examples:
             reg = <0x1e6e2000 0x1a8>;
 
             pinctrl: pinctrl {
-                compatible = "aspeed,g5-pinctrl";
+                compatible = "aspeed,ast2500-pinctrl";
                 aspeed,external-nodes = <&gfx>, <&lhc>;
 
                 pinctrl_i2c3_default: i2c3_default {
Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml +1 -1
index c78ab7e2eee7..ad91c0bc54da 100644
@@ -95,7 +95,7 @@ examples:
         reg = <0x1e6e2000 0xf6c>;
 
         pinctrl: pinctrl {
-            compatible = "aspeed,g6-pinctrl";
+            compatible = "aspeed,ast2600-pinctrl";
 
             pinctrl_pwm10g1_default: pwm10g1_default {
                 function = "PWM10";
Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml +1 -3
index 239b49fad805..658cec67743e 100644
@@ -59,9 +59,7 @@ additionalProperties: false
 
 examples:
   - |
-    i2c@1 {
-        compatible = "abc,acme-1234";
-        reg = <0x01 0x400>;
+    i2c {
         #address-cells = <1>;
         #size-cells = <0>;
         phc@5b {
Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml +0 -0
index c1348db59374..054584d7543a 100644

Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml examples: · line 64

Quoted 10 lines
Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml +2 -2
@@ -57,8 +57,8 @@ examples:
      */
     #include <dt-bindings/soc/ti,sci_pm_domain.h>
 
-    watchdog0: rti@2200000 {
-        compatible = "ti,rti-wdt";
+    watchdog@2200000 {
+        compatible = "ti,j7-rti-wdt";
         reg = <0x2200000 0x100>;
         clocks = <&k3_clks 252 1>;
         power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reviewed-by on v1 1/3
#11 lore raw
In reply to Rob Herring
Quoted 179 lines · Rob Herring

Running 'dt-validate -m' will flag any compatible strings missing a schema. Fix all the errors found in DT binding examples. Most of these are just typos.

Cc Stephen Boyd <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Herbert Xu <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Daniel Palmer <[email protected]>
Cc Bartosz Golaszewski <[email protected]>
Cc Avi Fishman <[email protected]>
Cc Tomer Maimon <[email protected]>
Cc Tali Perry <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Will Deacon <[email protected]>
Cc Andrew Jeffery <[email protected]>
Cc Joel Stanley <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>
Cc Vincent Cheng <[email protected]>
---
 .../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml        | 2 +-
 Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml  | 4 ++--
 Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml        | 2 +-
 Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
 .../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml          | 2 +-
 .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml         | 2 +-
 .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml   | 2 +-
 .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml   | 2 +-
 .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml   | 2 +-
 Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml          | 4 +---
 Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml    | 4 ++--
 11 files changed, 13 insertions(+), 15 deletions(-)
(quoted diff) +0 -0

a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml index fa0ee03a527f..53cc6df0df96 100644
---
a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
+++
b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml

Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml +1 -1
@@ -18,7 +18,7 @@ properties:
     const: 1
 
   compatible:
-    const: allwinner,sun9i-a80-usb-clocks
+    const: allwinner,sun9i-a80-usb-clks
 
   reg:
     maxItems: 1
(quoted diff) +0 -0

a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml index eb241587efd1..118c5543e037 100644

Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml +2 -2
@@ -66,8 +66,8 @@ properties:
       - arm,syscon-icst525-integratorcp-cm-mem
       - arm,integrator-cm-auxosc
       - arm,versatile-cm-auxosc
-      - arm,impd-vco1
-      - arm,impd-vco2
+      - arm,impd1-vco1
+      - arm,impd1-vco2
 
   clocks:
     description: Parent clock for the ICST VCO
Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml +1 -1
index 1465c9ebaf93..1d48ac712b23 100644
@@ -66,7 +66,7 @@ examples:
     #include <dt-bindings/soc/ti,sci_pm_domain.h>
 
     main_crypto: crypto@4e00000 {
-        compatible = "ti,j721-sa2ul";
+        compatible = "ti,j721e-sa2ul";
         reg = <0x4e00000 0x1200>;
         power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
         dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
(quoted diff) +0 -0

a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml index 1f2ef408bb43..fe1e1c63ffe3 100644

Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml +1 -1
@@ -46,7 +46,7 @@ examples:
     #include <dt-bindings/gpio/msc313-gpio.h>
 
     gpio: gpio@207800 {
-      compatible = "mstar,msc313e-gpio";
+      compatible = "mstar,msc313-gpio";
       #gpio-cells = <2>;
       reg = <0x207800 0x200>;
       gpio-controller;
(quoted diff) +0 -0

a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml index e3ef2d36f372..128444942aec 100644

Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml +1 -1
@@ -17,7 +17,7 @@ maintainers:
 
 properties:
   compatible:
-    const: nuvoton,npcm7xx-i2c
+    const: nuvoton,npcm750-i2c
 
   reg:
     maxItems: 1
(quoted diff) +0 -0

a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml index cde1afa8dfd6..349633108bbd 100644

Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml +1 -1
@@ -93,7 +93,7 @@ examples:
     #include <dt-bindings/power/r8a7791-sysc.h>
 
     ipmmu_mx: iommu@fe951000 {
-        compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
+        compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
         reg = <0xfe951000 0x1000>;
         interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
(quoted diff) +0 -0

a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml index 54631dc1adb0..5dbb84049ff6 100644
---
a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
+++
b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml

Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml +1 -1
@@ -63,7 +63,7 @@ examples:
         reg = <0x1e6e2000 0x1a8>;
 
         pinctrl: pinctrl {
-            compatible = "aspeed,g4-pinctrl";
+            compatible = "aspeed,ast2400-pinctrl";
 
             pinctrl_i2c3_default: i2c3_default {
                 function = "I2C3";
(quoted diff) +0 -0

a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml index a90c0fe0495f..ad1c33364b38 100644
---
a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
+++
b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml

Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml +1 -1
@@ -81,7 +81,7 @@ examples:
             reg = <0x1e6e2000 0x1a8>;
 
             pinctrl: pinctrl {
-                compatible = "aspeed,g5-pinctrl";
+                compatible = "aspeed,ast2500-pinctrl";
                 aspeed,external-nodes = <&gfx>, <&lhc>;
 
                 pinctrl_i2c3_default: i2c3_default {
(quoted diff) +0 -0

a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml index c78ab7e2eee7..ad91c0bc54da 100644
---
a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
+++
b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml

Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml examples: · line 98

Quoted 5 lines
Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml +1 -1
@@ -95,7 +95,7 @@ examples:
         reg = <0x1e6e2000 0xf6c>;
 
         pinctrl: pinctrl {
-            compatible = "aspeed,g6-pinctrl";
+            compatible = "aspeed,ast2600-pinctrl";

Ah, thanks. For the Aspeed changes:

maintainer
#12 lore raw
In reply to Rob Herring

Quoting Rob Herring (2021-02-02 12:55:42)

Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml properties: · line 21

Quoted 11 lines
Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml +1 -1
index fa0ee03a527f..53cc6df0df96 100644
@@ -18,7 +18,7 @@ properties:
     const: 1
 
   compatible:
-    const: allwinner,sun9i-a80-usb-clocks
+    const: allwinner,sun9i-a80-usb-clks

Should the file name change too?

Quoted 8 lines
Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml +0 -0
   reg:
     maxItems: 1
Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml +0 -0
index eb241587efd1..118c5543e037 100644

Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml properties: · line 73

Quoted 10 lines
Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml +2 -2
@@ -66,8 +66,8 @@ properties:
       - arm,syscon-icst525-integratorcp-cm-mem
       - arm,integrator-cm-auxosc
       - arm,versatile-cm-auxosc
-      - arm,impd-vco1
-      - arm,impd-vco2
+      - arm,impd1-vco1
+      - arm,impd1-vco2
 
   clocks:
     description: Parent clock for the ICST VCO

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

#4 lore raw

Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

In reply to Rob Herring

Hi Rob,

Quoted 8 lines · Rob Herring

Properties in if/then schemas weren't getting checked by the meta-schemas. Enabling meta-schema checks finds several errors.

The use of an 'items' schema (as opposed to the list form) is wrong in some cases as it applies to all entries. 'contains' is the correct schema to use in the case of multiple entries.

Thanks for your patch!

Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml properties: · line 85

Quoted 11 lines
Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml +2 -3
@@ -81,9 +81,8 @@ properties:
 if:
   properties:
     compatible:
-      items:
-        enum:
-          - renesas,usb2-phy-r7s9210
+      contains:
+        const: renesas,usb2-phy-r7s9210

Single entry, so "contains" not needed?

Quoted 5 lines
Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml +0 -0
@@ -76,11 +76,10 @@ required:
 if:
   properties:

Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml required: · line 82

Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml +4 -5
     compatible:
-      items:
-        enum:
-          - renesas,pfc-r8a73a4
-          - renesas,pfc-r8a7740
-          - renesas,pfc-sh73a0
+      enum:
+        - renesas,pfc-r8a73a4
+        - renesas,pfc-r8a7740
+        - renesas,pfc-sh73a0

Missing "contains"?

Gr{oetje,eeting}s,

Geert

Signature · 9 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by
#13 lore raw
In reply to Stephen Boyd
Quoted 9 lines · Stephen Boyd

Quoting Rob Herring (2021-02-02 12:55:42)

Quoted 8 lines
Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml +0 -0
index fa0ee03a527f..53cc6df0df96 100644
@@ -18,7 +18,7 @@ properties:
     const: 1
 
Quoted 5 lines

Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml properties: · line 21

Quoted 3 lines
Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml +1 -1
   compatible:
-    const: allwinner,sun9i-a80-usb-clocks
+    const: allwinner,sun9i-a80-usb-clks

Should the file name change too?

Ideally yes, and with that change

Maxime

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Acked-by on v1 3/3
#7 lore raw

Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

In reply to Rob Herring
Quoted 21 lines · Rob Herring

Properties in if/then schemas weren't getting checked by the meta-schemas. Enabling meta-schema checks finds several errors.

The use of an 'items' schema (as opposed to the list form) is wrong in some cases as it applies to all entries. 'contains' is the correct schema to use in the case of multiple entries.

Cc Herbert Xu <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc Eric Anholt <[email protected]>
Cc Nicolas Saenz Julienne <[email protected]>
Cc Florian Fainelli <[email protected]>
Cc Ray Jui <[email protected]>
Cc Scott Branden <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Ulf Hansson <[email protected]>
Cc Kishon Vijay Abraham I <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Quoted 8 lines

Maxime

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reviewed-by on v1 1/3
#15 lore raw
In reply to Rob Herring
Quoted 22 lines · Rob Herring

Running 'dt-validate -m' will flag any compatible strings missing a schema. Fix all the errors found in DT binding examples. Most of these are just typos.

Cc Stephen Boyd <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Herbert Xu <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Daniel Palmer <[email protected]>
Cc Bartosz Golaszewski <[email protected]>
Cc Avi Fishman <[email protected]>
Cc Tomer Maimon <[email protected]>
Cc Tali Perry <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Will Deacon <[email protected]>
Cc Andrew Jeffery <[email protected]>
Cc Joel Stanley <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>
Quoted 8 lines

Ooops.

Yours,
Linus Walleij
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reviewed-by on v1 1/3
#16 lore raw
In reply to Rob Herring

Hi Rob,

Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml examples: · line 52

Quoted 13 lines · Rob Herring
Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml +1 -1
index 1f2ef408bb43..fe1e1c63ffe3 100644
@@ -46,7 +46,7 @@ examples:
     #include <dt-bindings/gpio/msc313-gpio.h>
 
     gpio: gpio@207800 {
-      compatible = "mstar,msc313e-gpio";
+      compatible = "mstar,msc313-gpio";
       #gpio-cells = <2>;
       reg = <0x207800 0x200>;
       gpio-controller;

This is correct. The compatible string dropped the e at some point and I must have missed the example.
Thanks for the fix.

maintainer Acked-by on v1 3/3
#8 lore raw

Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

In reply to Rob Herring
Quoted 29 lines · Rob Herring

Properties in if/then schemas weren't getting checked by the meta-schemas. Enabling meta-schema checks finds several errors.

The use of an 'items' schema (as opposed to the list form) is wrong in some cases as it applies to all entries. 'contains' is the correct schema to use in the case of multiple entries.

Cc Herbert Xu <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc Eric Anholt <[email protected]>
Cc Nicolas Saenz Julienne <[email protected]>
Cc Florian Fainelli <[email protected]>
Cc Ray Jui <[email protected]>
Cc Scott Branden <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Ulf Hansson <[email protected]>
Cc Kishon Vijay Abraham I <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Daniel Lezcano <[email protected]>
Quoted 7 lines
---
 .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml   | 3 +--
 .../devicetree/bindings/display/brcm,bcm2835-hvs.yaml    | 2 +-
 Documentation/devicetree/bindings/leds/ti,tca6507.yaml   | 1 +
 Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml  | 2 +-
 Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml | 3 +--
 .../devicetree/bindings/phy/renesas,usb2-phy.yaml        | 5 ++---

For phy:

Signature · 5 lines
~Vinod
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 3/3
#9 lore raw

Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

In reply to Rob Herring
Quoted 29 lines · Rob Herring

Properties in if/then schemas weren't getting checked by the meta-schemas. Enabling meta-schema checks finds several errors.

The use of an 'items' schema (as opposed to the list form) is wrong in some cases as it applies to all entries. 'contains' is the correct schema to use in the case of multiple entries.

Cc Herbert Xu <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc Eric Anholt <[email protected]>
Cc Nicolas Saenz Julienne <[email protected]>
Cc Florian Fainelli <[email protected]>
Cc Ray Jui <[email protected]>
Cc Scott Branden <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Ulf Hansson <[email protected]>
Cc Kishon Vijay Abraham I <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Daniel Lezcano <[email protected]>
Quoted 1 line

---

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

author maintainer
#5 lore raw

Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

In reply to Geert Uytterhoeven
Quoted 14 lines · Geert Uytterhoeven

Hi Rob,

Quoted 8 lines · Rob Herring

Properties in if/then schemas weren't getting checked by the meta-schemas. Enabling meta-schema checks finds several errors.

The use of an 'items' schema (as opposed to the list form) is wrong in some cases as it applies to all entries. 'contains' is the correct schema to use in the case of multiple entries.

Thanks for your patch!

Quoted 13 lines

Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml properties: · line 85

Quoted 11 lines
Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml +2 -3
@@ -81,9 +81,8 @@ properties:
 if:
   properties:
     compatible:
-      items:
-        enum:
-          - renesas,usb2-phy-r7s9210
+      contains:
+        const: renesas,usb2-phy-r7s9210

Single entry, so "contains" not needed?

No, you are misunderstanding how these work. 'contains' means at least one entry in an array passes with the subschema. In this case, 'renesas,usb2-phy-r7s9210' must appear somewhere in the 'compatible' values. (Before, it said *every* entry must be 'renesas,usb2-phy-r7s9210'.) As there is a fallback compatible, we need 'contains'.

Quoted 9 lines
Quoted 9 lines
Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml +0 -3
@@ -76,11 +76,10 @@ required:
 if:
   properties:
     compatible:
-      items:
-        enum:
-          - renesas,pfc-r8a73a4
Quoted 8 lines

Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml required: · line 82

Quoted 6 lines
Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml +4 -2
-          - renesas,pfc-r8a7740
-          - renesas,pfc-sh73a0
+      enum:
+        - renesas,pfc-r8a73a4
+        - renesas,pfc-r8a7740
+        - renesas,pfc-sh73a0

Missing "contains"?

No. In this case, 'compatible' is always a single entry, so no 'contains' needed (but would work). If compatible is one of these 3 strings, then the 'if' is true.

The original way would actually work in this case (i.e. is valid json-schema), but we require 'items' to have a size (maxItems/minItems) in our meta-schema.

Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#6 lore raw

Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

Hi Rob,

Quoted 52 lines · Rob Herring
Quoted 12 lines · Geert Uytterhoeven
Quoted 8 lines · Rob Herring

Properties in if/then schemas weren't getting checked by the meta-schemas. Enabling meta-schema checks finds several errors.

The use of an 'items' schema (as opposed to the list form) is wrong in some cases as it applies to all entries. 'contains' is the correct schema to use in the case of multiple entries.

Thanks for your patch!

Quoted 13 lines

Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml properties: · line 85

Quoted 11 lines
Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml +2 -3
@@ -81,9 +81,8 @@ properties:
 if:
   properties:
     compatible:
-      items:
-        enum:
-          - renesas,usb2-phy-r7s9210
+      contains:
+        const: renesas,usb2-phy-r7s9210

Single entry, so "contains" not needed?

No, you are misunderstanding how these work. 'contains' means at least one entry in an array passes with the subschema. In this case, 'renesas,usb2-phy-r7s9210' must appear somewhere in the 'compatible' values. (Before, it said *every* entry must be 'renesas,usb2-phy-r7s9210'.) As there is a fallback compatible, we need 'contains'.

Quoted 9 lines
Quoted 9 lines
Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml +0 -3
@@ -76,11 +76,10 @@ required:
 if:
   properties:
     compatible:
-      items:
-        enum:
-          - renesas,pfc-r8a73a4
Quoted 8 lines

Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml required: · line 82

Quoted 6 lines
Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml +4 -2
-          - renesas,pfc-r8a7740
-          - renesas,pfc-sh73a0
+      enum:
+        - renesas,pfc-r8a73a4
+        - renesas,pfc-r8a7740
+        - renesas,pfc-sh73a0

Missing "contains"?

Quoted 7 lines

No. In this case, 'compatible' is always a single entry, so no 'contains' needed (but would work). If compatible is one of these 3 strings, then the 'if' is true.

The original way would actually work in this case (i.e. is valid json-schema), but we require 'items' to have a size (maxItems/minItems) in our meta-schema.

Thanks for the explanation!

Gr{oetje,eeting}s,

Geert

Signature · 9 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
author maintainer
#14 lore raw
In reply to Stephen Boyd
Quoted 9 lines · Stephen Boyd

Quoting Rob Herring (2021-02-02 12:55:42)

Quoted 8 lines
Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml +0 -0
index fa0ee03a527f..53cc6df0df96 100644
@@ -18,7 +18,7 @@ properties:
     const: 1
 
Quoted 5 lines

Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml properties: · line 21

Quoted 3 lines
Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml +1 -1
   compatible:
-    const: allwinner,sun9i-a80-usb-clocks
+    const: allwinner,sun9i-a80-usb-clks

Should the file name change too?

Yes, I'll fix that while applying.

Rob
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reviewed-by on v1 1/3
#17 lore raw
In reply to Rob Herring

Hi Rob,

Quoted 32 lines

From: Rob Herring, Sent: Wednesday, February 3, 2021 5:56 AM

Running 'dt-validate -m' will flag any compatible strings missing a schema. Fix all the errors found in DT binding examples. Most of these are just typos.

Cc Stephen Boyd <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Herbert Xu <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Daniel Palmer <[email protected]>
Cc Bartosz Golaszewski <[email protected]>
Cc Avi Fishman <[email protected]>
Cc Tomer Maimon <[email protected]>
Cc Tali Perry <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Will Deacon <[email protected]>
Cc Andrew Jeffery <[email protected]>
Cc Joel Stanley <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>
Cc Vincent Cheng <[email protected]>

<snip>

Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml examples: · line 96

Quoted 11 lines
Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml +1 -1
index cde1afa8dfd6..349633108bbd 100644
@@ -93,7 +93,7 @@ examples:
     #include <dt-bindings/power/r8a7791-sysc.h>
 
     ipmmu_mx: iommu@fe951000 {
-        compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
+        compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";

Oops. Thank you for fixing this.

Best regards,
Yoshihiro Shimoda

Reviewed-by on v1 2/3
#2 lore raw

RE: [PATCH 2/3] dt-bindings: iommu: renesas,ipmmu-vmsa: Make 'power-domains' conditionally required

In reply to Rob Herring

Hi Rob,

Quoted 7 lines

From: Rob Herring, Sent: Wednesday, February 3, 2021 5:56 AM

Fixing the compatible string typos results in an error in the example:

Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.example.dt.yaml:
iommu@fe951000: 'power-domains' is a required property

Quoted 8 lines

Based on the dts files, a 'power-domains' property only exists on Gen 3 which can be conditioned on !renesas,ipmmu-vmsa.

Cc Joerg Roedel <[email protected]>
Cc Will Deacon <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>

Thank you for the patch!

Best regards,
Yoshihiro Shimoda

Acked-by on v1 1/3
#18 lore raw
In reply to Rob Herring
Quoted 22 lines · Rob Herring

Running 'dt-validate -m' will flag any compatible strings missing a schema. Fix all the errors found in DT binding examples. Most of these are just typos.

Cc Stephen Boyd <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Herbert Xu <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Daniel Palmer <[email protected]>
Cc Bartosz Golaszewski <[email protected]>
Cc Avi Fishman <[email protected]>
Cc Tomer Maimon <[email protected]>
Cc Tali Perry <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Will Deacon <[email protected]>
Cc Andrew Jeffery <[email protected]>
Cc Joel Stanley <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>
Quoted 8 lines

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

maintainer Acked-by on v1 1/3
#19 lore raw
In reply to Rob Herring

Quoting Rob Herring (2021-02-02 12:55:42)

Quoted 30 lines

Running 'dt-validate -m' will flag any compatible strings missing a schema. Fix all the errors found in DT binding examples. Most of these are just typos.

Cc Stephen Boyd <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Herbert Xu <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Daniel Palmer <[email protected]>
Cc Bartosz Golaszewski <[email protected]>
Cc Avi Fishman <[email protected]>
Cc Tomer Maimon <[email protected]>
Cc Tali Perry <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Will Deacon <[email protected]>
Cc Andrew Jeffery <[email protected]>
Cc Joel Stanley <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>
Cc Vincent Cheng <[email protected]>
Quoted 1 line

---

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu