dt-bindings: iio: dac: Fix AD5686 references
Subsystems (3)
Rob Herring
maintainerPATCH v2 1/1 dt-bindings: iio: dac: Fix AD5686 references
The example and filename use 'adi,ad5686', but the schema doesn't document it. The AD5686 is also a SPI interface variant while all the documented variants have an I2C interface. So let's update all the references to AD5686 to AD5696.
---
v2:
- Rename instead of adding AD5686
.../iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
rename Documentation/devicetree/bindings/iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} (77%)Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml renamed from Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml +5 -5
@@ -1,16 +1,16 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml# +$id: http://devicetree.org/schemas/iio/dac/adi,ad5696.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Analog Devices AD5686 and similar multi-channel DACs +title: Analog Devices AD5696 and similar multi-channel DACs maintainers: - Michael Auchter <[email protected]> description: | - Binding for Analog Devices AD5686 and similar multi-channel DACs + Binding for Analog Devices AD5696 and similar multi-channel DACs properties: compatible:
@@ -48,8 +48,8 @@ examples: #address-cells = <1>; #size-cells = <0>; - ad5686: dac@0 { - compatible = "adi,ad5686"; + ad5696: dac@0 { + compatible = "adi,ad5696"; reg = <0>; vcc-supply = <&dac_vref>; };
Signature · 1 line
2.27.0
Quoted 5 lines · Rob Herring
The example and filename use 'adi,ad5686', but the schema doesn't document it. The AD5686 is also a SPI interface variant while all the documented variants have an I2C interface. So let's update all the references to AD5686 to AD5696.
Quoted 7 lines
Cc Lars-Peter Clausen <[email protected]>Cc Michael Hennerich <[email protected]>Cc Jonathan Cameron <[email protected]>Cc Peter Meerwald-Stadler <[email protected]>Cc Michael Auchter <[email protected]>Signed-off-by Rob Herring <[email protected]>
Thanks Rob.
Quoted 46 lines
---
v2:
- Rename instead of adding AD5686.../iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)rename
Documentation/devicetree/bindings/iio/dac/{adi,ad5686.yaml=> adi,ad5696.yaml} (77%)Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml renamed from Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml +5
-5@@ -1,16 +1,16 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml# +$id: http://devicetree.org/schemas/iio/dac/adi,ad5696.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Analog Devices AD5686 and similar multi-channel DACs +title: Analog Devices AD5696 and similar multi-channel DACs maintainers: - Michael Auchter <[email protected]> description: | - Binding for Analog Devices AD5686 and similar multi-channel DACs + Binding for Analog Devices AD5696 and similar multi-channel DACs properties: compatible:@@ -48,8 +48,8 @@ examples: #address-cells = <1>; #size-cells = <0>; - ad5686: dac@0 { - compatible = "adi,ad5686"; + ad5696: dac@0 { + compatible = "adi,ad5696"; reg = <0>; vcc-supply = <&dac_vref>; };
Quoted 14 lines · On Tue, 2 Feb 2021 22:56:21 +0100 Lars-Peter Clausen <[email protected]> wrote:
Quoted 5 lines · Rob Herring
The example and filename use 'adi,ad5686', but the schema doesn't document it. The AD5686 is also a SPI interface variant while all the documented variants have an I2C interface. So let's update all the references to AD5686 to AD5696.
Quoted 7 lines
Cc Lars-Peter Clausen <[email protected]>Cc Michael Hennerich <[email protected]>Cc Jonathan Cameron <[email protected]>Cc Peter Meerwald-Stadler <[email protected]>Cc Michael Auchter <[email protected]>Signed-off-by Rob Herring <[email protected]>
Quoted 4 lines
Thanks Rob.
Hi Rob,
So what seems to have happened here is only the i2c parts of a dual bus driver got documented. That happened as part of a series adding a new part to the driver a while back. (it's an old driver so probably only picked up dt support by accident)
An alternative would be to add the docs for the rest of the parts supported by the driver - so have a unified doc for the i2c and SPI parts.
Meh, it's probably simpler to just put that in as a separate doc though rather than merge it with this one. So we'll probably have an adi,ad5686.yaml file again doing that once I get round to writing one.
I'm assuming you'll pick this up?
Quoted 48 lines
Quoted 46 lines
---
v2:
- Rename instead of adding AD5686.../iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)rename
Documentation/devicetree/bindings/iio/dac/{adi,ad5686.yaml=> adi,ad5696.yaml} (77%)Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml renamed from Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml +5
-5@@ -1,16 +1,16 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml# +$id: http://devicetree.org/schemas/iio/dac/adi,ad5696.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Analog Devices AD5686 and similar multi-channel DACs +title: Analog Devices AD5696 and similar multi-channel DACs maintainers: - Michael Auchter <[email protected]> description: | - Binding for Analog Devices AD5686 and similar multi-channel DACs + Binding for Analog Devices AD5696 and similar multi-channel DACs properties: compatible:@@ -48,8 +48,8 @@ examples: #address-cells = <1>; #size-cells = <0>; - ad5686: dac@0 { - compatible = "adi,ad5686"; + ad5696: dac@0 { + compatible = "adi,ad5696"; reg = <0>; vcc-supply = <&dac_vref>; };