Fix Revert "bfq: Fix computation of shallow depth" in linux-block.git
Subsystems (2)
PATCH 1/1 Fix Revert "bfq: Fix computation of shallow depth" in linux-block.git
Hi Jens,
Not yet got your mail, but per https://lkml.org/lkml/2021/2/2/1901, this patch
is the incremental. Codes based on:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/patch/?id=8a483b42b1b3cef7e72564cdcdde62a373bd2f01
Notes: After checking previous hand-applied patch in block-5.11 broken 2 lines in original patch, the incremental covers all.
Thanks.
--- block/bfq-iosched.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
block/bfq-iosched.c +2 -2
@@ -6332,13 +6332,13 @@ static unsigned int bfq_update_depths(struct bfq_data *bfqd,* limit 'something'. */ /* no more than 50% of tags for async I/O */ - bfqd->word_depths[0 ][1 ] =max (((1U << bt->sb.shift) *3 ) >>2 ,1U ); + bfqd->word_depths[0 ][0 ] =max ((1U << bt->sb.shift) >>1 ,1U );/* * no more than 75% of tags for sync writes (25% extra tags * w.r.t. async I/O, to prevent async I/O from starving sync * writes) */ - bfqd->word_depths[0 ][1 ] =max ((bt->sb.depth *3 ) >>2 ,1U ); + bfqd->word_depths[0 ][1 ] =max (((1U << bt->sb.shift) *3 ) >>2 ,1U );/* * In-word depths in case some bfq_queue is being weight-
Signature · 1 line
2.25.4
Jens Axboe
maintainerQuoted 8 lines · Lin Feng
Hi Jens,
Not yet got your mail, but per https://lkml.org/lkml/2021/2/2/1901, this patch
is the incremental. Codes based on:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/patch/?id=8a483b42b1b3cef7e72564cdcdde62a373bd2f01Notes: After checking previous hand-applied patch in block-5.11 broken 2 lines in original patch, the incremental covers all.
Thanks, folded in. Please check the resulting patch:
Signature · 1 line
Jens Axboe
Quoted 7 lines · Jens Axboe
Quoted 6 lines · Lin Feng
Hi Jens,
Not yet got your mail, but per https://lkml.org/lkml/2021/2/2/1901, this patch
is the incremental. Codes based on:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/patch/?id=8a483b42b1b3cef7e72564cdcdde62a373bd2f01
Quoted 7 lines
Quoted 2 lines
Notes: After checking previous hand-applied patch in block-5.11 broken 2 lines in original patch, the incremental covers all.
Thanks, folded in. Please check the resulting patch:
Yes, it's correct :)
Thanks,
linfeng