mm/mlock: stop counting mlocked pages when none vma is found
Subsystems (2)
PATCH 1/1 mm/mlock: stop counting mlocked pages when none vma is found
There will be no vma satisfies addr < vm_end when find_vma() returns NULL. Thus it's meaningless to traverse the vma list below because we can't find any vma to count mlocked pages. Stop counting mlocked pages in this case to save some vma list traversal cycles.
Signed-off-by Miaohe Lin <[email protected]>
--- mm/mlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/mlock.c +1 -1
@@ -622,7 +622,7 @@ static unsigned long count_mm_mlocked_page_nr(struct mm_struct *mm, vma =find_vma (mm, start);if (vma ==NULL ) - vma = mm->mmap; +return 0 ;for (; vma ; vma = vma->vm_next) {if (start >= vma->vm_end)
Signature · 1 line
2.19.1
Quoted 4 lines · Miaohe Lin
There will be no vma satisfies addr <
vm_endwhenfind_vma()returns NULL. Thus it's meaningless to traverse the vma list below because we can't find any vma to count mlocked pages. Stop counting mlocked pages in this case to save some vma list traversal cycles.
I think this is correct. We will have addr >= vm_end for any VMA, so there are no applicable VMAs.
Reviewed-by David Hildenbrand <[email protected]>
Quoted 20 lines
Signed-off-by Miaohe Lin <[email protected]>--- mm/mlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/mlock.c +1
-1@@ -622,7 +622,7 @@ static unsigned long count_mm_mlocked_page_nr(struct mm_struct *mm, vma =find_vma (mm, start);if (vma ==NULL ) - vma = mm->mmap; +return 0 ;for (; vma ; vma = vma->vm_next) {if (start >= vma->vm_end)
Signature · 3 lines
Thanks, David / dhildenb