Skip to contentSkip to conversation

gpio: uapi: use the preferred SPDX license identifier

PATCH In review Bartosz Golaszewski 3 participants 7 messages Feb 4, 2021 – Feb 10, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: uapi: use the preferred SPDX license identifier

From: Bartosz Golaszewski <[email protected]>

GPL-2.0 license identifier is deprecated, let's use the preferred
identifier: GPL-2.0-only.

---
Hi Kent, Greg,

I started working on making libgpiod licensing reuse-compliant and noticed that the reuse-tool is telling me that the GPL-2.0 SPDX identifier in the GPIO uapi header is deprecated. Since I'm required to copy the header verbatim into libgpiod's repository, I think we need to fix that at source first.

 include/uapi/linux/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/gpio.h +1 -1
index e4eb0b8c5cf9..3e01ededbf36 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
 /*
  * <linux/gpio.h> - userspace ABI for the GPIO character devices
  *
Signature · 1 line
2.29.1
#1 lore raw
Quoted 23 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

GPL-2.0 license identifier is deprecated, let's use the preferred
identifier: GPL-2.0-only.

---
Hi Kent, Greg,

I started working on making libgpiod licensing reuse-compliant and noticed that the reuse-tool is telling me that the GPL-2.0 SPDX identifier in the GPIO uapi header is deprecated. Since I'm required to copy the header verbatim into libgpiod's repository, I think we need to fix that at source first.

 include/uapi/linux/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/gpio.h +0 -0
index e4eb0b8c5cf9..3e01ededbf36 100644

include/uapi/linux/gpio.h line 1

Quoted 2 lines
include/uapi/linux/gpio.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */

No, there is no need to convert the kernel to the "latest" spdx level, when we started out there was no "-only" nonsense (hint no other license has that crud), and "GPL-2.0" is a totally valid summary of the license.

So please don't go changing it all in-kernel, that way lies madness. Let's finish fixing up ALL kernel files before worrying about what SPDX "version" we are at.

thanks,

greg k-h

#2 lore raw
Quoted 32 lines · Greg Kroah-Hartman
Quoted 23 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

GPL-2.0 license identifier is deprecated, let's use the preferred
identifier: GPL-2.0-only.

---
Hi Kent, Greg,

I started working on making libgpiod licensing reuse-compliant and noticed that the reuse-tool is telling me that the GPL-2.0 SPDX identifier in the GPIO uapi header is deprecated. Since I'm required to copy the header verbatim into libgpiod's repository, I think we need to fix that at source first.

 include/uapi/linux/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/gpio.h +0 -0
index e4eb0b8c5cf9..3e01ededbf36 100644

include/uapi/linux/gpio.h line 1

Quoted 2 lines
include/uapi/linux/gpio.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */

No, there is no need to convert the kernel to the "latest" spdx level, when we started out there was no "-only" nonsense (hint no other license has that crud), and "GPL-2.0" is a totally valid summary of the license.

Quoted 4 lines

So please don't go changing it all in-kernel, that way lies madness. Let's finish fixing up ALL kernel files before worrying about what SPDX "version" we are at.

But then, the reuse script is telling me:

Unfortunately, your project is not compliant with version 3.0 of
the REUSE Specification :-(

because I'm using a deprecated license. :(

Bartosz

#3 lore raw
Quoted 39 lines · Bartosz Golaszewski
Quoted 32 lines · Greg Kroah-Hartman
Quoted 23 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

GPL-2.0 license identifier is deprecated, let's use the preferred
identifier: GPL-2.0-only.

---
Hi Kent, Greg,

I started working on making libgpiod licensing reuse-compliant and noticed that the reuse-tool is telling me that the GPL-2.0 SPDX identifier in the GPIO uapi header is deprecated. Since I'm required to copy the header verbatim into libgpiod's repository, I think we need to fix that at source first.

 include/uapi/linux/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/gpio.h +0 -0
index e4eb0b8c5cf9..3e01ededbf36 100644

include/uapi/linux/gpio.h line 1

Quoted 2 lines
include/uapi/linux/gpio.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */

No, there is no need to convert the kernel to the "latest" spdx level, when we started out there was no "-only" nonsense (hint no other license has that crud), and "GPL-2.0" is a totally valid summary of the license.

Quoted 4 lines

So please don't go changing it all in-kernel, that way lies madness. Let's finish fixing up ALL kernel files before worrying about what SPDX "version" we are at.

Quoted 6 lines

But then, the reuse script is telling me:

Unfortunately, your project is not compliant with version 3.0 of
the REUSE Specification :-(

because I'm using a deprecated license. :(

Go yell at the REUSE people, there's no requirement to have the most
recent version of SPDX, is there? :)

And if that's the only thing wrong with the project when running 'reuse lint' then you should be happy, no one will complain at all.

thanks,

greg k-h

#4 lore raw
Quoted 51 lines · Greg Kroah-Hartman
Quoted 39 lines · Bartosz Golaszewski
Quoted 32 lines · Greg Kroah-Hartman
Quoted 23 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

GPL-2.0 license identifier is deprecated, let's use the preferred
identifier: GPL-2.0-only.

---
Hi Kent, Greg,

I started working on making libgpiod licensing reuse-compliant and noticed that the reuse-tool is telling me that the GPL-2.0 SPDX identifier in the GPIO uapi header is deprecated. Since I'm required to copy the header verbatim into libgpiod's repository, I think we need to fix that at source first.

 include/uapi/linux/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/gpio.h +0 -0
index e4eb0b8c5cf9..3e01ededbf36 100644

include/uapi/linux/gpio.h line 1

Quoted 2 lines
include/uapi/linux/gpio.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */

No, there is no need to convert the kernel to the "latest" spdx level, when we started out there was no "-only" nonsense (hint no other license has that crud), and "GPL-2.0" is a totally valid summary of the license.

Quoted 4 lines

So please don't go changing it all in-kernel, that way lies madness. Let's finish fixing up ALL kernel files before worrying about what SPDX "version" we are at.

Quoted 6 lines

But then, the reuse script is telling me:

Unfortunately, your project is not compliant with version 3.0 of
the REUSE Specification :-(

because I'm using a deprecated license. :(

Go yell at the REUSE people, there's no requirement to have the most
recent version of SPDX, is there? :)

Quoted 6 lines

And if that's the only thing wrong with the project when running 'reuse lint' then you should be happy, no one will complain at all.

thanks,

greg k-h

Ok, I get it but let me try one last time: there's absolutely no harm in merging this patch for the next release, is there? Currently there are around 15000 instances of "GPL-2.0-only" in the kernel vs 30000 "GPL-2.0" - so the former is not that uncommon.

Bartosz

#5 lore raw
Quoted 56 lines · Bartosz Golaszewski
Quoted 54 lines · Greg Kroah-Hartman
Quoted 39 lines · Bartosz Golaszewski
Quoted 32 lines · Greg Kroah-Hartman
Quoted 23 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

GPL-2.0 license identifier is deprecated, let's use the preferred
identifier: GPL-2.0-only.

---
Hi Kent, Greg,

I started working on making libgpiod licensing reuse-compliant and noticed that the reuse-tool is telling me that the GPL-2.0 SPDX identifier in the GPIO uapi header is deprecated. Since I'm required to copy the header verbatim into libgpiod's repository, I think we need to fix that at source first.

 include/uapi/linux/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/gpio.h +0 -0
index e4eb0b8c5cf9..3e01ededbf36 100644

include/uapi/linux/gpio.h line 1

Quoted 2 lines
include/uapi/linux/gpio.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */

No, there is no need to convert the kernel to the "latest" spdx level, when we started out there was no "-only" nonsense (hint no other license has that crud), and "GPL-2.0" is a totally valid summary of the license.

Quoted 4 lines

So please don't go changing it all in-kernel, that way lies madness. Let's finish fixing up ALL kernel files before worrying about what SPDX "version" we are at.

Quoted 6 lines

But then, the reuse script is telling me:

Unfortunately, your project is not compliant with version 3.0 of
the REUSE Specification :-(

because I'm using a deprecated license. :(

Go yell at the REUSE people, there's no requirement to have the most
recent version of SPDX, is there? :)

And if that's the only thing wrong with the project when running 'reuse lint' then you should be happy, no one will complain at all.

Quoted 8 lines
Quoted 3 lines

thanks,

greg k-h

Ok, I get it but let me try one last time: there's absolutely no harm in merging this patch for the next release, is there? Currently there are around 15000 instances of "GPL-2.0-only" in the kernel vs 30000 "GPL-2.0" - so the former is not that uncommon.

It's up to the owner/maintainer of this file in the end, but I don't want to see patches doing this for many more files, as it's pointless churn as far as the kernel is concerned.

thanks,

greg k-h

#6 lore raw
Quoted 62 lines · Greg Kroah-Hartman
Quoted 60 lines · Bartosz Golaszewski
Quoted 57 lines · Greg Kroah-Hartman
Quoted 39 lines · Bartosz Golaszewski
Quoted 32 lines · Greg Kroah-Hartman
Quoted 23 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

GPL-2.0 license identifier is deprecated, let's use the preferred
identifier: GPL-2.0-only.

---
Hi Kent, Greg,

I started working on making libgpiod licensing reuse-compliant and noticed that the reuse-tool is telling me that the GPL-2.0 SPDX identifier in the GPIO uapi header is deprecated. Since I'm required to copy the header verbatim into libgpiod's repository, I think we need to fix that at source first.

 include/uapi/linux/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/gpio.h +0 -0
index e4eb0b8c5cf9..3e01ededbf36 100644

include/uapi/linux/gpio.h line 1

Quoted 2 lines
include/uapi/linux/gpio.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */

No, there is no need to convert the kernel to the "latest" spdx level, when we started out there was no "-only" nonsense (hint no other license has that crud), and "GPL-2.0" is a totally valid summary of the license.

Quoted 4 lines

So please don't go changing it all in-kernel, that way lies madness. Let's finish fixing up ALL kernel files before worrying about what SPDX "version" we are at.

Quoted 6 lines

But then, the reuse script is telling me:

Unfortunately, your project is not compliant with version 3.0 of
the REUSE Specification :-(

because I'm using a deprecated license. :(

Go yell at the REUSE people, there's no requirement to have the most
recent version of SPDX, is there? :)

And if that's the only thing wrong with the project when running 'reuse lint' then you should be happy, no one will complain at all.

thanks,

greg k-h

Quoted 9 lines
Quoted 4 lines

Ok, I get it but let me try one last time: there's absolutely no harm in merging this patch for the next release, is there? Currently there are around 15000 instances of "GPL-2.0-only" in the kernel vs 30000 "GPL-2.0" - so the former is not that uncommon.

It's up to the owner/maintainer of this file in the end, but I don't want to see patches doing this for many more files, as it's pointless churn as far as the kernel is concerned.

Since it's up to me to decide - I'll apply this but I'll clarify in the commit message why user-space may want this change.

Bart