Skip to contentSkip to conversation

net/mlx5: fix TCP flag field modification

PATCH In review Alexander Kozyrev 3 participants 3 messages Feb 5, 2021 – Feb 21, 2021 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix TCP flag field modification

Wrong modification field ID is used for TCP flags: the inner TCP flag field is changing instead of the outermost one. Use the proper field ID to match the expectations.

Fixes 641dbe4fb0 ("net/mlx5: support modify field flow action")
---
 drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/mlx5_flow_dv.c +1 -1
index 76696b7b62..a44291a3c9 100644
@@ -1653,7 +1653,7 @@ mlx5_flow_field_id_to_modify_info
 		break;
 	case RTE_FLOW_FIELD_TCP_FLAGS:
 		info[idx] = (struct field_modify_info){1, 0,
-					MLX5_MODI_IN_TCP_FLAGS};
+					MLX5_MODI_OUT_TCP_FLAGS};
 		if (mask) {
 			mask[idx] = 0x0000003f;
 			if (width < 6)
Signature · 1 line
2.24.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Friday, February 5, 2021 5:03
To: [email protected]
Cc: [email protected]; Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>; Ori Kam <[email protected]>
Subject: [PATCH] net/mlx5: fix TCP flag field modification

Quoted 8 lines

Wrong modification field ID is used for TCP flags: the inner TCP flag field is changing instead of the outermost one.
Use the proper field ID to match the expectations.

Fixes 641dbe4fb0 ("net/mlx5: support modify field flow action")
Quoted 19 lines
---
 drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/net/mlx5/mlx5_flow_dv.c index 76696b7b62..a44291a3c9 100644

drivers/net/mlx5/mlx5_flow_dv.c +1 -2
@@ -1653,7 +1653,7 @@ mlx5_flow_field_id_to_modify_info
 		break;
 	case RTE_FLOW_FIELD_TCP_FLAGS:
 		info[idx] = (struct field_modify_info){1, 0,
-					MLX5_MODI_IN_TCP_FLAGS};
+					MLX5_MODI_OUT_TCP_FLAGS};
 		if (mask) {
 			mask[idx] = 0x0000003f;
 			if (width < 6)
--

2.24.1

#2 lore raw
In reply to Alexander Kozyrev

Hi,

Quoted 9 lines

-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Friday, February 5, 2021 5:03 AM
To: [email protected]
Cc: [email protected]; Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>; Ori Kam <[email protected]>
Subject: [PATCH] net/mlx5: fix TCP flag field modification

Quoted 8 lines

Wrong modification field ID is used for TCP flags: the inner TCP flag field is changing instead of the outermost one. Use the proper field ID to match the expectations.

Fixes 641dbe4fb0 ("net/mlx5: support modify field flow action")

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh