Skip to contentSkip to conversation

ARM: s3c: irq-s3c24xx: include headers for missing declarations

PATCH Applied Krzysztof Kozlowski 1 participant 4 messages Feb 6, 2021 – Feb 8, 2021

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/2 ARM: s3c: irq-s3c24xx: include headers for missing declarations

Include headers to fix W=1 build warnings:

arch/arm/mach-s3c/irq-s3c24xx.c:389:5: warning:
no previous prototype for ‘s3c24xx_set_fiq’ [-Wmissing-prototypes]
arch/arm/mach-s3c/irq-s3c24xx.c:683:13: warning:
no previous prototype for ‘s3c2410_init_irq’ [-Wmissing-prototypes]

Reported-by kernel test robot <[email protected]>
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm/mach-s3c/irq-s3c24xx.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-s3c/irq-s3c24xx.c +2 -0
index 79b5f19af7a5..3368159d3f3e 100644
@@ -21,6 +21,7 @@
 #include <linux/of.h>
 #include <linux/of_irq.h>
 #include <linux/of_address.h>
+#include <linux/spi/s3c24xx.h>
 
 #include <asm/exception.h>
 #include <asm/mach/irq.h>

@@ -32,6 +33,7 @@
 #include "cpu.h"
 #include "regs-irqtype.h"
 #include "pm.h"
+#include "s3c24xx.h"
 
 #define S3C_IRQTYPE_NONE	0
 #define S3C_IRQTYPE_EINT	1
Signature · 1 line
2.25.1
author maintainer
#1 lore raw

PATCH 2/2 ARM: s3c: irq-s3c24xx: staticize local functions

Make functions used only in this module static to fix W=1 build warnings:

arch/arm/mach-s3c/irq-s3c24xx.c:360:39: warning:
no previous prototype for ‘s3c24xx_handle_irq’ [-Wmissing-prototypes]
arch/arm/mach-s3c/irq-s3c24xx.c:1308:12: warning:
no previous prototype for ‘s3c2410_init_intc_of’ [-Wmissing-prototypes]
arch/arm/mach-s3c/irq-s3c24xx.c:1330:12: warning:
no previous prototype for ‘s3c2416_init_intc_of’ [-Wmissing-prototypes]

Reported-by kernel test robot <[email protected]>
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm/mach-s3c/irq-s3c24xx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-s3c/irq-s3c24xx.c +3 -3
index 3368159d3f3e..0c631c14a817 100644
@@ -359,7 +359,7 @@ static inline int s3c24xx_handle_intc(struct s3c_irq_intc *intc,
 	return true;
 }
 
-asmlinkage void __exception_irq_entry s3c24xx_handle_irq(struct pt_regs *regs)
+static asmlinkage void __exception_irq_entry s3c24xx_handle_irq(struct pt_regs *regs)
 {
 	do {
 		if (likely(s3c_intc[0]))

@@ -1307,7 +1307,7 @@ static struct s3c24xx_irq_of_ctrl s3c2410_ctrl[] = {
 	}
 };
 
-int __init s3c2410_init_intc_of(struct device_node *np,
+static int __init s3c2410_init_intc_of(struct device_node *np,
 			struct device_node *interrupt_parent)
 {
 	return s3c_init_intc_of(np, interrupt_parent,

@@ -1329,7 +1329,7 @@ static struct s3c24xx_irq_of_ctrl s3c2416_ctrl[] = {
 	}
 };
 
-int __init s3c2416_init_intc_of(struct device_node *np,
+static int __init s3c2416_init_intc_of(struct device_node *np,
 			struct device_node *interrupt_parent)
 {
 	return s3c_init_intc_of(np, interrupt_parent,
Signature · 1 line
2.25.1
author maintainer Applied
#2 lore raw

Re: (subset) [PATCH 1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations

In reply to Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

Include headers to fix W=1 build warnings:

arch/arm/mach-s3c/irq-s3c24xx.c:389:5: warning:
no previous prototype for ‘s3c24xx_set_fiq’ [-Wmissing-prototypes]
arch/arm/mach-s3c/irq-s3c24xx.c:683:13: warning:
no previous prototype for ‘s3c2410_init_irq’ [-Wmissing-prototypes]

Applied, thanks!

[1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations

      commit: 49dc85ca3c78d938d9eb41e05efcd85c92626e84

Best regards,

Signature · 6 lines
Krzysztof Kozlowski <[email protected]>

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer Applied
#3 lore raw

Re: (subset) [PATCH 1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations

In reply to Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

Include headers to fix W=1 build warnings:

arch/arm/mach-s3c/irq-s3c24xx.c:389:5: warning:
no previous prototype for ‘s3c24xx_set_fiq’ [-Wmissing-prototypes]
arch/arm/mach-s3c/irq-s3c24xx.c:683:13: warning:
no previous prototype for ‘s3c2410_init_irq’ [-Wmissing-prototypes]

Applied, thanks!

[2/2] ARM: s3c: irq-s3c24xx: staticize local functions

      commit: f503878564f5e68c1aeb1ea01e437060bf905c50

Best regards,

Signature · 6 lines
Krzysztof Kozlowski <[email protected]>

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel