Skip to contentSkip to conversation

iio: ad7949: fix wrong ADC result due to incorrect bit mask

PATCH Superseded Wilfried Wessner 2 participants 2 messages Feb 6, 2021

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: ad7949: fix wrong ADC result due to incorrect bit mask

Fixes a wrong bit mask used for the ADC's result, which was caused by an improper usage of the GENMASK() macro. The bits higher than ADC's resolution are undefined and if not masked out correctly, a wrong result can be given. The GENMASK() macro indexing is zero based, so the mask has to go from [resolution -1 , 0].

---
 drivers/iio/adc/ad7949.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7949.c +1 -1
index 5d597e5050f6..1b4b3203e428 100644
@@ -91,7 +91,7 @@ static int ad7949_spi_read_channel(struct ad7949_adc_chip *ad7949_adc, int *val,
 	int ret;
 	int i;
 	int bits_per_word = ad7949_adc->resolution;
-	int mask = GENMASK(ad7949_adc->resolution, 0);
+	int mask = GENMASK(ad7949_adc->resolution - 1, 0);
 	struct spi_message msg;
 	struct spi_transfer tx[] = {
 		{
Signature · 1 line
2.25.1
#1 lore raw
Quoted 1 line · Wilfried Wessner

This needs to go after the changelog text.

Quoted 6 lines

Fixes a wrong bit mask used for the ADC's result, which was caused by an improper usage of the GENMASK() macro. The bits higher than ADC's resolution are undefined and if not masked out correctly, a wrong result can be given. The GENMASK() macro indexing is zero based, so the mask has to go from [resolution -1 , 0].

You have trailing whitespace in your text, perhaps get your editor to show you this?

Also, this is a new version of the patch, it needs to be marked as such so we know which is the "latest". The documentation says how to do that.

thanks,

greg k-h