Skip to contentSkip to conversation

scsi: scsi_debug: fix a memory leak.

PATCH Applied Maurizio Lombardi 3 participants 3 messages Feb 8, 2021 – Feb 9, 2021 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: scsi_debug: fix a memory leak.

The sdebug_q_arr pointer must be freed when the module is unloaded

# cat /sys/kernel/debug/kmemleak
unreferenced object 0xffff888e1cfb0000 (size 4096):
  comm "modprobe", pid 165555, jiffies 4325987516 (age 685.194s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<00000000458f4f5d>] 0xffffffffc06702d9
    [<000000003edc4b1f>] do_one_initcall+0xe9/0x57d
    [<00000000da7d518c>] do_init_module+0x1d1/0x6f0
    [<000000009a6a9248>] load_module+0x36bd/0x4f50
    [<00000000ddb0c3ce>] __do_sys_init_module+0x1db/0x260
    [<000000009532db57>] do_syscall_64+0xa5/0x420
    [<000000002916b13d>] entry_SYSCALL_64_after_hwframe+0x6a/0xdf
Fixes 87c715dcde633f4cc4690a24a240e838181e6a9d
---
 drivers/scsi/scsi_debug.c | 1 +
 1 file changed, 1 insertion(+)
drivers/scsi/scsi_debug.c +1 -0
index 4a08c450b756..b6540b92f566 100644
@@ -6881,6 +6881,7 @@ static void __exit scsi_debug_exit(void)
 
 	sdebug_erase_all_stores(false);
 	xa_destroy(per_store_ap);
+	kfree(sdebug_q_arr);
 }
 
 device_initcall(scsi_debug_init);
Signature · 1 line
2.29.2
Acked-by on v1 1/1
#1 lore raw
Quoted 17 lines · Maurizio Lombardi

The sdebug_q_arr pointer must be freed when the module is unloaded

# cat /sys/kernel/debug/kmemleak
unreferenced object 0xffff888e1cfb0000 (size 4096):
   comm "modprobe", pid 165555, jiffies 4325987516 (age 685.194s)
   hex dump (first 32 bytes):
     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
   backtrace:
     [<00000000458f4f5d>] 0xffffffffc06702d9
     [<000000003edc4b1f>] do_one_initcall+0xe9/0x57d
     [<00000000da7d518c>] do_init_module+0x1d1/0x6f0
     [<000000009a6a9248>] load_module+0x36bd/0x4f50
     [<00000000ddb0c3ce>] __do_sys_init_module+0x1db/0x260
     [<000000009532db57>] do_syscall_64+0xa5/0x420
     [<000000002916b13d>] entry_SYSCALL_64_after_hwframe+0x6a/0xdf
Quoted 3 lines
Fixes 87c715dcde633f4cc4690a24a240e838181e6a9d

Thanks.

Quoted 17 lines
---
  drivers/scsi/scsi_debug.c | 1 +
  1 file changed, 1 insertion(+)
drivers/scsi/scsi_debug.c +1 -0
index 4a08c450b756..b6540b92f566 100644
@@ -6881,6 +6881,7 @@ static void __exit scsi_debug_exit(void)
 
  	sdebug_erase_all_stores(false);
  	xa_destroy(per_store_ap);
+	kfree(sdebug_q_arr);
  }
 
  device_initcall(scsi_debug_init);
#2 lore raw
In reply to Maurizio Lombardi
Quoted 17 lines · Maurizio Lombardi

The sdebug_q_arr pointer must be freed when the module is unloaded

# cat /sys/kernel/debug/kmemleak
unreferenced object 0xffff888e1cfb0000 (size 4096):
  comm "modprobe", pid 165555, jiffies 4325987516 (age 685.194s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<00000000458f4f5d>] 0xffffffffc06702d9
    [<000000003edc4b1f>] do_one_initcall+0xe9/0x57d
    [<00000000da7d518c>] do_init_module+0x1d1/0x6f0
    [<000000009a6a9248>] load_module+0x36bd/0x4f50
    [<00000000ddb0c3ce>] __do_sys_init_module+0x1db/0x260
    [<000000009532db57>] do_syscall_64+0xa5/0x420
    [<000000002916b13d>] entry_SYSCALL_64_after_hwframe+0x6a/0xdf
Quoted 1 line

[...]

Applied to 5.11/scsi-fixes, thanks!

[1/1] scsi: scsi_debug: fix a memory leak.

      https://git.kernel.org/mkp/scsi/c/f852c596f2ee
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering