Skip to contentSkip to conversation

docs: Remove the Microsoft rhetoric

PATCH In review Yorick de Wid 3 participants 3 messages Feb 8, 2021 – Feb 11, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs: Remove the Microsoft rhetoric

From: Yorick de Wid <[email protected]>

There is no need to need to name Microsoft. The point is clear without that context.

---
 Documentation/process/coding-style.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/process/coding-style.rst +1 -2
index 98227226c4e..5608ed2931f 100644
@@ -306,8 +306,7 @@ that counts the number of active users, you should call that
 
 Encoding the type of a function into the name (so-called Hungarian
 notation) is asinine - the compiler knows the types anyway and can check
-those, and it only confuses the programmer. No wonder Microsoft makes buggy
-programs.
+those, and it only confuses the programmer.
 
 LOCAL variable names should be short, and to the point.  If you have
 some random integer loop counter, it should probably be called ``i``.
Signature · 1 line
2.30.0
#1 lore raw
Quoted 14 lines · Yorick de Wid

From: Yorick de Wid <[email protected]>

There is no need to need to name Microsoft. The point is clear without that context.

---
 Documentation/process/coding-style.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/process/coding-style.rst +0 -0
index 98227226c4e..5608ed2931f 100644

Documentation/process/coding-style.rst that counts the number of active users, you should call that · line 309

Quoted 6 lines
Documentation/process/coding-style.rst +1 -2
@@ -306,8 +306,7 @@ that counts the number of active users, you should call that
 
 Encoding the type of a function into the name (so-called Hungarian
 notation) is asinine - the compiler knows the types anyway and can check
-those, and it only confuses the programmer. No wonder Microsoft makes buggy
-programs.
+those, and it only confuses the programmer.

I'm not opposed to this, but it'd be nice to distinguish between Systems Hungarian (which is what this paragraph is correctly excoriating) and Apps Hungarian (which is actually useful and we should do more of):

https://www.joelonsoftware.com/2005/05/11/making-wrong-code-look-wrong/

maintainer
#2 lore raw
In reply to Yorick de Wid
Quoted 14 lines · Yorick de Wid

From: Yorick de Wid <[email protected]>

There is no need to need to name Microsoft. The point is clear without that context.

---
 Documentation/process/coding-style.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/process/coding-style.rst +0 -0
index 98227226c4e..5608ed2931f 100644

Documentation/process/coding-style.rst that counts the number of active users, you should call that · line 309

Quoted 6 lines
Documentation/process/coding-style.rst +1 -2
@@ -306,8 +306,7 @@ that counts the number of active users, you should call that
 
 Encoding the type of a function into the name (so-called Hungarian
 notation) is asinine - the compiler knows the types anyway and can check
-those, and it only confuses the programmer. No wonder Microsoft makes buggy
-programs.
+those, and it only confuses the programmer.

Yeah, the time for that has probably passed. Applied, thanks.

jon

P.S. This CC line in your original:

Quoted 1 line
Cc Yorick de Wid <[email protected]>, Yorick de Wid <[email protected]>

Seems sure to create errors; maybe that could be left out in the future?