Skip to contentSkip to conversation

selinux: Allow context mounts for unpriviliged overlayfs

PATCH Superseded Vivek Goyal 2 participants 5 messages Feb 9, 2021 – Feb 11, 2021 SELinux security module

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selinux: Allow context mounts for unpriviliged overlayfs

Now overlayfs allow unpriviliged mounts. That is root inside a non-init user namespace can mount overlayfs. This was added in 5.10 kernel.

Giuseppe tried to mount overlayfs with option "context" and it failed with error -EACCESS.

$ su test
$ unshare -rm
$ mkdir -p lower upper work merged
$ mount -t overlay -o lowerdir=lower,workdir=work,upperdir=upper,userxattr,context='system_u:object_r:container_file_t:s0' none merged

This fails with -EACCESS. It works if option "-o context" is not specified.

Little debugging showed that selinux_set_mnt_opts() returns -EACCESS.

So this patch adds "overlay" to the list, where it is fine to specific context from non init_user_ns.

---
 security/selinux/hooks.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
security/selinux/hooks.c +2 -1
Index: redhat-linux/security/selinux/hooks.c
===================================================================
@@ -733,7 +733,8 @@ static int selinux_set_mnt_opts(struct s
 	if (sb->s_user_ns != &init_user_ns &&
 	    strcmp(sb->s_type->name, "tmpfs") &&
 	    strcmp(sb->s_type->name, "ramfs") &&
-	    strcmp(sb->s_type->name, "devpts")) {
+	    strcmp(sb->s_type->name, "devpts") &&
+	    strcmp(sb->s_type->name, "overlay")) {
 		if (context_sid || fscontext_sid || rootcontext_sid ||
 		    defcontext_sid) {
 			rc = -EACCES;
maintainer
#1 lore raw
Quoted 16 lines · Vivek Goyal

Now overlayfs allow unpriviliged mounts. That is root inside a non-init user namespace can mount overlayfs. This was added in 5.10 kernel.

Giuseppe tried to mount overlayfs with option "context" and it failed with error -EACCESS.

$ su test
$ unshare -rm
$ mkdir -p lower upper work merged
$ mount -t overlay -o lowerdir=lower,workdir=work,upperdir=upper,userxattr,context='system_u:object_r:container_file_t:s0' none merged

This fails with -EACCESS. It works if option "-o context" is not specified.

Little debugging showed that selinux_set_mnt_opts() returns -EACCESS.

Quoted 8 lines

So this patch adds "overlay" to the list, where it is fine to specific context from non init_user_ns.

---
 security/selinux/hooks.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

This seems reasonable, but since we are at -rc7 this week it will need to wait until after the upcoming merge window. It's too late in the cycle for new features.

Signature · 2 lines
paul moore
www.paul-moore.com
#2 lore raw
Quoted 4 lines · Paul Moore
Quoted 3 lines · Vivek Goyal

Now overlayfs allow unpriviliged mounts. That is root inside a non-init user namespace can mount overlayfs. This was added in 5.10 kernel.

Actually this is being added in 5.11 kernel (and not 5.10 kernel).

Paul, can you please fix this while committing. If you want me to report, let me know.

Quoted 22 lines
Quoted 13 lines

Giuseppe tried to mount overlayfs with option "context" and it failed with error -EACCESS.

$ su test
$ unshare -rm
$ mkdir -p lower upper work merged
$ mount -t overlay -o lowerdir=lower,workdir=work,upperdir=upper,userxattr,context='system_u:object_r:container_file_t:s0' none merged

This fails with -EACCESS. It works if option "-o context" is not specified.

Little debugging showed that selinux_set_mnt_opts() returns -EACCESS.

Quoted 8 lines

So this patch adds "overlay" to the list, where it is fine to specific context from non init_user_ns.

---
 security/selinux/hooks.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 3 lines

This seems reasonable, but since we are at -rc7 this week it will need to wait until after the upcoming merge window. It's too late in the cycle for new features.

I am fine with this going in 5.12 kernel. Thanks Paul.

Vivek

maintainer
#3 lore raw
Quoted 10 lines · Vivek Goyal
Quoted 4 lines · Paul Moore
Quoted 3 lines · Vivek Goyal

Now overlayfs allow unpriviliged mounts. That is root inside a non-init user namespace can mount overlayfs. This was added in 5.10 kernel.

Actually this is being added in 5.11 kernel (and not 5.10 kernel).

Paul, can you please fix this while committing. If you want me to report, let me know.

Good to know, thanks for the clarification. As far as updating the commit description, while I generally prefer the patch author to make changes (my personal opinion is that maintainers should have as light a touch as possible outside the mechanical work of merging), this is pretty minor and I can fix that up if you want. Regardless, we've likely got ~2.5 weeks before it really matters anyway :)

Signature · 2 lines
paul moore
www.paul-moore.com
#4 lore raw
Quoted 12 lines · Paul Moore
Quoted 10 lines · Vivek Goyal
Quoted 4 lines · Paul Moore
Quoted 3 lines · Vivek Goyal

Now overlayfs allow unpriviliged mounts. That is root inside a non-init user namespace can mount overlayfs. This was added in 5.10 kernel.

Actually this is being added in 5.11 kernel (and not 5.10 kernel).

Paul, can you please fix this while committing. If you want me to report, let me know.

Quoted 6 lines

Good to know, thanks for the clarification. As far as updating the commit description, while I generally prefer the patch author to make changes (my personal opinion is that maintainers should have as light a touch as possible outside the mechanical work of merging), this is pretty minor and I can fix that up if you want. Regardless, we've likely got ~2.5 weeks before it really matters anyway :)

Ok, I will repost. Want to keep it as simple as possible for you. :-)

Vivek

Quoted 5 lines
Signature · 3 lines
-- 
paul moore
www.paul-moore.com