Skip to contentSkip to conversation

net: hns3: fix return of random stack value

PATCH New Gustavo A. R. Silva 1 participant 1 message Feb 10, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: hns3: fix return of random stack value

Currently, a random stack value is being returned because variable _ret_ is not properly initialized. This variable is actually not used anymore and it should be removed.

Fix this by removing all instances of variable ret and return 0.

Fixes 64749c9c38a9 ("net: hns3: remove redundant return value of hns3_uninit_all_ring()")

Addresses-Coverity-ID: 1501700 ("Uninitialized scalar variable")

---
 drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +1 -2
index 9565b7999426..bf4302a5cf95 100644
@@ -4640,7 +4640,6 @@ static int hns3_reset_notify_uninit_enet(struct hnae3_handle *handle)
 {
 	struct net_device *netdev = handle->kinfo.netdev;
 	struct hns3_nic_priv *priv = netdev_priv(netdev);
-	int ret;
 
 	if (!test_and_clear_bit(HNS3_NIC_STATE_INITED, &priv->state)) {
 		netdev_warn(netdev, "already uninitialized\n");
@@ -4662,7 +4661,7 @@ static int hns3_reset_notify_uninit_enet(struct hnae3_handle *handle)
 
 	hns3_put_ring_config(priv);
 
-	return ret;
+	return 0;
 }
 
 static int hns3_reset_notify(struct hnae3_handle *handle,
Signature · 1 line
2.27.0