io_uring: remove redundant initialization of variable ret
Subsystems (3)
PATCH 1/1 io_uring: remove redundant initialization of variable ret
From: Colin Ian King <[email protected]>
The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
--- fs/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/io_uring.c +1 -1
@@ -2785,7 +2785,7 @@ static void io_complete_rw_common(struct kiocb *kiocb, long res,static bool io_resubmit_prep (struct io_kiocb *req) {struct iovec inline_vecs[UIO_FASTIOV ], *iovec = inline_vecs; -int rw, ret = -ECANCELED ; +int rw, ret;struct iov_iter iter;/* already prepared */
Signature · 1 line
2.30.0
Quoted 9 lines · Colin King
From: Colin Ian King <[email protected]>
The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Fixes b63534c41e20 ("io_uring: re-issue block requests that failed because of resources")Signed-off-by Colin Ian King <[email protected]>
Looks good.
Quoted 5 lines · Colin King
From: Colin Ian King <[email protected]>
The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed.
Applied, thanks.
Signature · 1 line
Jens Axboe