phy: rockchip: add Innosilicon-based CSI DPHY
Subsystems (3)
Heiko Stuebner
maintainercover phy: rockchip: add Innosilicon-based CSI DPHY
Newer Rockchip SoCs use a different DPHY for camera operation based on an IP block from Innosilicon.
This adds a driver for it for px30/rk3326/rk3368/rk1808.
Heiko Stuebner (2):
dt-bindings: phy: add yaml binding for rockchip-inno-csi-dphy phy/rockchip: add Innosilicon-based CSI dphy
.../bindings/phy/rockchip-inno-csi-dphy.yaml | 79 +++ drivers/phy/rockchip/Kconfig | 9 + drivers/phy/rockchip/Makefile | 1 + .../phy/rockchip/phy-rockchip-inno-csidphy.c | 480 ++++++++++++++++++ 4 files changed, 569 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml create mode 100644 drivers/phy/rockchip/phy-rockchip-inno-csidphy.c
Signature · 7 lines
2.29.2 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Heiko Stuebner
maintainerPATCH 1/2 dt-bindings: phy: add yaml binding for rockchip-inno-csi-dphy
From: Heiko Stuebner <[email protected]>
Some Rockchip SoCs like the rk3368, rk3326, px30 use a CSI dphy based on an Innosilicon IP. Add a binding for them.
--- .../bindings/phy/rockchip-inno-csi-dphy.yaml | 79 +++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml
Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml new file +79 -0
@@ -0,0 +1,79 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/rockchip-inno-csi-dphy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip SoC MIPI RX0 D-PHY Device Tree Bindings + +maintainers: + - Heiko Stuebner <[email protected]> + +description: | + The Rockchip SoC has a MIPI CSI D-PHY based on an Innosilicon IP wich + connects to the ISP1 (Image Signal Processing unit v1.0) for CSI cameras. + +properties: + compatible: + enum: + - rockchip,px30-csi-dphy + - rockchip,rk1808-csi-dphy + - rockchip,rk3326-csi-dphy + - rockchip,rk3368-csi-dphy + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + const: pclk + + '#phy-cells': + const: 0 + + power-domains: + description: Video in/out power domain. + maxItems: 1 + + resets: + items: + - description: exclusive PHY reset line + + reset-names: + items: + - const: apb + + rockchip,grf: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Some additional phy settings are access through GRF regs. + +required: + - compatible + - reg + - clocks + - clock-names + - '#phy-cells' + - power-domains + - resets + - reset-names + - rockchip,grf + +additionalProperties: false + +examples: + - | + + csi_dphy: phy@ff2f0000 { + compatible = "rockchip,px30-csi-dphy"; + reg = <0xff2f0000 0x4000>; + clocks = <&cru 1>; + clock-names = "pclk"; + #phy-cells = <0>; + power-domains = <&power 1>; + resets = <&cru 1>; + reset-names = "apb"; + rockchip,grf = <&grf>; + };
Signature · 7 lines
2.29.2 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 1/2] dt-bindings: phy: add yaml binding for rockchip-inno-csi-dphy
Quoted 11 lines · Heiko Stuebner
From: Heiko Stuebner <[email protected]>
Some Rockchip SoCs like the rk3368, rk3326, px30 use a CSI dphy based on an Innosilicon IP. Add a binding for them.
Signed-off-by Heiko Stuebner <[email protected]>--- .../bindings/phy/rockchip-inno-csi-dphy.yaml | 79 +++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Heiko Stuebner
maintainerPATCH 2/2 phy/rockchip: add Innosilicon-based CSI dphy
In reply to Heiko StuebnerFrom: Heiko Stuebner <[email protected]>
The CSI dphy found for example on the rk3326/px30 and rk3368 is based on an IP design from Innosilicon. Add a driver for it.
--- drivers/phy/rockchip/Kconfig | 9 + drivers/phy/rockchip/Makefile | 1 + .../phy/rockchip/phy-rockchip-inno-csidphy.c | 480 ++++++++++++++++++ 3 files changed, 490 insertions(+) create mode 100644 drivers/phy/rockchip/phy-rockchip-inno-csidphy.c
drivers/phy/rockchip/Kconfig +9 -0
@@ -48,6 +48,15 @@ config PHY_ROCKCHIP_INNO_USB2 help Support for Rockchip USB2.0 PHY with Innosilicon IP block. +config PHY_ROCKCHIP_INNO_CSIDPHY + tristate "Rockchip Innosilicon MIPI CSI PHY driver" + depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF + select GENERIC_PHY + select GENERIC_PHY_MIPI_DPHY + help + Enable this to support the Rockchip MIPI CSI PHY with + Innosilicon IP block. + config PHY_ROCKCHIP_INNO_DSIDPHY tristate "Rockchip Innosilicon MIPI/LVDS/TTL PHY driver" depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
drivers/phy/rockchip/Makefile +1 -0
@@ -2,6 +2,7 @@ obj-$(CONFIG_PHY_ROCKCHIP_DP) += phy-rockchip-dp.o obj-$(CONFIG_PHY_ROCKCHIP_DPHY_RX0) += phy-rockchip-dphy-rx0.o obj-$(CONFIG_PHY_ROCKCHIP_EMMC) += phy-rockchip-emmc.o +obj-$(CONFIG_PHY_ROCKCHIP_INNO_CSIDPHY) += phy-rockchip-inno-csidphy.o obj-$(CONFIG_PHY_ROCKCHIP_INNO_DSIDPHY) += phy-rockchip-inno-dsidphy.o obj-$(CONFIG_PHY_ROCKCHIP_INNO_HDMI) += phy-rockchip-inno-hdmi.o obj-$(CONFIG_PHY_ROCKCHIP_INNO_USB2) += phy-rockchip-inno-usb2.o
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +480 -0
480 lines not on this page · raw message
Signature · 7 lines
2.29.2 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Vinod Koul
maintainerRe: [PATCH 2/2] phy/rockchip: add Innosilicon-based CSI dphy
Quoted 51 lines · Heiko Stuebner
From: Heiko Stuebner <[email protected]>
The CSI dphy found for example on the rk3326/px30 and rk3368 is based on an IP design from Innosilicon. Add a driver for it.
Signed-off-by Heiko Stuebner <[email protected]>--- drivers/phy/rockchip/Kconfig | 9 + drivers/phy/rockchip/Makefile | 1 + .../phy/rockchip/phy-rockchip-inno-csidphy.c | 480 ++++++++++++++++++ 3 files changed, 490 insertions(+) create mode 100644 drivers/phy/rockchip/phy-rockchip-inno-csidphy.cdrivers/phy/rockchip/Kconfig +9
-0@@ -48,6 +48,15 @@ config PHY_ROCKCHIP_INNO_USB2 help Support for Rockchip USB2.0 PHY with Innosilicon IP block. +config PHY_ROCKCHIP_INNO_CSIDPHY + tristate "Rockchip Innosilicon MIPI CSI PHY driver" + depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF + select GENERIC_PHY + select GENERIC_PHY_MIPI_DPHY + help + Enable this to support the Rockchip MIPI CSI PHY with + Innosilicon IP block. + config PHY_ROCKCHIP_INNO_DSIDPHY tristate "Rockchip Innosilicon MIPI/LVDS/TTL PHY driver" depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OFdrivers/phy/rockchip/Makefile +1
-0@@ -2,6 +2,7 @@ obj-$(CONFIG_PHY_ROCKCHIP_DP) += phy-rockchip-dp.o obj-$(CONFIG_PHY_ROCKCHIP_DPHY_RX0) += phy-rockchip-dphy-rx0.o obj-$(CONFIG_PHY_ROCKCHIP_EMMC) += phy-rockchip-emmc.o +obj-$(CONFIG_PHY_ROCKCHIP_INNO_CSIDPHY) += phy-rockchip-inno-csidphy.o obj-$(CONFIG_PHY_ROCKCHIP_INNO_DSIDPHY) += phy-rockchip-inno-dsidphy.o obj-$(CONFIG_PHY_ROCKCHIP_INNO_HDMI) += phy-rockchip-inno-hdmi.o obj-$(CONFIG_PHY_ROCKCHIP_INNO_USB2) += phy-rockchip-inno-usb2.odrivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +0
-0
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c line 5
Quoted 5 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +5
-0@@ -0,0 +1,480 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Rockchip MIPI RX Innosilicon DPHY driver +* +* Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd.
We are in 2021 now :)
Quoted 39 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +39
-0+*/ + +#include <linux/clk.h> +#include <linux/delay.h> +#include <linux/io.h> +#include <linux/mfd/syscon.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_platform.h> +#include <linux/phy/phy.h> +#include <linux/phy/phy-mipi-dphy.h> +#include <linux/platform_device.h> +#include <linux/pm_runtime.h> +#include <linux/regmap.h> +#include <linux/reset.h> + +/* GRF */ +#define RK1808_GRF_PD_VI_CON_OFFSET 0x0430 + +#define RK3326_GRF_PD_VI_CON_OFFSET 0x0430 + +#define RK3368_GRF_SOC_CON6_OFFSET 0x0418 + +/* PHY */ +#define CSIDPHY_CTRL_LANE_ENABLE 0x00 +#define CSIDPHY_CTRL_LANE_ENABLE_CK BIT(6) +#define CSIDPHY_CTRL_LANE_ENABLE_LANE3 BIT(5) +#define CSIDPHY_CTRL_LANE_ENABLE_LANE2 BIT(4) +#define CSIDPHY_CTRL_LANE_ENABLE_LANE1 BIT(3) +#define CSIDPHY_CTRL_LANE_ENABLE_LANE0 BIT(2) +#define CSIDPHY_CTRL_LANE_ENABLE_UNDEFINED BIT(0) + +#define CSIDPHY_CTRL_LANE_ENABLE_SHIFT 2 + +/* not present on all variants */ +#define CSIDPHY_CTRL_PWRCTL 0x04 +#define CSIDPHY_CTRL_PWRCTL_UNDEFINED GENMASK(7, 5) +#define CSIDPHY_CTRL_PWRCTL_SYNCRST BIT(2) +#define CSIDPHY_CTRL_PWRCTL_LDO_PD BIT(1)
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c line 54
Quoted 10 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +10
-0+#define CSIDPHY_CTRL_PWRCTL_PLL_PD BIT(0) + +#define CSIDPHY_CTRL_DIG_RST 0x80 +#define CSIDPHY_CTRL_DIG_RST_UNDEFINED 0x1e +#define CSIDPHY_CTRL_DIG_RST_RESET BIT(0) + +/* offset after ths_settle_offset */ +#define CSIDPHY_CLK_THS_SETTLE 0 +#define CSIDPHY_LANE_THS_SETTLE (n) ((n + 1) * 0x80) +#define CSIDPHY_THS_SETTLE_MASK 0x7f
GENMASK for this?
Quoted 54 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +54
-0+ +/* offset after calib_offset */ +#define CSIDPHY_CLK_CALIB_EN 0 +#define CSIDPHY_LANE_CALIB_EN (n) ((n + 1) * 0x80) +#define CSIDPHY_CALIB_EN BIT(7) + +/* Configure the count time of the THS-SETTLE by protocol. */ +#define RK1808_CSIDPHY_CLK_WR_THS_SETTLE 0x160 +#define RK3326_CSIDPHY_CLK_WR_THS_SETTLE 0x100 +#define RK3368_CSIDPHY_CLK_WR_THS_SETTLE 0x100 + +/* Calibration reception enable */ +#define RK1808_CSIDPHY_CLK_CALIB_EN 0x168 + +#define HIWORD_UPDATE (val, mask) ((val) | (mask) << 16) + +enum dphy_reg_id { +GRF_DPHY_RX0_TURNDISABLE =0 , +GRF_DPHY_RX0_FORCERXMODE , +GRF_DPHY_RX0_FORCETXSTOPMODE , +GRF_DPHY_RX0_ENABLE , +GRF_DPHY_RX0_TURNREQUEST , +GRF_DPHY_TX0_TURNDISABLE , +GRF_DPHY_TX0_FORCERXMODE , +GRF_DPHY_TX0_FORCETXSTOPMODE , +GRF_DPHY_TX0_TURNREQUEST , +GRF_DPHY_RX1_SRC_SEL , +/* rk1808 & rk3326 */ +GRF_DPHY_CSIPHY_FORCERXMODE , +GRF_DPHY_CSIPHY_CLKLANE_EN , +GRF_DPHY_CSIPHY_DATALANE_EN , +}; + +struct dphy_reg { +u32 offset; +u32 mask; +u32 shift; +}; + +#define PHY_REG (_offset, _width, _shift) \ + { .offset = _offset, .mask = BIT(_width) - 1, .shift = _shift, } + +static const struct dphy_reg rk1808_grf_dphy_regs[] = { + [GRF_DPHY_CSIPHY_FORCERXMODE ] =PHY_REG (RK1808_GRF_PD_VI_CON_OFFSET ,4 ,0 ), + [GRF_DPHY_CSIPHY_CLKLANE_EN ] =PHY_REG (RK1808_GRF_PD_VI_CON_OFFSET ,1 ,8 ), + [GRF_DPHY_CSIPHY_DATALANE_EN ] =PHY_REG (RK1808_GRF_PD_VI_CON_OFFSET ,4 ,4 ), +}; + +static const struct dphy_reg rk3326_grf_dphy_regs[] = { + [GRF_DPHY_CSIPHY_FORCERXMODE ] =PHY_REG (RK3326_GRF_PD_VI_CON_OFFSET ,4 ,0 ), + [GRF_DPHY_CSIPHY_CLKLANE_EN ] =PHY_REG (RK3326_GRF_PD_VI_CON_OFFSET ,1 ,8 ), + [GRF_DPHY_CSIPHY_DATALANE_EN ] =PHY_REG (RK3326_GRF_PD_VI_CON_OFFSET ,4 ,4 ), +}; +
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c line 118
Quoted 10 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +10
-0+static const struct dphy_reg rk3368_grf_dphy_regs[] = { + [GRF_DPHY_CSIPHY_FORCERXMODE ] =PHY_REG (RK3368_GRF_SOC_CON6_OFFSET ,4 ,8 ), +}; + +struct hsfreq_range { +u32 range_h; +u8 cfg_bit; +}; + +struct rockchip_inno_csidphy ;
why this forward declaration here, it is not used before defining few lines below?
Quoted 13 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +13
-0+ +struct dphy_drv_data { +int pwrctl_offset; +int ths_settle_offset; +int calib_offset; +const struct hsfreq_range *hsfreq_ranges; +int num_hsfreq_ranges; +const struct dphy_reg *grf_regs; +}; + +struct rockchip_inno_csidphy { +struct device *dev; +void __iomem *phy_base;
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c line 141
Quoted 10 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +10
-0+struct clk *pclk; +struct regmap *grf; +struct reset_control *rst; +const struct dphy_drv_data *drv_data; +struct phy_configure_opts_mipi_dphy config; +u8 hsfreq; +}; + +static inline void write_grf_reg (struct rockchip_inno_csidphy *priv, +int index,u8 value)
align with precceding line opening brace please (checkpatch --strict would warn about such alignment)
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c line 148
Quoted 7 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +7
-0+{ +const struct dphy_drv_data *drv_data = priv->drv_data; +const struct dphy_reg *reg = &drv_data->grf_regs[index]; + +/* Update high word */ +unsigned int val = (value << reg->shift) | + (reg->mask << (reg->shift +16 ));
please use macros in bitfield to avoid shifting..
why calculate val, if reg->offset is not valid, why not do both under the if condition?
Quoted 6 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +6
-0+ +if (reg->offset) +regmap_write (priv->grf, reg->offset, val); +} + +static inline u32 read_grf_reg (struct rockchip_inno_csidphy *priv,int index)
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c line 164
Quoted 10 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +10
-0+{ +const struct dphy_drv_data *drv_data = priv->drv_data; +const struct dphy_reg *reg = &drv_data->grf_regs[index]; +unsigned int val =0 ; + +if (reg->offset) { +regmap_read (priv->grf, reg->offset, &val); + val = (val >> reg->shift) & reg->mask; + } +return val;
so is 0 a valid value to be read?
Quoted 67 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +67
-0+} + +/* These tables must be sorted by .range_h ascending. */ +static const struct hsfreq_range rk1808_mipidphy_hsfreq_ranges[] = { + {109 ,0x02 }, {149 ,0x03 }, {199 ,0x06 }, {249 ,0x06 }, + {299 ,0x06 }, {399 ,0x08 }, {499 ,0x0b }, {599 ,0x0e }, + {699 ,0x10 }, {799 ,0x12 }, {999 ,0x16 }, {1199 ,0x1e }, + {1399 ,0x23 }, {1599 ,0x2d }, {1799 ,0x32 }, {1999 ,0x37 }, + {2199 ,0x3c }, {2399 ,0x41 }, {2499 ,0x46 } +}; + +static const struct hsfreq_range rk3326_mipidphy_hsfreq_ranges[] = { + {109 ,0x00 }, {149 ,0x01 }, {199 ,0x02 }, {249 ,0x03 }, + {299 ,0x04 }, {399 ,0x05 }, {499 ,0x06 }, {599 ,0x07 }, + {699 ,0x08 }, {799 ,0x09 }, {899 ,0x0a }, {1099 ,0x0b }, + {1249 ,0x0c }, {1349 ,0x0d }, {1500 ,0x0e } +}; + +static const struct hsfreq_range rk3368_mipidphy_hsfreq_ranges[] = { + {109 ,0x00 }, {149 ,0x01 }, {199 ,0x02 }, {249 ,0x03 }, + {299 ,0x04 }, {399 ,0x05 }, {499 ,0x06 }, {599 ,0x07 }, + {699 ,0x08 }, {799 ,0x09 }, {899 ,0x0a }, {1099 ,0x0b }, + {1249 ,0x0c }, {1349 ,0x0d }, {1500 ,0x0e } +}; + +static void rockchip_inno_csidphy_ths_settle (struct rockchip_inno_csidphy *priv, +int hsfreq,int offset) +{ +const struct dphy_drv_data *drv_data = priv->drv_data; +u32 val; + + val =readl (priv->phy_base + drv_data->ths_settle_offset + offset); + val &= ~CSIDPHY_THS_SETTLE_MASK ; + val |= hsfreq; +writel (val, priv->phy_base + drv_data->ths_settle_offset + offset); +} + +static int rockchip_inno_csidphy_configure (struct phy *phy, +union phy_configure_opts *opts) +{ +struct rockchip_inno_csidphy *priv =phy_get_drvdata (phy); +const struct dphy_drv_data *drv_data = priv->drv_data; +struct phy_configure_opts_mipi_dphy *config = &opts->mipi_dphy; +unsigned int hsfreq =0 ; +unsigned int i; +u64 data_rate_mbps; +int ret; + +/* pass with phy_mipi_dphy_get_default_config (with pixel rate?) */ + ret =phy_mipi_dphy_config_validate (config); +if (ret) +return ret; + + data_rate_mbps =div_u64 (config->hs_clk_rate,1000 *1000 ); + +dev_dbg (priv->dev,"lanes %d - data_rate_mbps %llu\n" , + config->lanes, data_rate_mbps); +for (i =0 ; i < drv_data->num_hsfreq_ranges; i++) { +if (drv_data->hsfreq_ranges[i].range_h >= data_rate_mbps) { + hsfreq = drv_data->hsfreq_ranges[i].cfg_bit; +break ; + } + } +if (!hsfreq) +return -EINVAL ; + + priv->hsfreq = hsfreq;
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c line 241
Quoted 10 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +10
-0+ priv->config = *config; +return 0 ; +} + +static int rockchip_inno_csidphy_power_on (struct phy *phy) +{ +struct rockchip_inno_csidphy *priv =phy_get_drvdata (phy); +const struct dphy_drv_data *drv_data = priv->drv_data; +u64 data_rate_mbps; +u32 val =0 ;
superfluous init?
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c line 244
Quoted 3 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +3
-0+int ret, i; + + data_rate_mbps =div_u64 (priv->config.hs_clk_rate,1000 *1000 );
helper for this?
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c line 257
Quoted 13 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +13
-0+ + ret =clk_enable (priv->pclk); +if (ret <0 ) +return ret; + +/* phy start */ +if (drv_data->pwrctl_offset >=0 ) +writel (CSIDPHY_CTRL_PWRCTL_UNDEFINED | +CSIDPHY_CTRL_PWRCTL_SYNCRST , + priv->phy_base + drv_data->pwrctl_offset); + +/* set data lane num and enable clock lane */ + val =GENMASK (priv->config.lanes -1 ,0 ) <<CSIDPHY_CTRL_LANE_ENABLE_SHIFT ;
Consider using helpers in bitfield.h instead of using shifts
Quoted 204 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +204
-0+writel (val |CSIDPHY_CTRL_LANE_ENABLE_CK | +CSIDPHY_CTRL_LANE_ENABLE_UNDEFINED , + priv->phy_base +CSIDPHY_CTRL_LANE_ENABLE ); + +/* Reset dphy analog part */ +if (drv_data->pwrctl_offset >=0 ) +writel (CSIDPHY_CTRL_PWRCTL_UNDEFINED , + priv->phy_base + drv_data->pwrctl_offset); +usleep_range (500 ,1000 ); + +/* Reset dphy digital part */ +writel (CSIDPHY_CTRL_DIG_RST_UNDEFINED , + priv->phy_base +CSIDPHY_CTRL_DIG_RST ); +writel (CSIDPHY_CTRL_DIG_RST_UNDEFINED +CSIDPHY_CTRL_DIG_RST_RESET , + priv->phy_base +CSIDPHY_CTRL_DIG_RST ); + +/* not into receive mode/wait stopstate */ +write_grf_reg (priv,GRF_DPHY_CSIPHY_FORCERXMODE ,0x0 ); + +/* enable calibration */ +if (data_rate_mbps >1500 && drv_data->calib_offset >=0 ) { +writel (CSIDPHY_CALIB_EN , + priv->phy_base + drv_data->calib_offset + +CSIDPHY_CLK_CALIB_EN ); +for (i =0 ; i < priv->config.lanes; i++) +writel (CSIDPHY_CALIB_EN , + priv->phy_base + drv_data->calib_offset + +CSIDPHY_LANE_CALIB_EN (i)); + } + +rockchip_inno_csidphy_ths_settle (priv, priv->hsfreq, +CSIDPHY_CLK_THS_SETTLE ); +for (i =0 ; i < priv->config.lanes; i++) +rockchip_inno_csidphy_ths_settle (priv, priv->hsfreq, +CSIDPHY_LANE_THS_SETTLE (i)); + +write_grf_reg (priv,GRF_DPHY_CSIPHY_CLKLANE_EN ,0x1 ); +write_grf_reg (priv,GRF_DPHY_CSIPHY_DATALANE_EN , +GENMASK (priv->config.lanes -1 ,0 )); + +return 0 ; +} + +static int rockchip_inno_csidphy_power_off (struct phy *phy) +{ +struct rockchip_inno_csidphy *priv =phy_get_drvdata (phy); +const struct dphy_drv_data *drv_data = priv->drv_data; + +/* disable all lanes */ +writel (CSIDPHY_CTRL_LANE_ENABLE_UNDEFINED , + priv->phy_base +CSIDPHY_CTRL_LANE_ENABLE ); + +/* disable pll and ldo */ +if (drv_data->pwrctl_offset >=0 ) +writel (CSIDPHY_CTRL_PWRCTL_UNDEFINED | +CSIDPHY_CTRL_PWRCTL_LDO_PD | +CSIDPHY_CTRL_PWRCTL_PLL_PD , + priv->phy_base + drv_data->pwrctl_offset); +usleep_range (500 ,1000 ); + +clk_disable (priv->pclk); + +return 0 ; +} + +static int rockchip_inno_csidphy_init (struct phy *phy) +{ +struct rockchip_inno_csidphy *priv =phy_get_drvdata (phy); + +return clk_prepare (priv->pclk); +} + +static int rockchip_inno_csidphy_exit (struct phy *phy) +{ +struct rockchip_inno_csidphy *priv =phy_get_drvdata (phy); + +clk_unprepare (priv->pclk); + +return 0 ; +} + +static const struct phy_ops rockchip_inno_csidphy_ops = { + .power_on = rockchip_inno_csidphy_power_on, + .power_off = rockchip_inno_csidphy_power_off, + .init = rockchip_inno_csidphy_init, + .exit = rockchip_inno_csidphy_exit, + .configure = rockchip_inno_csidphy_configure, + .owner =THIS_MODULE , +}; + +static const struct dphy_drv_data rk1808_mipidphy_drv_data = { + .pwrctl_offset =-1 , + .ths_settle_offset =RK1808_CSIDPHY_CLK_WR_THS_SETTLE , + .calib_offset =RK1808_CSIDPHY_CLK_CALIB_EN , + .hsfreq_ranges = rk1808_mipidphy_hsfreq_ranges, + .num_hsfreq_ranges =ARRAY_SIZE (rk1808_mipidphy_hsfreq_ranges), + .grf_regs = rk1808_grf_dphy_regs, +}; + +static const struct dphy_drv_data rk3326_mipidphy_drv_data = { + .pwrctl_offset =CSIDPHY_CTRL_PWRCTL , + .ths_settle_offset =RK3326_CSIDPHY_CLK_WR_THS_SETTLE , + .calib_offset =-1 , + .hsfreq_ranges = rk3326_mipidphy_hsfreq_ranges, + .num_hsfreq_ranges =ARRAY_SIZE (rk3326_mipidphy_hsfreq_ranges), + .grf_regs = rk3326_grf_dphy_regs, +}; + +static const struct dphy_drv_data rk3368_mipidphy_drv_data = { + .pwrctl_offset =CSIDPHY_CTRL_PWRCTL , + .ths_settle_offset =RK3368_CSIDPHY_CLK_WR_THS_SETTLE , + .calib_offset =-1 , + .hsfreq_ranges = rk3368_mipidphy_hsfreq_ranges, + .num_hsfreq_ranges =ARRAY_SIZE (rk3368_mipidphy_hsfreq_ranges), + .grf_regs = rk3368_grf_dphy_regs, +}; + +static const struct of_device_id rockchip_inno_csidphy_match_id[] = { + { + .compatible ="rockchip,px30-csi-dphy" , + .data = &rk3326_mipidphy_drv_data, + }, + { + .compatible ="rockchip,rk1808-csi-dphy" , + .data = &rk1808_mipidphy_drv_data, + }, + { + .compatible ="rockchip,rk3326-csi-dphy" , + .data = &rk3326_mipidphy_drv_data, + }, + { + .compatible ="rockchip,rk3368-csi-dphy" , + .data = &rk3368_mipidphy_drv_data, + }, + {} +}; +MODULE_DEVICE_TABLE (of, rockchip_inno_csidphy_match_id); + + +static int rockchip_inno_csidphy_probe (struct platform_device *pdev) +{ +struct rockchip_inno_csidphy *priv; +struct device *dev = &pdev->dev; +struct phy_provider *phy_provider; +struct phy *phy; + + priv =devm_kzalloc (dev,sizeof (*priv),GFP_KERNEL ); +if (!priv) +return -ENOMEM ; + + priv->dev = dev; +platform_set_drvdata (pdev, priv); + + priv->drv_data =of_device_get_match_data (dev); +if (!priv->drv_data) { +dev_err (dev,"Can't find device data\n" ); +return -ENODEV ; + } + + priv->grf =syscon_regmap_lookup_by_phandle (dev->of_node, +"rockchip,grf" ); +if (IS_ERR (priv->grf)) { +dev_err (dev,"Can't find GRF syscon\n" ); +return PTR_ERR (priv->grf); + } + + priv->phy_base =devm_platform_ioremap_resource (pdev,0 ); +if (IS_ERR (priv->phy_base)) +return PTR_ERR (priv->phy_base); + + priv->pclk =devm_clk_get (dev,"pclk" ); +if (IS_ERR (priv->pclk)) { +dev_err (dev,"failed to get pclk\n" ); +return PTR_ERR (priv->pclk); + } + + priv->rst =devm_reset_control_get (dev,"apb" ); +if (IS_ERR (priv->rst)) { +dev_err (dev,"failed to get system reset control\n" ); +return PTR_ERR (priv->rst); + } + + phy =devm_phy_create (dev,NULL , &rockchip_inno_csidphy_ops); +if (IS_ERR (phy)) { +dev_err (dev,"failed to create phy\n" ); +return PTR_ERR (phy); + } + +phy_set_drvdata (phy, priv); + + phy_provider =devm_of_phy_provider_register (dev, of_phy_simple_xlate); +if (IS_ERR (phy_provider)) { +dev_err (dev,"failed to register phy provider\n" ); +return PTR_ERR (phy_provider); + } + +pm_runtime_enable (dev); + +return 0 ; +} + +static int rockchip_inno_csidphy_remove (struct platform_device *pdev) +{ +struct rockchip_inno_csidphy *priv =platform_get_drvdata (pdev);
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c line 471
Quoted 10 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +10
-0+ +pm_runtime_disable (priv->dev); + +return 0 ; +} + +static struct platform_driver rockchip_inno_csidphy_driver = { + .driver = { + .name ="rockchip-inno-csidphy" , + .of_match_table = rockchip_inno_csidphy_match_id,
double indent here?
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c line 480
Quoted 9 lines
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c new file +9
-0+ }, + .probe = rockchip_inno_csidphy_probe, + .remove = rockchip_inno_csidphy_remove, +}; + +module_platform_driver (rockchip_inno_csidphy_driver); +MODULE_AUTHOR ("Heiko Stuebner <[email protected]>" ); +MODULE_DESCRIPTION ("Rockchip MIPI Innosilicon CSI-DPHY driver" ); +MODULE_LICENSE ("Dual BSD/GPL" );
That is not what the SPDX tag for file says?
Signature · 6 lines
~Vinod _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip