Skip to contentSkip to conversation

scsi: qla2xxx: Removed extra space in variable declaration.

PATCH In review Milan P. Gandhi 3 participants 4 messages Feb 11, 2021 – Feb 12, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 scsi: qla2xxx: Removed extra space in variable declaration.

Removed extra space in variable declaration in qla2x00_sysfs_write_nvram

---
changes v2:
- Added a small note about change.
---

drivers/scsi/qla2xxx/qla_attr.c +1 -1
index ab45ac1e5a72..7f2db8badb6d 100644
@@ -226,7 +226,7 @@ qla2x00_sysfs_write_nvram(struct file *filp, struct kobject *kobj,
 	struct scsi_qla_host *vha = shost_priv(dev_to_shost(container_of(kobj,
 	    struct device, kobj)));
 	struct qla_hw_data *ha = vha->hw;
-	uint16_t	cnt;
+	uint16_t cnt;
 
 	if (!capable(CAP_SYS_ADMIN) || off != 0 || count != ha->nvram_size ||
 	    !ha->isp_ops->write_nvram)
#1 lore raw
Quoted 12 lines · Milan P. Gandhi

Removed extra space in variable declaration in qla2x00_sysfs_write_nvram

---
changes v2:
- Added a small note about change.
---

drivers/scsi/qla2xxx/qla_attr.c +0 -0
index ab45ac1e5a72..7f2db8badb6d 100644

drivers/scsi/qla2xxx/qla_attr.c qla2x00_sysfs_write_nvram(struct file *filp, struct kobject *kobj, · line 232

Quoted 8 lines
drivers/scsi/qla2xxx/qla_attr.c +1 -1
@@ -226,7 +226,7 @@ qla2x00_sysfs_write_nvram(struct file *filp, struct kobject *kobj,
 	struct scsi_qla_host *vha = shost_priv(dev_to_shost(container_of(kobj,
 	    struct device, kobj)));
 	struct qla_hw_data *ha = vha->hw;
-	uint16_t	cnt;
+	uint16_t cnt;
 
 	if (!capable(CAP_SYS_ADMIN) || off != 0 || count != ha->nvram_size ||
 	    !ha->isp_ops->write_nvram)

I'm not sure if such a patch is considered substantial enough to be included upstream.

For future patches, please follow the guidelines for submitting patches and use the imperative mood for the subject (Removed -> Remove) and do not end the patch subject with a dot. See also Documentation/process/submitting-patches.rst

Bart.

#2 lore raw

Hi Milan,

Quoted 25 lines · Bart Van Assche
Quoted 12 lines · Milan P. Gandhi

Removed extra space in variable declaration in qla2x00_sysfs_write_nvram

---
changes v2:
- Added a small note about change.
---

drivers/scsi/qla2xxx/qla_attr.c +0 -0
index ab45ac1e5a72..7f2db8badb6d 100644

drivers/scsi/qla2xxx/qla_attr.c qla2x00_sysfs_write_nvram(struct file *filp, struct kobject *kobj, · line 232

Quoted 8 lines
drivers/scsi/qla2xxx/qla_attr.c +1 -1
@@ -226,7 +226,7 @@ qla2x00_sysfs_write_nvram(struct file *filp, struct kobject *kobj,
  	struct scsi_qla_host *vha = shost_priv(dev_to_shost(container_of(kobj,
  	    struct device, kobj)));
  	struct qla_hw_data *ha = vha->hw;
-	uint16_t	cnt;
+	uint16_t cnt;
 
  	if (!capable(CAP_SYS_ADMIN) || off != 0 || count != ha->nvram_size ||
  	    !ha->isp_ops->write_nvram)

I'm not sure if such a patch is considered substantial enough to be included upstream.

Quoted 8 lines

For future patches, please follow the guidelines for submitting patches and use the imperative mood for the subject (Removed -> Remove) and do not end the patch subject with a dot. See also Documentation/process/submitting-patches.rst

Bart.

Agree with Bart here.

What was motivation behind this patch?

if you scroll through code, i am pretty sure you will find more than one place where spaces are not consistent (especially 15+ yr old code).

Signature · 1 line
Himanshu Madhani                               Oracle Linux Engineering
#3 lore raw

Hi Bart, Himanshu,

Quoted 32 lines · Himanshu Madhani

Hi Milan,

Quoted 29 lines · Bart Van Assche
Quoted 17 lines · Milan P. Gandhi

Removed extra space in variable declaration in qla2x00_sysfs_write_nvram

---
changes v2:
  - Added a small note about change.
---

drivers/scsi/qla2xxx/qla_attr.c +1 -1
index ab45ac1e5a72..7f2db8badb6d 100644
@@ -226,7 +226,7 @@ qla2x00_sysfs_write_nvram(struct file *filp, struct kobject *kobj,
       struct scsi_qla_host *vha = shost_priv(dev_to_shost(container_of(kobj,
           struct device, kobj)));
       struct qla_hw_data *ha = vha->hw;
-    uint16_t    cnt;
+    uint16_t cnt;
Quoted 2 lines

        if (!capable(CAP_SYS_ADMIN) || off != 0 || count != ha->nvram_size || !ha->isp_ops->write_nvram)

I'm not sure if such a patch is considered substantial enough to be included upstream.

For future patches, please follow the guidelines for submitting patches and use the imperative mood for the subject (Removed -> Remove) and do not end the patch subject with a dot. See also Documentation/process/submitting-patches.rst

Quoted 9 lines
Quoted 3 lines

Bart.

Agree with Bart here.

What was motivation behind this patch?

if you scroll through code, i am pretty sure you will find more than one place where spaces are not consistent (especially 15+ yr old code).

I thought it was a typo and extra space was left, so just fixed it.
But it looks that there are many other places in qla2xxx source with similar declarations. I apologize for the noise.

Thanks,
Milan.