Skip to contentSkip to conversation

linux-next: Fixes tag needs some work in the ftrace tree

DISCUSSION Stephen Rothwell 3 participants 3 messages Feb 11, 2021 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

In commit

b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax errors")

Fixes tag

Fixes 81ff92a93d95 (selftests/ftrace: Add test case for synthetic

has these problem(s):

- Subject has leading but no trailing parentheses

Please do not split Fixes tags over more than one line. Also, keep all the commit message tags together at the end of the message.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 8 lines · On Fri, 12 Feb 2021 07:57:28 +1100 Stephen Rothwell <[email protected]>…

Hi all,

In commit

b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax errors")

Fixes tag

Quoted 9 lines
Fixes 81ff92a93d95 (selftests/ftrace: Add test case for synthetic

has these problem(s):

- Subject has leading but no trailing parentheses

Please do not split Fixes tags over more than one line. Also, keep all the commit message tags together at the end of the message.

Thanks, I didn't even notice that :-/

Tom, FYI for next time ;-)

-- Steve

#2 lore raw
Quoted 19 lines · Steven Rostedt
Quoted 16 lines · On Fri, 12 Feb 2021 07:57:28 +1100 Stephen Rothwell <[email protected]>…

Hi all,

In commit

b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax
errors")

Fixes tag

Fixes 81ff92a93d95 (selftests/ftrace: Add test case for

synthetic

has these problem(s):

- Subject has leading but no trailing parentheses

Quoted 9 lines
Quoted 4 lines

Please do not split Fixes tags over more than one line. Also, keep all
the commit message tags together at the end of the message.

Thanks, I didn't even notice that :-/

Tom, FYI for next time ;-)

Yep, thanks, Stephen, for pointing that out, didn't realize it until now either.

Tom

Quoted 1 line

-- Steve